Re: [FFmpeg-devel] [PATCH V1] avformat/avformat.h: correct the comment for AVInputFormat.extensions

2019-04-13 Thread Michael Niedermayer
On Sat, Apr 13, 2019 at 08:46:06AM +0800, Jun Zhao wrote:
> From: Jun Zhao 
> 
> Now the probe logic is: Only read_probe is NULL and extensions are defined,
> then no probe is done. Correct the comment to follow the coding logic.
> 
> Signed-off-by: Jun Zhao 
> ---
>  libavformat/avformat.h |4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index 734ae54..bbfa61d 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -659,8 +659,8 @@ typedef struct AVInputFormat {
>  int flags;
>  
>  /**
> - * If extensions are defined, then no probe is done. You should
> - * usually not use extension format guessing because it is not

> + * If read_probe is NULL and extensions are defined, then no probe is 
> done.

Why do you refer to extensions here ?
if read_probe is not set (NULL), no probe (based on input content) can be done,
extensions does not change that.

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH V1] avformat/avformat.h: correct the comment for AVInputFormat.extensions

2019-04-12 Thread Jun Zhao
From: Jun Zhao 

Now the probe logic is: Only read_probe is NULL and extensions are defined,
then no probe is done. Correct the comment to follow the coding logic.

Signed-off-by: Jun Zhao 
---
 libavformat/avformat.h |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavformat/avformat.h b/libavformat/avformat.h
index 734ae54..bbfa61d 100644
--- a/libavformat/avformat.h
+++ b/libavformat/avformat.h
@@ -659,8 +659,8 @@ typedef struct AVInputFormat {
 int flags;
 
 /**
- * If extensions are defined, then no probe is done. You should
- * usually not use extension format guessing because it is not
+ * If read_probe is NULL and extensions are defined, then no probe is done.
+ * You should usually not use extension format guessing because it is not
  * reliable enough
  */
 const char *extensions;
-- 
1.7.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".