Re: [FFmpeg-devel] [PATCH v1] lavf/dump: dump the vbv_delay with N/A instead of 18446744073709551615

2019-08-28 Thread Michael Niedermayer 
On Tue, Aug 27, 2019 at 10:36:58PM +0800, Limin Wang wrote:
> 
> Add Reviewed-by: only, please help to push it, thanks.

will apply

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v1] lavf/dump: dump the vbv_delay with N/A instead of 18446744073709551615

2019-08-27 Thread lance . lmwang 
From: Limin Wang 

How to check it:
./ffmpeg -f lavfi -i testsrc  -c:v mpeg2video  -f null  -
master:
  Side data:
cpb: bitrate max/min/avg: 0/0/20 buffer size: 0 vbv_delay:
18446744073709551615
patch applied:
Side data:
  cpb: bitrate max/min/avg: 0/0/20 buffer size: 0 vbv_delay: N/A

Reviewed-by: Michael Niedermayer 
Signed-off-by: Limin Wang 
---
 libavformat/dump.c | 11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/libavformat/dump.c b/libavformat/dump.c
index a3791a3..56814ff 100644
--- a/libavformat/dump.c
+++ b/libavformat/dump.c
@@ -321,13 +321,16 @@ static void dump_cpb(void *ctx, AVPacketSideData *sd)
 
 av_log(ctx, AV_LOG_INFO,
 #if FF_API_UNSANITIZED_BITRATES
-   "bitrate max/min/avg: %d/%d/%d buffer size: %d vbv_delay: %"PRIu64,
+   "bitrate max/min/avg: %d/%d/%d buffer size: %d ",
 #else
-   "bitrate max/min/avg: %"PRId64"/%"PRId64"/%"PRId64" buffer size: %d 
vbv_delay: %"PRIu64,
+   "bitrate max/min/avg: %"PRId64"/%"PRId64"/%"PRId64" buffer size: %d 
",
 #endif
cpb->max_bitrate, cpb->min_bitrate, cpb->avg_bitrate,
-   cpb->buffer_size,
-   cpb->vbv_delay);
+   cpb->buffer_size);
+if (cpb->vbv_delay == UINT64_MAX)
+av_log(ctx, AV_LOG_INFO, "vbv_delay: N/A");
+else
+av_log(ctx, AV_LOG_INFO, "vbv_delay: %"PRIu64"", cpb->vbv_delay);
 }
 
 static void dump_mastering_display_metadata(void *ctx, AVPacketSideData* sd) {
-- 
2.6.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1] lavf/dump: dump the vbv_delay with N/A instead of 18446744073709551615

2019-08-27 Thread Limin Wang 

Add Reviewed-by: only, please help to push it, thanks.

On Tue, Aug 27, 2019 at 10:34:54PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang 
> 
> How to check it:
> ./ffmpeg -f lavfi -i testsrc  -c:v mpeg2video  -f null  -
> master:
>   Side data:
> cpb: bitrate max/min/avg: 0/0/20 buffer size: 0 vbv_delay:
> 18446744073709551615
> patch applied:
> Side data:
>   cpb: bitrate max/min/avg: 0/0/20 buffer size: 0 vbv_delay: N/A
> 
> Reviewed-by: Michael Niedermayer 
> Signed-off-by: Limin Wang 
> ---
>  libavformat/dump.c | 11 +++
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/dump.c b/libavformat/dump.c
> index a3791a3..56814ff 100644
> --- a/libavformat/dump.c
> +++ b/libavformat/dump.c
> @@ -321,13 +321,16 @@ static void dump_cpb(void *ctx, AVPacketSideData *sd)
>  
>  av_log(ctx, AV_LOG_INFO,
>  #if FF_API_UNSANITIZED_BITRATES
> -   "bitrate max/min/avg: %d/%d/%d buffer size: %d vbv_delay: 
> %"PRIu64,
> +   "bitrate max/min/avg: %d/%d/%d buffer size: %d ",
>  #else
> -   "bitrate max/min/avg: %"PRId64"/%"PRId64"/%"PRId64" buffer size: 
> %d vbv_delay: %"PRIu64,
> +   "bitrate max/min/avg: %"PRId64"/%"PRId64"/%"PRId64" buffer size: 
> %d ",
>  #endif
> cpb->max_bitrate, cpb->min_bitrate, cpb->avg_bitrate,
> -   cpb->buffer_size,
> -   cpb->vbv_delay);
> +   cpb->buffer_size);
> +if (cpb->vbv_delay == UINT64_MAX)
> +av_log(ctx, AV_LOG_INFO, "vbv_delay: N/A");
> +else
> +av_log(ctx, AV_LOG_INFO, "vbv_delay: %"PRIu64"", cpb->vbv_delay);
>  }
>  
>  static void dump_mastering_display_metadata(void *ctx, AVPacketSideData* sd) 
> {
> -- 
> 2.6.4
> 
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1] lavf/dump: dump the vbv_delay with N/A instead of 18446744073709551615

2019-08-20 Thread Michael Niedermayer 
On Sun, Aug 18, 2019 at 10:31:20PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang 
> 
> Signed-off-by: Limin Wang 
> ---
>  libavformat/dump.c | 11 +++
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/dump.c b/libavformat/dump.c
> index a3791a3..56814ff 100644
> --- a/libavformat/dump.c
> +++ b/libavformat/dump.c
> @@ -321,13 +321,16 @@ static void dump_cpb(void *ctx, AVPacketSideData *sd)
>  
>  av_log(ctx, AV_LOG_INFO,
>  #if FF_API_UNSANITIZED_BITRATES
> -   "bitrate max/min/avg: %d/%d/%d buffer size: %d vbv_delay: 
> %"PRIu64,
> +   "bitrate max/min/avg: %d/%d/%d buffer size: %d ",
>  #else
> -   "bitrate max/min/avg: %"PRId64"/%"PRId64"/%"PRId64" buffer size: 
> %d vbv_delay: %"PRIu64,
> +   "bitrate max/min/avg: %"PRId64"/%"PRId64"/%"PRId64" buffer size: 
> %d ",
>  #endif
> cpb->max_bitrate, cpb->min_bitrate, cpb->avg_bitrate,
> -   cpb->buffer_size,
> -   cpb->vbv_delay);
> +   cpb->buffer_size);
> +if (cpb->vbv_delay == UINT64_MAX)
> +av_log(ctx, AV_LOG_INFO, "vbv_delay: N/A");
> +else
> +av_log(ctx, AV_LOG_INFO, "vbv_delay: %"PRIu64"", cpb->vbv_delay);
>  }

LGTM

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Modern terrorism, a quick summary: Need oil, start war with country that
has oil, kill hundread thousand in war. Let country fall into chaos,
be surprised about raise of fundamantalists. Drop more bombs, kill more
people, be surprised about them taking revenge and drop even more bombs
and strip your own citizens of their rights and freedoms. to be continued


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v1] lavf/dump: dump the vbv_delay with N/A instead of 18446744073709551615

2019-08-18 Thread lance . lmwang 
From: Limin Wang 

Signed-off-by: Limin Wang 
---
 libavformat/dump.c | 11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/libavformat/dump.c b/libavformat/dump.c
index a3791a3..56814ff 100644
--- a/libavformat/dump.c
+++ b/libavformat/dump.c
@@ -321,13 +321,16 @@ static void dump_cpb(void *ctx, AVPacketSideData *sd)
 
 av_log(ctx, AV_LOG_INFO,
 #if FF_API_UNSANITIZED_BITRATES
-   "bitrate max/min/avg: %d/%d/%d buffer size: %d vbv_delay: %"PRIu64,
+   "bitrate max/min/avg: %d/%d/%d buffer size: %d ",
 #else
-   "bitrate max/min/avg: %"PRId64"/%"PRId64"/%"PRId64" buffer size: %d 
vbv_delay: %"PRIu64,
+   "bitrate max/min/avg: %"PRId64"/%"PRId64"/%"PRId64" buffer size: %d 
",
 #endif
cpb->max_bitrate, cpb->min_bitrate, cpb->avg_bitrate,
-   cpb->buffer_size,
-   cpb->vbv_delay);
+   cpb->buffer_size);
+if (cpb->vbv_delay == UINT64_MAX)
+av_log(ctx, AV_LOG_INFO, "vbv_delay: N/A");
+else
+av_log(ctx, AV_LOG_INFO, "vbv_delay: %"PRIu64"", cpb->vbv_delay);
 }
 
 static void dump_mastering_display_metadata(void *ctx, AVPacketSideData* sd) {
-- 
2.6.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".