Re: [FFmpeg-devel] [PATCH v1 3/6] avcodec/xwddec: cosmetics

2019-10-11 Thread Paul B Mahol 
On 10/11/19, Limin Wang  wrote:
> On Fri, Oct 11, 2019 at 01:45:34PM +0200, Paul B Mahol wrote:
>> pointless
>>
> It's OK, I saw two different code style, so I change it for consistent.
>

No, it is not OK, please refrain from posting such patches, they are
considered spam.

Also stop posting messages only to me.

> It seems that the current style is used more than changed in same file:
> line 105:
> avpriv_request_sample(avctx, "xoffset %"PRIu32"", xoffset);
> line 208
> avpriv_request_sample(avctx,
>"Unknown file: bpp %"PRIu32", pixdepth
> %"PRIu32", vclass %"PRIu32"",
>bpp, pixdepth, vclass);
>
>
>> On 10/11/19, lance.lmw...@gmail.com  wrote:
>> > From: Limin Wang 
>> >
>> > Signed-off-by: Limin Wang 
>> > ---
>> >  libavcodec/xwddec.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/libavcodec/xwddec.c b/libavcodec/xwddec.c
>> > index 8c4358fd4c..924ba020da 100644
>> > --- a/libavcodec/xwddec.c
>> > +++ b/libavcodec/xwddec.c
>> > @@ -151,7 +151,7 @@ static int xwd_decode_frame(AVCodecContext *avctx,
>> > void
>> > *data,
>> >  }
>> >
>> >  if (pixformat != XWD_Z_PIXMAP) {
>> > -avpriv_report_missing_feature(avctx, "Pixmap format %"PRIu32,
>> > pixformat);
>> > +avpriv_report_missing_feature(avctx, "Pixmap format
>> > %"PRIu32"",
>> > pixformat);
>> >  return AVERROR_PATCHWELCOME;
>> >  }
>> >
>> > --
>> > 2.21.0
>> >
>> > ___
>> > ffmpeg-devel mailing list
>> > ffmpeg-devel@ffmpeg.org
>> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> >
>> > To unsubscribe, visit link above, or email
>> > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1 3/6] avcodec/xwddec: cosmetics

2019-10-11 Thread Paul B Mahol 
pointless

On 10/11/19, lance.lmw...@gmail.com  wrote:
> From: Limin Wang 
>
> Signed-off-by: Limin Wang 
> ---
>  libavcodec/xwddec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/xwddec.c b/libavcodec/xwddec.c
> index 8c4358fd4c..924ba020da 100644
> --- a/libavcodec/xwddec.c
> +++ b/libavcodec/xwddec.c
> @@ -151,7 +151,7 @@ static int xwd_decode_frame(AVCodecContext *avctx, void
> *data,
>  }
>
>  if (pixformat != XWD_Z_PIXMAP) {
> -avpriv_report_missing_feature(avctx, "Pixmap format %"PRIu32,
> pixformat);
> +avpriv_report_missing_feature(avctx, "Pixmap format %"PRIu32"",
> pixformat);
>  return AVERROR_PATCHWELCOME;
>  }
>
> --
> 2.21.0
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v1 3/6] avcodec/xwddec: cosmetics

2019-10-11 Thread lance . lmwang 
From: Limin Wang 

Signed-off-by: Limin Wang 
---
 libavcodec/xwddec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/xwddec.c b/libavcodec/xwddec.c
index 8c4358fd4c..924ba020da 100644
--- a/libavcodec/xwddec.c
+++ b/libavcodec/xwddec.c
@@ -151,7 +151,7 @@ static int xwd_decode_frame(AVCodecContext *avctx, void 
*data,
 }
 
 if (pixformat != XWD_Z_PIXMAP) {
-avpriv_report_missing_feature(avctx, "Pixmap format %"PRIu32, 
pixformat);
+avpriv_report_missing_feature(avctx, "Pixmap format %"PRIu32"", 
pixformat);
 return AVERROR_PATCHWELCOME;
 }
 
-- 
2.21.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".