[FFmpeg-devel] [PATCH v2] avcodec/pngdec: apng: fix output buffer filling when no blending is needed.

2014-11-28 Thread Benoit Fouet
---
 libavcodec/pngdec.c | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index a330d36..9e52d0b 100644
--- a/libavcodec/pngdec.c
+++ b/libavcodec/pngdec.c
@@ -927,7 +927,17 @@ static int handle_p_frame_apng(AVCodecContext *avctx, 
PNGDecContext *s,
 pd  += s-image_linesize;
 pd_last += s-image_linesize;
 }
+} else {
+for (j = s-y_offset; j  s-y_offset + s-cur_h; j++) {
+for (i = 0; i  s-x_offset * s-bpp; i++)
+pd[i] = pd_last[i];
+for (i = (s-x_offset + s-cur_w) * s-bpp; i  ls; i++)
+pd[i] = pd_last[i];
+pd  += s-image_linesize;
+pd_last += s-image_linesize;
+}
 }
+
 for (j = s-y_offset + s-cur_h; j  s-height; j++) {
 for (i = 0; i  ls; i++)
 pd[i] = pd_last[i];
-- 
2.2.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH v2] avcodec/pngdec: apng: fix output buffer filling when no blending is needed.

2014-11-28 Thread Benoit Fouet

Hi,

Le 28/11/2014 18:33, Michael Niedermayer a écrit :

On Fri, Nov 28, 2014 at 04:54:09PM +0100, Benoit Fouet wrote:

---
  libavcodec/pngdec.c | 10 ++
  1 file changed, 10 insertions(+)

applied

maybe some of this can be factorized with the code above the
else, though iam not sure it would be better


I hesitated to do it, but chose not to. I have no real preference, to be 
honest.


--
Ben

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel