Re: [FFmpeg-devel] [PATCH v2] lavd/decklink_common: Fix error caused by -Werror=missing-prototypes
Le decadi 10 messidor, an CCXXIV, Michael Niedermayer a écrit : > > The error is being thrown when the location of the decklink headers being > > pulled in as user includes with -I. > > i would assume the same happens with any header, i didnt try but > libc headers likely will also fail with sufficient pedant warning/error > if they are included as "user headers" It happens even with FFmpeg's own headers: -Ilibavutil will cause build failures due to a conflicting time.h. The short of it is they should not add -Ilibavutil. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH v2] lavd/decklink_common: Fix error caused by -Werror=missing-prototypes
On Sun, Jun 26, 2016 at 09:00:58PM -0400, Richard Kern wrote: > > > On Jun 25, 2016, at 3:16 PM, Michael Niedermayer> > wrote: > > > > On Sat, Jun 25, 2016 at 05:29:56PM +, Carl Eugen Hoyos wrote: > >> Michael Niedermayer niedermayer.cc> writes: > >> > >>> why does this happen ? > >> > >> I thought it happens because FFmpeg include third-party > >> files that do not copmile with error=missing-prototypes. > > > > but why should they build with random "warning are error" flags ? > > one cannot write headers that are guranteed to never trigger a warning > > on any compiler. > > and if one cannot and does not, -Werror* could not work unless it > > has an exception for system / 3rd party stuff > > The error is being thrown when the location of the decklink headers being > pulled in as user includes with -I. i would assume the same happens with any header, i didnt try but libc headers likely will also fail with sufficient pedant warning/error if they are included as "user headers" > Clang doesn’t support -i, and I couldn’t > find an equivalent option to include as system headers. Am I missing > something? http://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-in-system-headers [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 2 "100% positive feedback" - "All either got their money back or didnt complain" "Best seller ever, very honest" - "Seller refunded buyer after failed scam" signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH v2] lavd/decklink_common: Fix error caused by -Werror=missing-prototypes
> On Jun 25, 2016, at 3:16 PM, Michael Niedermayer> wrote: > > On Sat, Jun 25, 2016 at 05:29:56PM +, Carl Eugen Hoyos wrote: >> Michael Niedermayer niedermayer.cc> writes: >> >>> why does this happen ? >> >> I thought it happens because FFmpeg include third-party >> files that do not copmile with error=missing-prototypes. > > but why should they build with random "warning are error" flags ? > one cannot write headers that are guranteed to never trigger a warning > on any compiler. > and if one cannot and does not, -Werror* could not work unless it > has an exception for system / 3rd party stuff The error is being thrown when the location of the decklink headers being pulled in as user includes with -I. Clang doesn’t support -i, and I couldn’t find an equivalent option to include as system headers. Am I missing something? > > also see: > > http://stackoverflow.com/questions/1867065/how-to-suppress-gcc-warnings-from-library-headers > http://stackoverflow.com/questions/3308523/how-to-eliminate-external-lib-third-party-warnings-in-gcc > > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Republics decline into democracies and democracies degenerate into > despotisms. -- Aristotle > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH v2] lavd/decklink_common: Fix error caused by -Werror=missing-prototypes
On Sat, Jun 25, 2016 at 05:29:56PM +, Carl Eugen Hoyos wrote: > Michael Niedermayer niedermayer.cc> writes: > > > why does this happen ? > > I thought it happens because FFmpeg include third-party > files that do not copmile with error=missing-prototypes. but why should they build with random "warning are error" flags ? one cannot write headers that are guranteed to never trigger a warning on any compiler. and if one cannot and does not, -Werror* could not work unless it has an exception for system / 3rd party stuff also see: http://stackoverflow.com/questions/1867065/how-to-suppress-gcc-warnings-from-library-headers http://stackoverflow.com/questions/3308523/how-to-eliminate-external-lib-third-party-warnings-in-gcc [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH v2] lavd/decklink_common: Fix error caused by -Werror=missing-prototypes
Michael Niedermayer niedermayer.cc> writes: > why does this happen ? I thought it happens because FFmpeg include third-party files that do not copmile with error=missing-prototypes. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH v2] lavd/decklink_common: Fix error caused by -Werror=missing-prototypes
On Fri, Jun 24, 2016 at 10:03:17PM -0400, Rick Kern wrote: > decklink_common.cpp includes a .cpp file from the DeckLink API which fails > to build because there are non-static functions in the included .cpp file. > This disables the missing-prototypes error so the file can be included. why does this happen ? the compiler (gcc at least) should not produce warnings or related errors for system headers, why does this not apply to this cpp file ? is it installed correctly and the compiler correctly setup so it knows the directory its in is for such headers ? Also you can add flags specific to building one file grep for CFLAGS in Makefiles to see examples [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of Human Excellence is to question oneself and others. -- Socrates signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH v2] lavd/decklink_common: Fix error caused by -Werror=missing-prototypes
decklink_common.cpp includes a .cpp file from the DeckLink API which fails to build because there are non-static functions in the included .cpp file. This disables the missing-prototypes error so the file can be included. Signed-off-by: Rick Kern--- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 3787894..9068d6c 100755 --- a/configure +++ b/configure @@ -5615,7 +5615,8 @@ enabled cuvid && { check_lib cuviddec.h cuvidCreateDecoder -lnvcuvid enabled chromaprint && require chromaprint chromaprint.h chromaprint_get_version -lchromaprint enabled coreimage_filter && { check_header_objcc QuartzCore/CoreImage.h || disable coreimage_filter; } enabled coreimagesrc_filter && { check_header_objcc QuartzCore/CoreImage.h || disable coreimagesrc_filter; } -enabled decklink && { check_header DeckLinkAPI.h || die "ERROR: DeckLinkAPI.h header not found"; } +enabled decklink && { { check_header DeckLinkAPI.h || die "ERROR: DeckLinkAPI.h header not found"; } && + add_cxxflags -Wno-error=missing-prototypes; } enabled frei0r&& { check_header frei0r.h || die "ERROR: frei0r.h header not found"; } enabled gmp && require2 gmp gmp.h mpz_export -lgmp enabled gnutls&& require_pkg_config gnutls gnutls/gnutls.h gnutls_global_init -- 2.9.0 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel