Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/vc1: FIELDTX is only present in interlaced frame I/BI pictures

2018-05-20 Thread Michael Niedermayer 
On Sun, May 20, 2018 at 01:45:56PM +0200, Jerome Borsboom wrote:
> If v->fieldtx_is_raw is not reset to zero, it may spill over from a previous
> interlaced frame I/BI picture.
> 
> Signed-off-by: Jerome Borsboom 
> ---
> This may address the concerns. Will make a mental note to clean up the parser
> at a later time.
> 
> Thank you for the review.

will apply

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/vc1: FIELDTX is only present in interlaced frame I/BI pictures

2018-05-20 Thread Jerome Borsboom 
If v->fieldtx_is_raw is not reset to zero, it may spill over from a previous
interlaced frame I/BI picture.

Signed-off-by: Jerome Borsboom 
---
This may address the concerns. Will make a mental note to clean up the parser
at a later time.

Thank you for the review.

 libavcodec/vc1.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavcodec/vc1.c b/libavcodec/vc1.c
index 949fec6bee..98b24e8e57 100644
--- a/libavcodec/vc1.c
+++ b/libavcodec/vc1.c
@@ -1010,7 +1010,8 @@ int ff_vc1_parse_frame_header_adv(VC1Context *v, 
GetBitContext* gb)
 return -1;
 av_log(v->s.avctx, AV_LOG_DEBUG, "FIELDTX plane encoding: "
"Imode: %i, Invert: %i\n", status>>1, status&1);
-}
+} else
+v->fieldtx_is_raw = 0;
 status = bitplane_decoding(v->acpred_plane, >acpred_is_raw, v);
 if (status < 0)
 return -1;
-- 
2.13.6


___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel