Re: [FFmpeg-devel] [PATCH v2 2/5] avformat/http: add "Opening" info logging to ff_http_do_new_request
On Fri, Dec 15, 2017 at 11:34 AM Michael Niedermayerwrote: > On Tue, Dec 12, 2017 at 04:35:08PM -0800, Aman Gupta wrote: > > From: Aman Gupta > > > > This mimics logging that was added in 53e0d5d7247 for security > > purposes. > > --- > > libavformat/http.c | 1 + > > 1 file changed, 1 insertion(+) > > iam not sure this does not cause too much noise with image sequences > image%d.jpg for example > > but LGTM if that is not an issue or noone minds Not a problem as this only affects ff_http_do_new_request, which is used just from hls and rtmp muxers. > > thanks > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Elect your leaders based on what they did after the last election, not > based on what they say before an election. > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH v2 2/5] avformat/http: add "Opening" info logging to ff_http_do_new_request
On Tue, Dec 12, 2017 at 04:35:08PM -0800, Aman Gupta wrote: > From: Aman Gupta> > This mimics logging that was added in 53e0d5d7247 for security > purposes. > --- > libavformat/http.c | 1 + > 1 file changed, 1 insertion(+) iam not sure this does not cause too much noise with image sequences image%d.jpg for example but LGTM if that is not an issue or noone minds thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Elect your leaders based on what they did after the last election, not based on what they say before an election. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH v2 2/5] avformat/http: add "Opening" info logging to ff_http_do_new_request
From: Aman GuptaThis mimics logging that was added in 53e0d5d7247 for security purposes. --- libavformat/http.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/http.c b/libavformat/http.c index a3c36423fc..ffdf11cf7e 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -336,6 +336,7 @@ int ff_http_do_new_request(URLContext *h, const char *uri) if (!s->location) return AVERROR(ENOMEM); +av_log(s, AV_LOG_INFO, "Opening \'%s\' for %s\n", uri, h->flags & AVIO_FLAG_WRITE ? "writing" : "reading"); ret = http_open_cnx(h, ); av_dict_free(); return ret; -- 2.14.3 (Apple Git-98) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel