Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mov: prevent potential use of uninitialized value

2022-06-11 Thread Paul B Mahol
lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


[FFmpeg-devel] [PATCH v3 2/2] avformat/mov: prevent potential use of uninitialized value

2022-06-11 Thread Martijn van Beurden
---
 libavformat/mov.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index d7be593a86..51c0f6f9d8 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -6772,7 +6772,10 @@ static int mov_read_dfla(MOVContext *c, AVIOContext *pb, 
MOVAtom atom)
 
 avio_rb24(pb); /* Flags */
 
-avio_read(pb, buf, sizeof(buf));
+if (avio_read(pb, buf, sizeof(buf)) != sizeof(buf)) {
+av_log(c->fc, AV_LOG_ERROR, "failed to read FLAC metadata block 
header\n");
+return (pb->error < 0 ? pb->error : AVERROR_INVALIDDATA);
+}
 flac_parse_block_header(buf, , , );
 
 if (type != FLAC_METADATA_TYPE_STREAMINFO || size != FLAC_STREAMINFO_SIZE) 
{
-- 
2.30.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".