Re: [FFmpeg-devel] Implemented h264 timing SEI info to ffprobe. Review process?
On Mon, 23 Jan 2017 14:43:36 +0100 Carl Eugen Hoyos wrote: > 2017-01-22 20:31 GMT+01:00 Jordi Cenzano : > > > It woud be great some guidance on that. > > Please split the libavutil change from the h264 change and remove > unrelated changes like additional empty lines. > I suspect you cannot insert something in the middle of AVFrame, > move it to the end. > > Developers may oppose the libavutil change but you will only find > out if you send the patch;-( It's quite likely that least some adjustments will be requested, but all to its time. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Implemented h264 timing SEI info to ffprobe. Review process?
2017-01-22 20:31 GMT+01:00 Jordi Cenzano : > It woud be great some guidance on that. Please split the libavutil change from the h264 change and remove unrelated changes like additional empty lines. I suspect you cannot insert something in the middle of AVFrame, move it to the end. Developers may oppose the libavutil change but you will only find out if you send the patch;-( Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Implemented h264 timing SEI info to ffprobe. Review process?
Thanks! Will do Jordi On Mon, Jan 23, 2017 at 10:36 AM, wm4 wrote: > On Sun, 22 Jan 2017 20:31:36 +0100 > Jordi Cenzano wrote: > > > Hi, I'm and old user of ffmpeg but I'm new in this community. So first of > > all let me congrat you for your work, ffmpeg has been always a great tool > > for me. > > > > I added a new small functionality to ffprobe, now any user can have frame > > SEI timing info available in ffprobe output (useful to read SMPTE time > > code). > > > > Since this is NOT a patch I don't know which is the best way to submit my > > changes for review, for now I created this PR against a FFmpeg forked > repo: > > https://github.com/jordicenzano/FFmpeg/pull/1 > > Send it as patch, either via "git send-email", or as attached text file > produced by "git format-patch". > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Implemented h264 timing SEI info to ffprobe. Review process?
On Sun, 22 Jan 2017 20:31:36 +0100 Jordi Cenzano wrote: > Hi, I'm and old user of ffmpeg but I'm new in this community. So first of > all let me congrat you for your work, ffmpeg has been always a great tool > for me. > > I added a new small functionality to ffprobe, now any user can have frame > SEI timing info available in ffprobe output (useful to read SMPTE time > code). > > Since this is NOT a patch I don't know which is the best way to submit my > changes for review, for now I created this PR against a FFmpeg forked repo: > https://github.com/jordicenzano/FFmpeg/pull/1 Send it as patch, either via "git send-email", or as attached text file produced by "git format-patch". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] Implemented h264 timing SEI info to ffprobe. Review process?
Hi, I'm and old user of ffmpeg but I'm new in this community. So first of all let me congrat you for your work, ffmpeg has been always a great tool for me. I added a new small functionality to ffprobe, now any user can have frame SEI timing info available in ffprobe output (useful to read SMPTE time code). Since this is NOT a patch I don't know which is the best way to submit my changes for review, for now I created this PR against a FFmpeg forked repo: https://github.com/jordicenzano/FFmpeg/pull/1 It woud be great some guidance on that. Jordi Cenzano ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
