Re: [FFmpeg-devel] PATCH] h2645: Allocate a single buffer per packet. Drastically reduces memory usage on pathological streams.

2017-11-04 Thread James Almer 
On 11/4/2017 2:52 PM, Derek Buitenhuis wrote:
> On 11/3/2017 6:23 PM, Kieran Kunhya wrote:
>> This patch fixes very high memory usage on pathological streams.
> 
> [...]
> 
>> -H2645Packet pkt = { 0 };
>> +H2645Packet pkt;
>> +memset(, 0, sizeof(pkt));
> 
> Stray unrelated change.

Yed, it's both unnecessary and will raise a warning about mixed
declaration and code.

> 
> Rest seems reasonable from a cursory glance. I assume it's
> been run with ASAN or whatever + FATE, and valgrind.

I ran it with asan, using one and four threads. No reported failures or
leaks.

> 
> - Derek
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] PATCH] h2645: Allocate a single buffer per packet. Drastically reduces memory usage on pathological streams.

2017-11-04 Thread Derek Buitenhuis 
On 11/3/2017 6:23 PM, Kieran Kunhya wrote:
> This patch fixes very high memory usage on pathological streams.

[...]

> -H2645Packet pkt = { 0 };
> +H2645Packet pkt;
> +memset(, 0, sizeof(pkt));

Stray unrelated change.

Rest seems reasonable from a cursory glance. I assume it's
been run with ASAN or whatever + FATE, and valgrind.

- Derek
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] PATCH] h2645: Allocate a single buffer per packet. Drastically reduces memory usage on pathological streams.

2017-11-03 Thread Carl Eugen Hoyos 
2017-11-03 19:23 GMT+01:00 Kieran Kunhya :
> This patch fixes very high memory usage on pathological streams.

Please mention the ticket number in the commit message.

Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] PATCH] h2645: Allocate a single buffer per packet. Drastically reduces memory usage on pathological streams.

2017-11-03 Thread Kieran Kunhya 
This patch fixes very high memory usage on pathological streams.


0001-h2645-Allocate-a-single-buffer-per-packet.-Drastical.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel