[FFmpeg-devel] Patch for Ticket 4922
Hi all, Bug report from user: https://trac.ffmpeg.org/ticket/4922, and associated patch has been attached. The patch LGTM, except for the commit message, which should be changed to "configure: fix configure when using gcc". This should be backported. Apologies for the breakage. Regards, Ganesh From 1c4d147167ccea142ede0f47bd0cf57121b45620 Mon Sep 17 00:00:00 2001 From: Jean-Yves AvenardDate: Sun, 11 Oct 2015 21:58:24 +1100 Subject: [PATCH] Fix configure when using gcc. --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 91f366e..3f44157 100755 --- a/configure +++ b/configure @@ -3567,7 +3567,8 @@ probe_cc(){ gcc_ext_ver=$(expr "$gcc_version" : ".*$gcc_pkg_ver $gcc_basever \\(.*\\)") _ident=$(cleanws "gcc $gcc_basever $gcc_pkg_ver $gcc_ext_ver") case $gcc_basever in -2*) _depflags='-MMD -MF $(@:.o=.d) -MT $@' ;; +2*) ;; +*) _depflags='-MMD -MF $(@:.o=.d) -MT $@' ;; esac if [ "$first" = true ]; then case $gcc_basever in -- 2.1.4 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Patch for Ticket 4922
On Sun, Oct 11, 2015 at 9:26 AM, Ganesh Ajjanagaddewrote: > Hi all, > > Bug report from user: https://trac.ffmpeg.org/ticket/4922, and > associated patch has been attached. The patch LGTM, except for the > commit message, which should be changed to "configure: fix configure > when using gcc". > > This should be backported. Apologies for the breakage. Sent a patch with cleaned up commit message, please let me know if attributing the way I did via a "From/Signed-Off" is incorrect. > > Regards, > Ganesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Patch for Ticket 4922
On Sun, Oct 11, 2015 at 11:22 AM, Ganesh Ajjanagaddewrote: > On Sun, Oct 11, 2015 at 9:26 AM, Ganesh Ajjanagadde wrote: >> Hi all, >> >> Bug report from user: https://trac.ffmpeg.org/ticket/4922, and >> associated patch has been attached. The patch LGTM, except for the >> commit message, which should be changed to "configure: fix configure >> when using gcc". >> >> This should be backported. Apologies for the breakage. > > Sent a patch with cleaned up commit message, please let me know if > attributing the way I did via a "From/Signed-Off" is incorrect. Also, would like to add that feeling a greater sense of personal responsibility for this breakage, I would like to exercise my commit access for this patch. Anyone against this? > >> >> Regards, >> Ganesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Patch for Ticket 4922
On Sun, Oct 11, 2015 at 12:12 PM, Ganesh Ajjanagaddewrote: > On Sun, Oct 11, 2015 at 11:22 AM, Ganesh Ajjanagadde wrote: >> On Sun, Oct 11, 2015 at 9:26 AM, Ganesh Ajjanagadde wrote: >>> Hi all, >>> >>> Bug report from user: https://trac.ffmpeg.org/ticket/4922, and >>> associated patch has been attached. The patch LGTM, except for the >>> commit message, which should be changed to "configure: fix configure >>> when using gcc". >>> >>> This should be backported. Apologies for the breakage. >> >> Sent a patch with cleaned up commit message, please let me know if >> attributing the way I did via a "From/Signed-Off" is incorrect. > > Also, would like to add that feeling a greater sense of personal > responsibility for this breakage, I would like to exercise my commit > access for this patch. Anyone against this? patch applied to master, so the question is irrelevant now. > >> >>> >>> Regards, >>> Ganesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel