Re: [FFmpeg-devel] Pull requests

[Bjorn Roche]

On Tue, Feb 27, 2018 at 11:55 AM, James Almer  wrote:

> On 2/27/2018 1:28 PM, Bjorn Roche wrote:
> > On Tue, Feb 27, 2018 at 10:34 AM, wm4  wrote:
> >
> > According to Carl Eugen Hoyos: "This is Clément's code, he has to review
> > your patch."
>
> He's on vacations, so that'd explain why he hasn't looked at it.
>

Thanks James. If no one else can look at it, I'll just resubmit when he
comes back.

bjorn

-- 


Bjorn Roche

Sr. Video Pipeline Engineer

bj...@giphy.com
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[James Almer]

On 2/27/2018 1:28 PM, Bjorn Roche wrote:
> On Tue, Feb 27, 2018 at 10:34 AM, wm4  wrote:
> 
>> On Tue, 27 Feb 2018 10:25:17 -0500
>> Bjorn Roche  wrote:
>>
>>> On Tue, Feb 27, 2018 at 5:47 AM, wm4  wrote:
>>>
 On Mon, 26 Feb 2018 17:15:26 -0500
 Bjorn Roche  wrote:

> Okay, thanks Nicolas.
>
> I already submitted a patch to the mailing list a few months ago, I
>> was
> just hoping for an easier way to keep it fresh since it's gone stale,
 and I
> had some more fixes for it.

 Just ping it a few times or resend it. It's pretty easy for patches to
 get lost/ignored, but we don't use the github mirror's PR system at
 all. Github merely doesn't let us disable it.
>>>
>>>
>>> There was a fair bit of very helpful discussion, so it was not ignored,
>> but
>>> the relevant maintainer on that code never commented. I emailed him
>>> privately and got nothing, nor have I seen him on the mailing list. I was
>>> just hoping you guys now accepted PRs so it would be easier for us to
>> keep
>>> it fresh.
>>
>> The MAINTAINERS file is usually stale and outdated, so just ask whether
>> someone else can push it.
> 
> Jan 16
> 
> According to Carl Eugen Hoyos: "This is Clément's code, he has to review
> your patch."

He's on vacations, so that'd explain why he hasn't looked at it.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[Paul B Mahol]

On 2/27/18, Bjorn Roche  wrote:
> On Tue, Feb 27, 2018 at 10:34 AM, Paul B Mahol  wrote:
>
>> On 2/27/18, Bjorn Roche  wrote:
>> > On Tue, Feb 27, 2018 at 5:47 AM, wm4  wrote:
>> >
>> >> On Mon, 26 Feb 2018 17:15:26 -0500
>> >> Bjorn Roche  wrote:
>> >>
>> >> > Okay, thanks Nicolas.
>> >> >
>> >> > I already submitted a patch to the mailing list a few months ago, I
>> was
>> >> > just hoping for an easier way to keep it fresh since it's gone stale,
>> >> and I
>> >> > had some more fixes for it.
>> >>
>> >> Just ping it a few times or resend it. It's pretty easy for patches to
>> >> get lost/ignored, but we don't use the github mirror's PR system at
>> >> all. Github merely doesn't let us disable it.
>> >
>> >
>> > There was a fair bit of very helpful discussion, so it was not ignored,
>> but
>> > the relevant maintainer on that code never commented. I emailed him
>> > privately and got nothing, nor have I seen him on the mailing list. I
>> > was
>> > just hoping you guys now accepted PRs so it would be easier for us to
>> keep
>> > it fresh.
>>
>> Please, keep pinging relevant patch. Current maintainer is very busy.
>>
>
> To be honest, I don't see the point if the one person who can approve is
> not going to look at it. It takes a fair bit of time to freshen and prepare
> these patches for email.

Ping does not mean to freshen patch.

>
> --
>
>
> Bjorn Roche
>
> Sr. Video Pipeline Engineer
>
> bj...@giphy.com
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[Bjorn Roche]

On Tue, Feb 27, 2018 at 10:34 AM, Paul B Mahol  wrote:

> On 2/27/18, Bjorn Roche  wrote:
> > On Tue, Feb 27, 2018 at 5:47 AM, wm4  wrote:
> >
> >> On Mon, 26 Feb 2018 17:15:26 -0500
> >> Bjorn Roche  wrote:
> >>
> >> > Okay, thanks Nicolas.
> >> >
> >> > I already submitted a patch to the mailing list a few months ago, I
> was
> >> > just hoping for an easier way to keep it fresh since it's gone stale,
> >> and I
> >> > had some more fixes for it.
> >>
> >> Just ping it a few times or resend it. It's pretty easy for patches to
> >> get lost/ignored, but we don't use the github mirror's PR system at
> >> all. Github merely doesn't let us disable it.
> >
> >
> > There was a fair bit of very helpful discussion, so it was not ignored,
> but
> > the relevant maintainer on that code never commented. I emailed him
> > privately and got nothing, nor have I seen him on the mailing list. I was
> > just hoping you guys now accepted PRs so it would be easier for us to
> keep
> > it fresh.
>
> Please, keep pinging relevant patch. Current maintainer is very busy.
>

To be honest, I don't see the point if the one person who can approve is
not going to look at it. It takes a fair bit of time to freshen and prepare
these patches for email.

-- 


Bjorn Roche

Sr. Video Pipeline Engineer

bj...@giphy.com
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[Nicolas George]

Bjorn Roche (2018-02-27):
> According to Carl Eugen Hoyos: "This is Clément's code, he has to review
> your patch."

Then reply to Carl Eugen's mail to say "Clément does not seem to care
these days", to re-start the discussion.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[Bjorn Roche]

On Tue, Feb 27, 2018 at 10:34 AM, wm4  wrote:

> On Tue, 27 Feb 2018 10:25:17 -0500
> Bjorn Roche  wrote:
>
> > On Tue, Feb 27, 2018 at 5:47 AM, wm4  wrote:
> >
> > > On Mon, 26 Feb 2018 17:15:26 -0500
> > > Bjorn Roche  wrote:
> > >
> > > > Okay, thanks Nicolas.
> > > >
> > > > I already submitted a patch to the mailing list a few months ago, I
> was
> > > > just hoping for an easier way to keep it fresh since it's gone stale,
> > > and I
> > > > had some more fixes for it.
> > >
> > > Just ping it a few times or resend it. It's pretty easy for patches to
> > > get lost/ignored, but we don't use the github mirror's PR system at
> > > all. Github merely doesn't let us disable it.
> >
> >
> > There was a fair bit of very helpful discussion, so it was not ignored,
> but
> > the relevant maintainer on that code never commented. I emailed him
> > privately and got nothing, nor have I seen him on the mailing list. I was
> > just hoping you guys now accepted PRs so it would be easier for us to
> keep
> > it fresh.
>
> The MAINTAINERS file is usually stale and outdated, so just ask whether
> someone else can push it.

Jan 16

According to Carl Eugen Hoyos: "This is Clément's code, he has to review
your patch."

-- 


Bjorn Roche

Sr. Video Pipeline Engineer

bj...@giphy.com
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[Paul B Mahol]

On 2/27/18, Bjorn Roche  wrote:
> On Tue, Feb 27, 2018 at 5:47 AM, wm4  wrote:
>
>> On Mon, 26 Feb 2018 17:15:26 -0500
>> Bjorn Roche  wrote:
>>
>> > Okay, thanks Nicolas.
>> >
>> > I already submitted a patch to the mailing list a few months ago, I was
>> > just hoping for an easier way to keep it fresh since it's gone stale,
>> and I
>> > had some more fixes for it.
>>
>> Just ping it a few times or resend it. It's pretty easy for patches to
>> get lost/ignored, but we don't use the github mirror's PR system at
>> all. Github merely doesn't let us disable it.
>
>
> There was a fair bit of very helpful discussion, so it was not ignored, but
> the relevant maintainer on that code never commented. I emailed him
> privately and got nothing, nor have I seen him on the mailing list. I was
> just hoping you guys now accepted PRs so it would be easier for us to keep
> it fresh.

Please, keep pinging relevant patch. Current maintainer is very busy.

>
> bjorn
>
> --
>
>
> Bjorn Roche
>
> Sr. Video Pipeline Engineer
>
> bj...@giphy.com
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[wm4]

On Tue, 27 Feb 2018 10:25:17 -0500
Bjorn Roche  wrote:

> On Tue, Feb 27, 2018 at 5:47 AM, wm4  wrote:
> 
> > On Mon, 26 Feb 2018 17:15:26 -0500
> > Bjorn Roche  wrote:
> >  
> > > Okay, thanks Nicolas.
> > >
> > > I already submitted a patch to the mailing list a few months ago, I was
> > > just hoping for an easier way to keep it fresh since it's gone stale,  
> > and I  
> > > had some more fixes for it.  
> >
> > Just ping it a few times or resend it. It's pretty easy for patches to
> > get lost/ignored, but we don't use the github mirror's PR system at
> > all. Github merely doesn't let us disable it.  
> 
> 
> There was a fair bit of very helpful discussion, so it was not ignored, but
> the relevant maintainer on that code never commented. I emailed him
> privately and got nothing, nor have I seen him on the mailing list. I was
> just hoping you guys now accepted PRs so it would be easier for us to keep
> it fresh.

The MAINTAINERS file is usually stale and outdated, so just ask whether
someone else can push it.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[Bjorn Roche]

On Tue, Feb 27, 2018 at 5:47 AM, wm4  wrote:

> On Mon, 26 Feb 2018 17:15:26 -0500
> Bjorn Roche  wrote:
>
> > Okay, thanks Nicolas.
> >
> > I already submitted a patch to the mailing list a few months ago, I was
> > just hoping for an easier way to keep it fresh since it's gone stale,
> and I
> > had some more fixes for it.
>
> Just ping it a few times or resend it. It's pretty easy for patches to
> get lost/ignored, but we don't use the github mirror's PR system at
> all. Github merely doesn't let us disable it.


There was a fair bit of very helpful discussion, so it was not ignored, but
the relevant maintainer on that code never commented. I emailed him
privately and got nothing, nor have I seen him on the mailing list. I was
just hoping you guys now accepted PRs so it would be easier for us to keep
it fresh.

bjorn

-- 


Bjorn Roche

Sr. Video Pipeline Engineer

bj...@giphy.com
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[wm4]

On Mon, 26 Feb 2018 17:15:26 -0500
Bjorn Roche  wrote:

> Okay, thanks Nicolas.
> 
> I already submitted a patch to the mailing list a few months ago, I was
> just hoping for an easier way to keep it fresh since it's gone stale, and I
> had some more fixes for it.

Just ping it a few times or resend it. It's pretty easy for patches to
get lost/ignored, but we don't use the github mirror's PR system at
all. Github merely doesn't let us disable it.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[Lou Logan]

On Mon, Feb 26, 2018, at 12:39 PM, Bjorn Roche wrote:
>
> I have a patch I'd like to submit -- can I submit a PR on GitHub, or no?

The main problem with github and such is that all development discussions and 
reviews occur at one location: the ffmpeg-devel mailing list. PRs are therefore 
out of our workflow. The other problem is that the PRs are often nonsense or 
accidental so the signal-to-noise ratio isn't great. So PRs are forgotten or 
ignored. Admittedly it's not an ideal situation, but we are not the only ones 
who don't accept PRs (Linux kernel for example).

However, we do accept attached patches made by "git format-patch", so that 
could present a workaround. If your usage of github is non-negotiable I believe 
you can do your github stuff, view the commit on the github site, append the 
".patch" extension to the end of the URL to get the raw patch, and attach the 
patch to a message to this mailing list. I'm not a github user, so this 
suggestion may be incorrect, but I believe that should work as long as your 
mail client doesn't mangle the patch.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[Bjorn Roche]

Okay, thanks Nicolas.

I already submitted a patch to the mailing list a few months ago, I was
just hoping for an easier way to keep it fresh since it's gone stale, and I
had some more fixes for it.

bjorn

On Mon, Feb 26, 2018 at 4:49 PM, Nicolas George  wrote:

> Bjorn Roche (2018-02-26):
> > - Committing changes to a git clone, for example on github.com or
> > gitorious.org. And asking us to merge these changes.
>
> Note that it does not say how you are supposed to "ask". You are
> supposed to ask on the mailing-list.
>
> > I have a patch I'd like to submit -- can I submit a PR on GitHub, or no?
>
> No. Reviews happen on the mailing list.
>
> Regards,
>
> --
>   Nicolas George
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>


-- 


Bjorn Roche

Sr. Video Pipeline Engineer

bj...@giphy.com
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[James Almer]

On 2/26/2018 6:39 PM, Bjorn Roche wrote:
> Hey there,
> 
> Your docs (https://ffmpeg.org/developer.html) say:
> 
> There are 3 ways by which code gets into FFmpeg.
> 
> - Submitting patches to the main developer mailing list. See Submitting
> patches for details.
> - Directly committing changes to the main tree.
> - Committing changes to a git clone, for example on github.com or
> gitorious.org. And asking us to merge these changes.
> 
> The third method appears to be new (Hooray!) but I noticed that the GitHub
> repo here
> 
> https://github.com/FFmpeg/FFmpeg/pulls
> 
> still has a single PR that says
> 
> "WARNING: PULL REQUESTS ON THIS REPOSITORY ARE IGNORED"
> 
> I have a patch I'd like to submit -- can I submit a PR on GitHub, or no?

No. Reviewing takes place on this ml, so you'll in any case always have
to send your patches here.

You can push said patch to any public repository after it has been
reviewed and then ask us here to merge them, but more often than not
whoever reviews patches just applies them as sent here, especially when
it's only one.

> 
> Thanks,
> 
> bjorn
> 

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Pull requests

[Nicolas George]

Bjorn Roche (2018-02-26):
> - Committing changes to a git clone, for example on github.com or
> gitorious.org. And asking us to merge these changes.

Note that it does not say how you are supposed to "ask". You are
supposed to ask on the mailing-list.

> I have a patch I'd like to submit -- can I submit a PR on GitHub, or no?

No. Reviews happen on the mailing list.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Pull requests

[Bjorn Roche]

Hey there,

Your docs (https://ffmpeg.org/developer.html) say:

There are 3 ways by which code gets into FFmpeg.

- Submitting patches to the main developer mailing list. See Submitting
patches for details.
- Directly committing changes to the main tree.
- Committing changes to a git clone, for example on github.com or
gitorious.org. And asking us to merge these changes.

The third method appears to be new (Hooray!) but I noticed that the GitHub
repo here

https://github.com/FFmpeg/FFmpeg/pulls

still has a single PR that says

"WARNING: PULL REQUESTS ON THIS REPOSITORY ARE IGNORED"

I have a patch I'd like to submit -- can I submit a PR on GitHub, or no?

Thanks,

bjorn

-- 


Bjorn Roche

Sr. Video Pipeline Engineer

bj...@giphy.com
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel