Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-15 Thread Michael Niedermayer 
On Tue, Mar 15, 2016 at 10:57:02PM +, Eran Kornblau wrote:
> > > > 
> > > > check tests/fate/seek.mak
> > > > also you can pass parameters to seek-test see fate-seek-cache-pipe
> > > > i dont know if there is anything else special needed for this
> > > >
> > > Thanks Michael, I looked at this some more, and there's one thing that 
> > > I'm still
> > > missing - where do I get the sample encrypted file from ?
> > > 
> > > As I understand, I can either:
> > > 1. Generate one on the machine running the tests - in this case, where do 
> > > I write 
> > > the ffmpeg command line for doing that ?
> > 
> > see for example: fate-filter-hls
> > 
> > 
> > > 2. Upload a sample, that will later be pulled by 'make fate-rsync' - in 
> > > this option, 
> > > what is the process for submitting such samples ?
> > 
> > you can just add a url to the file, i can add it to the fate samples
> > but in that case the file should be small as thousands of samples
> > add up ...
> >
> 
> Patch attached, I went with option #1 (generate the test files with ffmpeg)
> 
> Thanks
> 
> Eran

>  fate/seek.mak|   24 +++
>  ref/seek/enc-mp4-aac |   53 
> +++
>  ref/seek/enc-mp4-avc |   53 
> +++
>  3 files changed, 130 insertions(+)
> d90a14503a4835a36c78f32f3efa78916f94a296  
> 0001-add-seek-tests-for-encrypted-mp4.patch
> From 5dab98182ac6e64d62cd873b5cbc0dd50a7007ca Mon Sep 17 00:00:00 2001
> From: erankor 
> Date: Wed, 16 Mar 2016 00:45:07 +0200
> Subject: [PATCH] add seek tests for encrypted mp4
> 
> one for aac (sample encryption), one for avc (subsample encryption)
> ---
>  tests/fate/seek.mak| 24 +
>  tests/ref/seek/enc-mp4-aac | 53 
> ++
>  tests/ref/seek/enc-mp4-avc | 53 
> ++
>  3 files changed, 130 insertions(+)
>  create mode 100644 tests/ref/seek/enc-mp4-aac
>  create mode 100644 tests/ref/seek/enc-mp4-avc

the aac test fails on x86-32 (passes on 64bit)
does it use floating point aac ? if so that wont be binary identical
between platforms

also
> +tests/data/enc-avc.mp4: TAG = GEN
> +tests/data/enc-avc.mp4: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data
> +   $(M)$(TARGET_EXEC) $(TARGET_PATH)/$< \
> +-f rawvideo -pix_fmt rgb24 -t 10 -r 30 -s 320x240 -i /dev/zero -f 
> mov -flags +bitexact -codec:v libx264 \

libx264 is not guranteed to be available and if available 2 versions
of it could generate different output


make: *** [tests/data/enc-avc.mp4] Error 1
make: *** Waiting for unfinished jobs
 libavformat/seek-test ffmpeg/tests/data/enc-aac.mp4 -decryption_key 
12345678901234567890123456789012
--- ffmpeg/tests/ref/seek/enc-mp4-aac  2016-03-16 02:20:25.725653079 +0100
+++ tests/data/fate/seek-enc-mp4-aac2016-03-16 02:41:07.557679241 +0100
@@ -2,52 +2,52 @@
 ret: 0 st:-1 flags:0  ts:-1.00
 ret: 0 st: 0 flags:1 dts:-0.023220 pts:-0.023220 pos: 36 size:   
286
 ret: 0 st:-1 flags:1  ts: 1.894167
-ret: 0 st: 0 flags:1 dts: 1.880816 pts: 1.880816 pos:  16769 size:   
224
+ret: 0 st: 0 flags:1 dts: 1.880816 pts: 1.880816 pos:  16742 size:   
223
 ret: 0 st: 0 flags:0  ts: 0.788345
-ret: 0 st: 0 flags:1 dts: 0.789478 pts: 0.789478 pos:   7196 size:   
206
+ret: 0 st: 0 flags:1 dts: 0.789478 pts: 0.789478 pos:   7117 size:   
204
 ret: 0 st: 0 flags:1  ts:-0.317506
 ret: 0 st: 0 flags:1 dts:-0.023220 pts:-0.023220 pos: 36 size:   
286
 ret: 0 st:-1 flags:0  ts: 2.576668
-ret: 0 st: 0 flags:1 dts: 2.577415 pts: 2.577415 pos:  22827 size:   
203
+ret: 0 st: 0 flags:1 dts: 2.577415 pts: 2.577415 pos:  22740 size:   
202
 ret: 0 st:-1 flags:1  ts: 1.470835
-ret: 0 st: 0 flags:1 dts: 1.462857 pts: 1.462857 pos:  13234 size:   
224
+ret: 0 st: 0 flags:1 dts: 1.462857 pts: 1.462857 pos:  13195 size:   
224
 ret: 0 st: 0 flags:0  ts: 0.365011
-ret: 0 st: 0 flags:1 dts: 0.371519 pts: 0.371519 pos:   3489 size:   
246
+ret: 0 st: 0 flags:1 dts: 0.371519 pts: 0.371519 pos:   3499 size:   
205
 ret: 0 st: 0 flags:1  ts:-0.740839
 ret: 0 st: 0 flags:1 dts:-0.023220 pts:-0.023220 pos: 36 size:   
286
 ret: 0 st:-1 flags:0  ts: 2.153336
-ret: 0 st: 0 flags:1 dts: 2.159456 pts: 2.159456 pos:  19192 size:   
194
+ret: 0 st: 0 flags:1 dts: 2.159456 pts: 2.159456 pos:  19151 size:   
198
 ret: 0 st:-1 flags:1  ts: 1.047503
-ret: 0 st: 0 flags:1 dts: 1.044898 pts: 1.044898 pos:   9465 size:   
212
+ret: 0 st: 0 flags:1 dts: 1.044898 pts: 1.044898 pos:   9446 size:   
204
 ret: 0 st: 0 flags:0  ts:-0.058322
 ret: 0 st: 0 flags:1 dts:-0.023220 pts:-0.023220 pos: 36 size:   
286
 ret: 0 st: 0 flags:1  ts: 2.835828
-ret:

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-15 Thread Eran Kornblau 
> > > 
> > > check tests/fate/seek.mak
> > > also you can pass parameters to seek-test see fate-seek-cache-pipe
> > > i dont know if there is anything else special needed for this
> > >
> > Thanks Michael, I looked at this some more, and there's one thing that I'm 
> > still
> > missing - where do I get the sample encrypted file from ?
> > 
> > As I understand, I can either:
> > 1. Generate one on the machine running the tests - in this case, where do I 
> > write 
> > the ffmpeg command line for doing that ?
> 
> see for example: fate-filter-hls
> 
> 
> > 2. Upload a sample, that will later be pulled by 'make fate-rsync' - in 
> > this option, 
> > what is the process for submitting such samples ?
> 
> you can just add a url to the file, i can add it to the fate samples
> but in that case the file should be small as thousands of samples
> add up ...
>

Patch attached, I went with option #1 (generate the test files with ffmpeg)

Thanks

Eran


0001-add-seek-tests-for-encrypted-mp4.patch
Description: 0001-add-seek-tests-for-encrypted-mp4.patch
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-08 Thread Michael Niedermayer 
On Tue, Mar 08, 2016 at 09:13:30PM +, Eran Kornblau wrote:
> > 
> > check tests/fate/seek.mak
> > also you can pass parameters to seek-test see fate-seek-cache-pipe
> > i dont know if there is anything else special needed for this
> >
> Thanks Michael, I looked at this some more, and there's one thing that I'm 
> still
> missing - where do I get the sample encrypted file from ?
> 
> As I understand, I can either:
> 1. Generate one on the machine running the tests - in this case, where do I 
> write 
> the ffmpeg command line for doing that ?

see for example: fate-filter-hls


> 2. Upload a sample, that will later be pulled by 'make fate-rsync' - in this 
> option, 
> what is the process for submitting such samples ?

you can just add a url to the file, i can add it to the fate samples
but in that case the file should be small as thousands of samples
add up ...

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-08 Thread Eran Kornblau 
> 
> check tests/fate/seek.mak
> also you can pass parameters to seek-test see fate-seek-cache-pipe
> i dont know if there is anything else special needed for this
>
Thanks Michael, I looked at this some more, and there's one thing that I'm still
missing - where do I get the sample encrypted file from ?

As I understand, I can either:
1. Generate one on the machine running the tests - in this case, where do I 
write 
the ffmpeg command line for doing that ?
2. Upload a sample, that will later be pulled by 'make fate-rsync' - in this 
option, 
what is the process for submitting such samples ?

Thanks

Eran

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-06 Thread Michael Niedermayer 
On Sun, Mar 06, 2016 at 08:35:41PM +, Eran Kornblau wrote:
> > 
> > can you create a fate test for this ?
> > maybe seek-test could be simply used?
> >
> Sure, can you point me to some existing test that is similar enough for me to 
> use as a reference ? 
> I read the Wiki page about adding a test, but not quite sure how to apply it 
> here

check tests/fate/seek.mak
also you can pass parameters to seek-test see fate-seek-cache-pipe
i dont know if there is anything else special needed for this


[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-06 Thread Eran Kornblau 
> 
> can you create a fate test for this ?
> maybe seek-test could be simply used?
>
Sure, can you point me to some existing test that is similar enough for me to 
use as a reference ? 
I read the Wiki page about adding a test, but not quite sure how to apply it 
here

> thanks
> 
> [...]
> -- 
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>

Thanks

Eran
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-06 Thread Michael Niedermayer 
On Sun, Mar 06, 2016 at 12:07:37PM +, Eran Kornblau wrote:
> Ping
> 
> Thanks
> 
> Eran

>  isom.h |3 ++
>  mov.c  |   94 
> +
>  2 files changed, 97 insertions(+)
> 395b2cf334ec76f21376f52709b5a9caeeb39d9d  
> 0001-mov-support-seek-in-encrypted-mp4.patch
> From 769c0ad4369051157e7151c1b6d8d382d8bca9bb Mon Sep 17 00:00:00 2001
> From: erankor 
> Date: Mon, 22 Feb 2016 16:41:06 +0200
> Subject: [PATCH] mov - support seek in encrypted mp4

applied

can you create a fate test for this ?
maybe seek-test could be simply used?

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-06 Thread Eran Kornblau 
Ping

Thanks

Eran


0001-mov-support-seek-in-encrypted-mp4.patch
Description: 0001-mov-support-seek-in-encrypted-mp4.patch
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-02-28 Thread Eran Kornblau 
Bumping... same patch attached

Thanks

Eran


0001-mov-support-seek-in-encrypted-mp4.patch
Description: 0001-mov-support-seek-in-encrypted-mp4.patch
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Support seek in encrypted MP4

2016-02-22 Thread Eran Kornblau 
Hi all,

Found out today that my patch for supporting encrypted MP4's does not support 
seek...
Patch attached

Thanks,

Eran


0001-mov-support-seek-in-encrypted-mp4.patch
Description: 0001-mov-support-seek-in-encrypted-mp4.patch
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel