Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?
Am Sonntag, 1. März 2015 schrieb Derek Buitenhuis : > On 3/1/2015 12:26 PM, Robert Krüger wrote: > > Am I reading the committed patch incorrectly or is colr still not written > > by default? I thought the argument against replacing the flag (Derek's > > first patch) was withdrawn because there has not been a release that > > contained the original flag. > > The committed patch is unrelated to this. It was to make it actually > create valid MP4 files in the first place. > > Ok, thanks for the clarification. Are you planning on submitting another one that changes the default like your first patch did? -- Robert Krüger Managing Partner Lesspain GmbH & Co. KG www.lesspain-software.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?
On 3/1/2015 12:26 PM, Robert Krüger wrote: > Am I reading the committed patch incorrectly or is colr still not written > by default? I thought the argument against replacing the flag (Derek's > first patch) was withdrawn because there has not been a release that > contained the original flag. The committed patch is unrelated to this. It was to make it actually create valid MP4 files in the first place. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?
On Tue, Feb 24, 2015 at 11:55 AM, Michael Niedermayer wrote: > On Tue, Feb 24, 2015 at 08:00:07AM +, tim nicholson wrote: > > On 21/02/15 01:34, Dave Rice wrote: > > > Hi Robert, Kevin, > > > > > >> On Feb 20, 2015, at 9:56 AM, Robert Krüger > wrote: > > >> > > >> Am Freitag, 20. Februar 2015 schrieb Kevin Wheatley : > > >> > > >>> On Fri, Feb 20, 2015 at 1:30 PM, Robert Krüger > >>> > wrote: > > if I read the code correctly, the colr atom is only written in the > mov > > muxer if the flag write_colr is specified. Was that behaviour > chosen to > > have better backward compatibility or is there another reason not to > > >>> write > > this standard atom by default? > > >>> > > >>> I chose that way to preserve the older behaviour, as it can change > how > > >>> files will be interpreted. > > >>> > > >>> I assumed that but isn't the change then a change for the better > (then > > >> maybe requiring a version bump and an entry in the release notes)? > After > > >> all Apple muxers write it by default as well and not trusting the > input > > >> metadata seems to me like something that should be opt-out rather than > > >> opt-in but that's just my 2c. > > > > > > That's also my two cents and I also wondered why users have to opt-in > to a correctly written file. The QuickTime spec says that colr is required > with some streams (such as raw uyvy422 and v210), see: > https://developer.apple.com/library/mac/technotes/tn2162/_index.html#//apple_ref/doc/uid/DTS40013070-CH1-TNTAG9 > . > > > > > > I'd propose that colr be written by default. The interpretation may be > different but, since a file with a colr atom is more self-descriptive, the > interpretation is more likely to be correct. > > > > +1 > > if someone posts a patch, ill apply it > Am I reading the committed patch incorrectly or is colr still not written by default? I thought the argument against replacing the flag (Derek's first patch) was withdrawn because there has not been a release that contained the original flag. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?
On Tue, Feb 24, 2015 at 08:00:07AM +, tim nicholson wrote: > On 21/02/15 01:34, Dave Rice wrote: > > Hi Robert, Kevin, > > > >> On Feb 20, 2015, at 9:56 AM, Robert Krüger wrote: > >> > >> Am Freitag, 20. Februar 2015 schrieb Kevin Wheatley : > >> > >>> On Fri, Feb 20, 2015 at 1:30 PM, Robert Krüger >>> > wrote: > if I read the code correctly, the colr atom is only written in the mov > muxer if the flag write_colr is specified. Was that behaviour chosen to > have better backward compatibility or is there another reason not to > >>> write > this standard atom by default? > >>> > >>> I chose that way to preserve the older behaviour, as it can change how > >>> files will be interpreted. > >>> > >>> I assumed that but isn't the change then a change for the better (then > >> maybe requiring a version bump and an entry in the release notes)? After > >> all Apple muxers write it by default as well and not trusting the input > >> metadata seems to me like something that should be opt-out rather than > >> opt-in but that's just my 2c. > > > > That's also my two cents and I also wondered why users have to opt-in to a > > correctly written file. The QuickTime spec says that colr is required with > > some streams (such as raw uyvy422 and v210), see: > > https://developer.apple.com/library/mac/technotes/tn2162/_index.html#//apple_ref/doc/uid/DTS40013070-CH1-TNTAG9. > > > > I'd propose that colr be written by default. The interpretation may be > > different but, since a file with a colr atom is more self-descriptive, the > > interpretation is more likely to be correct. > > +1 if someone posts a patch, ill apply it [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?
On 21/02/15 01:34, Dave Rice wrote: > Hi Robert, Kevin, > >> On Feb 20, 2015, at 9:56 AM, Robert Krüger wrote: >> >> Am Freitag, 20. Februar 2015 schrieb Kevin Wheatley : >> >>> On Fri, Feb 20, 2015 at 1:30 PM, Robert Krüger >> > wrote: if I read the code correctly, the colr atom is only written in the mov muxer if the flag write_colr is specified. Was that behaviour chosen to have better backward compatibility or is there another reason not to >>> write this standard atom by default? >>> >>> I chose that way to preserve the older behaviour, as it can change how >>> files will be interpreted. >>> >>> I assumed that but isn't the change then a change for the better (then >> maybe requiring a version bump and an entry in the release notes)? After >> all Apple muxers write it by default as well and not trusting the input >> metadata seems to me like something that should be opt-out rather than >> opt-in but that's just my 2c. > > That's also my two cents and I also wondered why users have to opt-in to a > correctly written file. The QuickTime spec says that colr is required with > some streams (such as raw uyvy422 and v210), see: > https://developer.apple.com/library/mac/technotes/tn2162/_index.html#//apple_ref/doc/uid/DTS40013070-CH1-TNTAG9. > > I'd propose that colr be written by default. The interpretation may be > different but, since a file with a colr atom is more self-descriptive, the > interpretation is more likely to be correct. +1 > Dave Rice > >> [...] -- Tim. Key Fingerprint 38CF DB09 3ED0 F607 8B67 6CED 0C0B FC44 8B0B FC83 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?
Hi Robert, Kevin, > On Feb 20, 2015, at 9:56 AM, Robert Krüger wrote: > > Am Freitag, 20. Februar 2015 schrieb Kevin Wheatley : > >> On Fri, Feb 20, 2015 at 1:30 PM, Robert Krüger > > wrote: >>> if I read the code correctly, the colr atom is only written in the mov >>> muxer if the flag write_colr is specified. Was that behaviour chosen to >>> have better backward compatibility or is there another reason not to >> write >>> this standard atom by default? >> >> I chose that way to preserve the older behaviour, as it can change how >> files will be interpreted. >> >> I assumed that but isn't the change then a change for the better (then > maybe requiring a version bump and an entry in the release notes)? After > all Apple muxers write it by default as well and not trusting the input > metadata seems to me like something that should be opt-out rather than > opt-in but that's just my 2c. That's also my two cents and I also wondered why users have to opt-in to a correctly written file. The QuickTime spec says that colr is required with some streams (such as raw uyvy422 and v210), see: https://developer.apple.com/library/mac/technotes/tn2162/_index.html#//apple_ref/doc/uid/DTS40013070-CH1-TNTAG9. I'd propose that colr be written by default. The interpretation may be different but, since a file with a colr atom is more self-descriptive, the interpretation is more likely to be correct. Dave Rice > Just as another data point, I think ffmbc writes it by default. If it helps, > I can go through a few samples created by well-known tools (e.g. Adobe > Media Encoder) and post, if they write it by default. > > Best regards, > > Robert > > > Kevin >> ___ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > -- > Robert Krüger > Managing Partner > Lesspain GmbH & Co. KG > > www.lesspain-software.com > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?
Am Freitag, 20. Februar 2015 schrieb Kevin Wheatley : > On Fri, Feb 20, 2015 at 1:30 PM, Robert Krüger > wrote: > > if I read the code correctly, the colr atom is only written in the mov > > muxer if the flag write_colr is specified. Was that behaviour chosen to > > have better backward compatibility or is there another reason not to > write > > this standard atom by default? > > I chose that way to preserve the older behaviour, as it can change how > files will be interpreted. > > I assumed that but isn't the change then a change for the better (then maybe requiring a version bump and an entry in the release notes)? After all Apple muxers write it by default as well and not trusting the input metadata seems to me like something that should be opt-out rather than opt-in but that's just my 2c. Just as another data point, I think ffmbc writes it by default. If it helps, I can go through a few samples created by well-known tools (e.g. Adobe Media Encoder) and post, if they write it by default. Best regards, Robert Kevin > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- Robert Krüger Managing Partner Lesspain GmbH & Co. KG www.lesspain-software.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?
On Fri, Feb 20, 2015 at 1:30 PM, Robert Krüger wrote: > if I read the code correctly, the colr atom is only written in the mov > muxer if the flag write_colr is specified. Was that behaviour chosen to > have better backward compatibility or is there another reason not to write > this standard atom by default? I chose that way to preserve the older behaviour, as it can change how files will be interpreted. Kevin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?
Hi, if I read the code correctly, the colr atom is only written in the mov muxer if the flag write_colr is specified. Was that behaviour chosen to have better backward compatibility or is there another reason not to write this standard atom by default? Thanks and best regards, Robert ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
