[FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Jon bae 
Hello everybody,
on the Zeranoe forum we find out that there is two bugs in the
decklink_common.cpp file. I build I patch and want to send them now to you.

I hope is all right, I never did before a git format-patch...

Regards!
Jonathan


fix-device_list-and-COM-initialization-failed_in decklink_common.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Carl Eugen Hoyos 
Jon bae jonbae77 at gmail.com writes:

 I hope is all right, I never did before a 
 git format-patch...

You used git format-patch perfectly, thank you.

Your patch introduces tabs, they cannot be committed 
to FFmpeg. You can find tabs with tools/patcheck, 
a script that is part of the source.

Please do not replace av_log() with fprintf().
Please do not move opening braces, just leave them 
where they are now.
Please keep the indentation at four spaces.

Assuming that the free fix is unrelated to the 
remaining patch, please make it separate.

(I don't know where FAILED() is defined and 
therefore cannot comment on the actual patch and 
if it can be simplified.)

Thank you, Carl Eugen

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Jon bae 
Hello Carl,
that means that the patch is at the moment not useful?! This code comes
from the decklink sdk and there was also the  FAILED() defined, I think. I
have the code from here:
http://ffmpeg.zeranoe.com/forum/viewtopic.php?f=10t=1823start=10#p7580
and there they say it works.
When is ok for you, I copy your answer to the zeranoe forum, then they can
help me to fix it.

2014-12-02 16:45 GMT+01:00 Carl Eugen Hoyos ceho...@ag.or.at:

 Jon bae jonbae77 at gmail.com writes:

  I hope is all right, I never did before a
  git format-patch...

 You used git format-patch perfectly, thank you.

 Your patch introduces tabs, they cannot be committed
 to FFmpeg. You can find tabs with tools/patcheck,
 a script that is part of the source.

 Please do not replace av_log() with fprintf().
 Please do not move opening braces, just leave them
 where they are now.
 Please keep the indentation at four spaces.

 Assuming that the free fix is unrelated to the
 remaining patch, please make it separate.

 (I don't know where FAILED() is defined and
 therefore cannot comment on the actual patch and
 if it can be simplified.)

 Thank you, Carl Eugen

 ___
 ffmpeg-devel mailing list
 ffmpeg-devel@ffmpeg.org
 http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Carl Eugen Hoyos 
Jon bae jonbae77 at gmail.com writes:

 that means that the patch is at the moment not useful?!

I believe it is very useful!

To get it into the FFmpeg git repository, please:
Split the patch in two (one patch per issue).
Remove the tab.
Fix the indentation.
Do not change av_log() into fprintf().
Do not move opening braces.

Carl Eugen

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel