Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec_common: make INFO_TRY_AGAIN trace messages more consistent

[Matthieu Bouron]

On Mon, Mar 12, 2018 at 01:24:02AM -0700, Aman Gupta wrote:
> On Mon, Mar 12, 2018 at 1:16 AM, Matthieu Bouron 
> wrote:
> 
> > ---
> >  libavcodec/mediacodecdec_common.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_
> > common.c
> > index 5064809cf6..058825a1a2 100644
> > --- a/libavcodec/mediacodecdec_common.c
> > +++ b/libavcodec/mediacodecdec_common.c
> > @@ -568,7 +568,7 @@ int ff_mediacodec_dec_send(AVCodecContext *avctx,
> > MediaCodecDecContext *s,
> >
> >  index = ff_AMediaCodec_dequeueInputBuffer(codec,
> > input_dequeue_timeout_us);
> >  if (ff_AMediaCodec_infoTryAgainLater(codec, index)) {
> > -av_log(avctx, AV_LOG_TRACE, "Failed to dequeue input buffer,
> > try again later..\n");
> > +av_log(avctx, AV_LOG_TRACE, "No input buffer available, try
> > again later\n");
> >  break;
> >  }
> >
> > @@ -732,7 +732,7 @@ int ff_mediacodec_dec_receive(AVCodecContext *avctx,
> > MediaCodecDecContext *s,
> >  "while draining remaining frames,
> > output will probably lack frames\n",
> >  output_dequeue_timeout_us / 1000);
> >  } else {
> > -av_log(avctx, AV_LOG_DEBUG, "No output buffer available, try
> > again later\n");
> > +av_log(avctx, AV_LOG_TRACE, "No output buffer available, try
> > again later\n");
> >  }
> >  } else {
> >  av_log(avctx, AV_LOG_ERROR, "Failed to dequeue output buffer
> > (status=%zd)\n", index);
> >
> 
> LGTM

Applied. Thanks.

-- 
Matthieu B.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec_common: make INFO_TRY_AGAIN trace messages more consistent

[Aman Gupta]

On Mon, Mar 12, 2018 at 1:16 AM, Matthieu Bouron 
wrote:

> ---
>  libavcodec/mediacodecdec_common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_
> common.c
> index 5064809cf6..058825a1a2 100644
> --- a/libavcodec/mediacodecdec_common.c
> +++ b/libavcodec/mediacodecdec_common.c
> @@ -568,7 +568,7 @@ int ff_mediacodec_dec_send(AVCodecContext *avctx,
> MediaCodecDecContext *s,
>
>  index = ff_AMediaCodec_dequeueInputBuffer(codec,
> input_dequeue_timeout_us);
>  if (ff_AMediaCodec_infoTryAgainLater(codec, index)) {
> -av_log(avctx, AV_LOG_TRACE, "Failed to dequeue input buffer,
> try again later..\n");
> +av_log(avctx, AV_LOG_TRACE, "No input buffer available, try
> again later\n");
>  break;
>  }
>
> @@ -732,7 +732,7 @@ int ff_mediacodec_dec_receive(AVCodecContext *avctx,
> MediaCodecDecContext *s,
>  "while draining remaining frames,
> output will probably lack frames\n",
>  output_dequeue_timeout_us / 1000);
>  } else {
> -av_log(avctx, AV_LOG_DEBUG, "No output buffer available, try
> again later\n");
> +av_log(avctx, AV_LOG_TRACE, "No output buffer available, try
> again later\n");
>  }
>  } else {
>  av_log(avctx, AV_LOG_ERROR, "Failed to dequeue output buffer
> (status=%zd)\n", index);
>

LGTM



> --
> 2.16.2
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel