Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

[Kyle Swanson]

Hi,

On Fri, Jan 19, 2018 at 5:03 PM, Michael Niedermayer
 wrote:
> On Fri, Jan 19, 2018 at 03:46:57PM -0800, Kyle Swanson wrote:
>> Hi,
>>
>> >
>> > Ping. Unless text needs to be rescaled as well, this patch is ready for 
>> > review.
>> >
>> >
>> > Regards,
>> > Gyan
>> > ___
>> > ffmpeg-devel mailing list
>> > ffmpeg-devel@ffmpeg.org
>> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>>
>> LGTM as-is. I'll push this sometime in the next 24 hours unless
>> someone else has anything to add.
>
> nothing to add, just wanted to test & push myself but as i saw your mail
> and my todo is long i gladly leave that to you :)
>
>
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> I know you won't believe me, but the highest form of Human Excellence is
> to question oneself and others. -- Socrates
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Pushed. Thanks.

Kyle
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

[Michael Niedermayer]

On Fri, Jan 19, 2018 at 03:46:57PM -0800, Kyle Swanson wrote:
> Hi,
> 
> >
> > Ping. Unless text needs to be rescaled as well, this patch is ready for 
> > review.
> >
> >
> > Regards,
> > Gyan
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> 
> LGTM as-is. I'll push this sometime in the next 24 hours unless
> someone else has anything to add.

nothing to add, just wanted to test & push myself but as i saw your mail
and my todo is long i gladly leave that to you :)


[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

[Kyle Swanson]

Hi,

>
> Ping. Unless text needs to be rescaled as well, this patch is ready for 
> review.
>
>
> Regards,
> Gyan
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


LGTM as-is. I'll push this sometime in the next 24 hours unless
someone else has anything to add.

Thanks,
Kyle
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

[Gyan Doshi]

On 1/11/2018 7:12 PM, Gyan Doshi wrote:
The no-op commit e496c45 from Libav introduced an option which allowed 
the user to relocate text to fit within the frame if it was going out of 
bounds.


For some reason, when the merge commit b479e01 was applied, the option 
was added but the code fragment which implemented it, was not. So the 
option was dead on arrival, and has remained impotent (since Feb 2012).


Attached patch implements option. Text styling elements like shadow or 
box are also kept within bounds. Default value changed to false so that 
filter outcome doesn't change in existing scripts.


Regards,
Gyan


Ping. Unless text needs to be rescaled as well, this patch is ready for 
review.


Regards,
Gyan
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

[Gyan Doshi]

On 1/12/2018 2:01 PM, Kyle Swanson wrote:


Just read through the patch, but actually didn't try it yet. I wonder if we
should also scale the size of the text in cases where it's wider than the
frame?


Worth considering. Note that fontsize may be dynamic e.g. `50+t*20` 
which can lead to jerky output if the text is resized mid-animation. I 
realize this should be the concern of the user, but so should fix_bounds 
in the first place :)



Regards,
Gyan
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

[Kyle Swanson]

Hi,

On Thu, Jan 11, 2018 at 5:42 AM, Gyan Doshi  wrote:

> The no-op commit e496c45 from Libav introduced an option which allowed the
> user to relocate text to fit within the frame if it was going out of bounds.
>
> For some reason, when the merge commit b479e01 was applied, the option was
> added but the code fragment which implemented it, was not. So the option
> was dead on arrival, and has remained impotent (since Feb 2012).
>
> Attached patch implements option. Text styling elements like shadow or box
> are also kept within bounds. Default value changed to false so that filter
> outcome doesn't change in existing scripts.
>
> Regards,
> Gyan
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
Just read through the patch, but actually didn't try it yet. I wonder if we
should also scale the size of the text in cases where it's wider than the
frame?

Thanks,
Kyle
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel