Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

[Michael Niedermayer]

On Sat, Sep 16, 2017 at 12:34:13AM +0200, Thomas Mundt wrote:
> 2017-09-15 22:26 GMT+02:00 Michael Niedermayer :
> 
> > On Fri, Sep 15, 2017 at 04:38:16PM +0200, Thomas Mundt wrote: >
> > > Michael, is it possible for you to push this?
> >
> > will push
> >
> 
> Thanks!
> 
> also i see noone listed in MAINTAINERS for vf_(t)interlace
> > if noone objects, you might want to send a patch that adds you for
> > them. It seems you are the most active on these ATM
> >
> 
> Hmm, I would do this, but I have doubts whether I´m qualified for it.
> Coding is just one of my hobbies, though I started using it at work.
> Also I´m quite active ATM, but there will be long periods where I won´t
> find the time following the ML.

I dont know the statistics of how many FFmpeg developers do coding as
a hobby and how many do it in their day job but i think many if not
most here started from it being a hobby ...
also its not required to read every mail, most people are voluteers ...

maybe you could setup a simple filter in your MUA to look for
interlace or vf_(t)interlace


> If that´s okay for you, I will do. Maybe I can deposit an alternative email
> address, which I check more often?

yes, some people list a address with "CC" in MAINTAINERS already

thx

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

[Thomas Mundt]

2017-09-15 22:26 GMT+02:00 Michael Niedermayer :

> On Fri, Sep 15, 2017 at 04:38:16PM +0200, Thomas Mundt wrote: >
> > Michael, is it possible for you to push this?
>
> will push
>

Thanks!

also i see noone listed in MAINTAINERS for vf_(t)interlace
> if noone objects, you might want to send a patch that adds you for
> them. It seems you are the most active on these ATM
>

Hmm, I would do this, but I have doubts whether I´m qualified for it.
Coding is just one of my hobbies, though I started using it at work.
Also I´m quite active ATM, but there will be long periods where I won´t
find the time following the ML.
If that´s okay for you, I will do. Maybe I can deposit an alternative email
address, which I check more often?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

[Michael Niedermayer]

On Fri, Sep 15, 2017 at 04:38:16PM +0200, Thomas Mundt wrote:
> 2017-09-13 23:35 GMT+02:00 Thomas Mundt :
> 
> > 2017-09-06 22:15 GMT+02:00 Thomas Mundt :
> >
> >> 2017-09-01 1:55 GMT+02:00 Thomas Mundt :
> >>
> >>> 2017-09-01 1:22 GMT+02:00 Michael Niedermayer :
> >>>
>  On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote:
>  > On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote:
>  > > 2017-08-31 21:42 GMT+02:00 Michael Niedermayer
>  :
>  > >
>  > > > On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote:
>  > > > > Hi,
>  > > > >
>  > > > > we did a transcoding cascade test at work were over-sharpening
>  became
>  > > > > visible with the complex low-pass filter. This patch rectifies
>  the
>  > > > > behaviour.
>  > > > >
>  > > > > Please comment...
>  > > >
>  > > > did you perform subjective and or objective tests ?
>  > > >
>  > > > objective being some metric like PSNR vs correctly sampled data
>  > > > subjective being double blind tests with humans about which they
>  prefer
>  > > >
>  > >
>  > > The tests have been subjective with a team of video engineers and
>  > > technicians with several test files.
>  > >
>  > > I did a quick SSIM/PSNR check with the first generation of an
>  HD->SD file
>  > > as a reference against the 6th generation.
>  >
>  > if its better then iam fine with it. No more comments from me
> 
>  ahh, forgot, you may want tp add the tests you did and their results
>  to the commit message
> >>>
> >>>
> >>> Sure, new patch attached.
> >>>
> >>
> >> Ping
> >>
> >
> > Ping!
> >
> 
> Michael, is it possible for you to push this?

will push

also i see noone listed in MAINTAINERS for vf_(t)interlace
if noone objects, you might want to send a patch that adds you for
them. It seems you are the most active on these ATM

thx

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

[Thomas Mundt]

2017-09-13 23:35 GMT+02:00 Thomas Mundt :

> 2017-09-06 22:15 GMT+02:00 Thomas Mundt :
>
>> 2017-09-01 1:55 GMT+02:00 Thomas Mundt :
>>
>>> 2017-09-01 1:22 GMT+02:00 Michael Niedermayer :
>>>
 On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote:
 > On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote:
 > > 2017-08-31 21:42 GMT+02:00 Michael Niedermayer
 :
 > >
 > > > On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote:
 > > > > Hi,
 > > > >
 > > > > we did a transcoding cascade test at work were over-sharpening
 became
 > > > > visible with the complex low-pass filter. This patch rectifies
 the
 > > > > behaviour.
 > > > >
 > > > > Please comment...
 > > >
 > > > did you perform subjective and or objective tests ?
 > > >
 > > > objective being some metric like PSNR vs correctly sampled data
 > > > subjective being double blind tests with humans about which they
 prefer
 > > >
 > >
 > > The tests have been subjective with a team of video engineers and
 > > technicians with several test files.
 > >
 > > I did a quick SSIM/PSNR check with the first generation of an
 HD->SD file
 > > as a reference against the 6th generation.
 >
 > if its better then iam fine with it. No more comments from me

 ahh, forgot, you may want tp add the tests you did and their results
 to the commit message
>>>
>>>
>>> Sure, new patch attached.
>>>
>>
>> Ping
>>
>
> Ping!
>

Michael, is it possible for you to push this?
Or is there anything that I need to do?

Regards, Thomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

[Thomas Mundt]

2017-09-06 22:15 GMT+02:00 Thomas Mundt :

> 2017-09-01 1:55 GMT+02:00 Thomas Mundt :
>
>> 2017-09-01 1:22 GMT+02:00 Michael Niedermayer :
>>
>>> On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote:
>>> > On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote:
>>> > > 2017-08-31 21:42 GMT+02:00 Michael Niedermayer
>>> :
>>> > >
>>> > > > On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote:
>>> > > > > Hi,
>>> > > > >
>>> > > > > we did a transcoding cascade test at work were over-sharpening
>>> became
>>> > > > > visible with the complex low-pass filter. This patch rectifies
>>> the
>>> > > > > behaviour.
>>> > > > >
>>> > > > > Please comment...
>>> > > >
>>> > > > did you perform subjective and or objective tests ?
>>> > > >
>>> > > > objective being some metric like PSNR vs correctly sampled data
>>> > > > subjective being double blind tests with humans about which they
>>> prefer
>>> > > >
>>> > >
>>> > > The tests have been subjective with a team of video engineers and
>>> > > technicians with several test files.
>>> > >
>>> > > I did a quick SSIM/PSNR check with the first generation of an HD->SD
>>> file
>>> > > as a reference against the 6th generation.
>>> >
>>> > if its better then iam fine with it. No more comments from me
>>>
>>> ahh, forgot, you may want tp add the tests you did and their results
>>> to the commit message
>>
>>
>> Sure, new patch attached.
>>
>
> Ping
>

Ping!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

[Thomas Mundt]

2017-09-01 1:55 GMT+02:00 Thomas Mundt :

> 2017-09-01 1:22 GMT+02:00 Michael Niedermayer :
>
>> On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote:
>> > On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote:
>> > > 2017-08-31 21:42 GMT+02:00 Michael Niedermayer > >:
>> > >
>> > > > On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote:
>> > > > > Hi,
>> > > > >
>> > > > > we did a transcoding cascade test at work were over-sharpening
>> became
>> > > > > visible with the complex low-pass filter. This patch rectifies the
>> > > > > behaviour.
>> > > > >
>> > > > > Please comment...
>> > > >
>> > > > did you perform subjective and or objective tests ?
>> > > >
>> > > > objective being some metric like PSNR vs correctly sampled data
>> > > > subjective being double blind tests with humans about which they
>> prefer
>> > > >
>> > >
>> > > The tests have been subjective with a team of video engineers and
>> > > technicians with several test files.
>> > >
>> > > I did a quick SSIM/PSNR check with the first generation of an HD->SD
>> file
>> > > as a reference against the 6th generation.
>> >
>> > if its better then iam fine with it. No more comments from me
>>
>> ahh, forgot, you may want tp add the tests you did and their results
>> to the commit message
>
>
> Sure, new patch attached.
>

Ping
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

[Thomas Mundt]

2017-09-01 1:22 GMT+02:00 Michael Niedermayer :

> On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote:
> > On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote:
> > > 2017-08-31 21:42 GMT+02:00 Michael Niedermayer  >:
> > >
> > > > On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote:
> > > > > Hi,
> > > > >
> > > > > we did a transcoding cascade test at work were over-sharpening
> became
> > > > > visible with the complex low-pass filter. This patch rectifies the
> > > > > behaviour.
> > > > >
> > > > > Please comment...
> > > >
> > > > did you perform subjective and or objective tests ?
> > > >
> > > > objective being some metric like PSNR vs correctly sampled data
> > > > subjective being double blind tests with humans about which they
> prefer
> > > >
> > >
> > > The tests have been subjective with a team of video engineers and
> > > technicians with several test files.
> > >
> > > I did a quick SSIM/PSNR check with the first generation of an HD->SD
> file
> > > as a reference against the 6th generation.
> >
> > if its better then iam fine with it. No more comments from me
>
> ahh, forgot, you may want tp add the tests you did and their results
> to the commit message


Sure, new patch attached.


0001-avfilter-interlace-prevent-over-sharpening-with-the-.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

[Michael Niedermayer]

On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote:
> On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote:
> > 2017-08-31 21:42 GMT+02:00 Michael Niedermayer :
> > 
> > > On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote:
> > > > Hi,
> > > >
> > > > we did a transcoding cascade test at work were over-sharpening became
> > > > visible with the complex low-pass filter. This patch rectifies the
> > > > behaviour.
> > > >
> > > > Please comment...
> > >
> > > did you perform subjective and or objective tests ?
> > >
> > > objective being some metric like PSNR vs correctly sampled data
> > > subjective being double blind tests with humans about which they prefer
> > >
> > 
> > The tests have been subjective with a team of video engineers and
> > technicians with several test files.
> > 
> > I did a quick SSIM/PSNR check with the first generation of an HD->SD file
> > as a reference against the 6th generation.
> 
> if its better then iam fine with it. No more comments from me

ahh, forgot, you may want tp add the tests you did and their results
to the commit message

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

[Michael Niedermayer]

On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote:
> 2017-08-31 21:42 GMT+02:00 Michael Niedermayer :
> 
> > On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote:
> > > Hi,
> > >
> > > we did a transcoding cascade test at work were over-sharpening became
> > > visible with the complex low-pass filter. This patch rectifies the
> > > behaviour.
> > >
> > > Please comment...
> >
> > did you perform subjective and or objective tests ?
> >
> > objective being some metric like PSNR vs correctly sampled data
> > subjective being double blind tests with humans about which they prefer
> >
> 
> The tests have been subjective with a team of video engineers and
> technicians with several test files.
> 
> I did a quick SSIM/PSNR check with the first generation of an HD->SD file
> as a reference against the 6th generation.

if its better then iam fine with it. No more comments from me

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

[Thomas Mundt]

2017-08-31 21:42 GMT+02:00 Michael Niedermayer :

> On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote:
> > Hi,
> >
> > we did a transcoding cascade test at work were over-sharpening became
> > visible with the complex low-pass filter. This patch rectifies the
> > behaviour.
> >
> > Please comment...
>
> did you perform subjective and or objective tests ?
>
> objective being some metric like PSNR vs correctly sampled data
> subjective being double blind tests with humans about which they prefer
>

The tests have been subjective with a team of video engineers and
technicians with several test files.

I did a quick SSIM/PSNR check with the first generation of an HD->SD file
as a reference against the 6th generation.
ffmpeg -i test.mxf -i ref.mxf -lavfi  "ssim;[0:v][1:v]psnr" -f null -
2>test.txt
Results without the patch:
[Parsed_ssim_0 @ 041bef00] SSIM Y:0.956508 (13.615881) U:0.991601
(20.757750) V:0.993004 (21.551382) All:0.974405 (15.918463)
[Parsed_psnr_1 @ 03fc8440] PSNR y:31.838009 u:48.424280 v:48.962711
average:34.759466 min:31.699297 max:40.857847
Results with the patch:
[Parsed_ssim_0 @ 0424ed00] SSIM Y:0.970051 (15.236232) U:0.991883
(20.905857) V:0.993174 (21.658049) All:0.981290 (17.279202)
[Parsed_psnr_1 @ 0424f780] PSNR y:34.412108 u:48.504454 v:48.969496
average:37.264644 min:34.310637 max:42.373392
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

[Michael Niedermayer]

On Wed, Aug 30, 2017 at 03:54:08AM +0200, Thomas Mundt wrote:
> Hi,
> 
> we did a transcoding cascade test at work were over-sharpening became
> visible with the complex low-pass filter. This patch rectifies the
> behaviour.
> 
> Please comment...

did you perform subjective and or objective tests ?

objective being some metric like PSNR vs correctly sampled data
subjective being double blind tests with humans about which they prefer



[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel