Re: [FFmpeg-devel] [PATCH] avformat/concatdec: add fallback for calculating file duration

2017-08-30 Thread Nicolas George 
Le primidi 11 fructidor, an CCXXV, Justin Ruggles a écrit :
> If a file does not have a known duration, this leads to the timestamps
> starting over for the next file, causing non-monotonic timestamps.
> To prevent this, track the duration during demuxing and use it to
> determine the current file duration before opening the next file.
> ---
>  libavformat/concatdec.c | 20 ++--
>  1 file changed, 18 insertions(+), 2 deletions(-)

Looks ok.

I wonder if it would not be better to do that in the common code. I
think I assumed the duration of the file was being updated like that
automatically.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: add fallback for calculating file duration

2017-08-30 Thread Paul B Mahol 
On 8/29/17, Justin Ruggles  wrote:
> If a file does not have a known duration, this leads to the timestamps
> starting over for the next file, causing non-monotonic timestamps.
> To prevent this, track the duration during demuxing and use it to
> determine the current file duration before opening the next file.
> ---
>  libavformat/concatdec.c | 20 ++--
>  1 file changed, 18 insertions(+), 2 deletions(-)
>

LGTM, but I'm not maintainer of that demuxer.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel