Re: [FFmpeg-devel] [PATCH] avformat/utils: Terminate SPS in avci100_1080i_extradata to avoid warnings during parsing
On Tue, Mar 24, 2015 at 07:53:22AM +, Carl Eugen Hoyos wrote: Reimar Döffinger Reimar.Doeffinger at gmx.de writes: -0x00, 0x08, 0x00, 0x00, 0x03, 0x01, 0x94, 0x00, +0x00, 0x08, 0x00, 0x00, 0x03, 0x01, 0x94, 0x20, Well, going by your description it makes a lot of sense, but I thought someone copy-pasted this from some reference files/specification/conversion program? it could be that the reference was from a lower layer, but at the layer at which extradata is the RBSP terminantion is needed, also its either way needed between SPS and PPS so the reference would have had to contain 2 seperate arrays not one as we have and whoever combined the 2 then made a mistake also whats worse is that i think that with streamcopy you can write this invalid SPS/PPS into a file The copy-pasted extradata contained another error (the aspect ratio was wrong). applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB DNS cache poisoning attacks, popular search engine, Google internet authority dont be evil, please signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avformat/utils: Terminate SPS in avci100_1080i_extradata to avoid warnings during parsing
On 23.03.2015, at 22:05, Michael Niedermayer michae...@gmx.at wrote: Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/utils.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 6a0f666..6eec7a1 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -4345,7 +4345,7 @@ int ff_generate_avci_extradata(AVStream *st) 0x11, 0x12, 0x08, 0xc6, 0x8c, 0x04, 0x41, 0x28, 0x4c, 0x34, 0xf0, 0x1e, 0x01, 0x13, 0xf2, 0xe0, 0x3c, 0x60, 0x20, 0x20, 0x28, 0x00, 0x00, 0x03, -0x00, 0x08, 0x00, 0x00, 0x03, 0x01, 0x94, 0x00, +0x00, 0x08, 0x00, 0x00, 0x03, 0x01, 0x94, 0x20, Well, going by your description it makes a lot of sense, but I thought someone copy-pasted this from some reference files/specification/conversion program? It might be that the source for these was a bit buggy though, I think we saw that in some other case for AVCI. If nobody has a good answer I'd say apply it. My biggest concern is that some programs may no longer recognize the stream as AVCI compatible after conversion with this change, but probably it's not an issue in reality. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avformat/utils: Terminate SPS in avci100_1080i_extradata to avoid warnings during parsing
Reimar Döffinger Reimar.Doeffinger at gmx.de writes: -0x00, 0x08, 0x00, 0x00, 0x03, 0x01, 0x94, 0x00, +0x00, 0x08, 0x00, 0x00, 0x03, 0x01, 0x94, 0x20, Well, going by your description it makes a lot of sense, but I thought someone copy-pasted this from some reference files/specification/conversion program? The copy-pasted extradata contained another error (the aspect ratio was wrong). Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
