Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity
On 8/21/2014 12:09 PM, Christophe Gisquet wrote: I'm not sure it is the best fix, but I don't think this could happen in any valid file, nor it would help to swallow the error. Perhaps off-topic, but the source drop from Elemental seems to include completely rewritten dref code -- is it worth looking at? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity
Hi, 2014-08-21 14:55 GMT+02:00 Derek Buitenhuis derek.buitenh...@gmail.com: On 8/21/2014 12:09 PM, Christophe Gisquet wrote: I'm not sure it is the best fix, but I don't think this could happen in any valid file, nor it would help to swallow the error. Perhaps off-topic, but the source drop from Elemental seems to include completely rewritten dref code -- is it worth looking at? Actually, the more I think about this patch, the more I want to drop it: I'm not a mov expert. Basically, it makes sense, but the caller tries to handle overreads by just moving to the expected end of the atom. Not a very sane practive unless ones knows that code to be prone to such issues and thinks it can be recovered. As for the new dref code, I'm not an expert, so no opinion. -- Christophe ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity
On Thu, Aug 21, 2014 at 01:55:05PM +0100, Derek Buitenhuis wrote: On 8/21/2014 12:09 PM, Christophe Gisquet wrote: I'm not sure it is the best fix, but I don't think this could happen in any valid file, nor it would help to swallow the error. Perhaps off-topic, but the source drop from Elemental seems to include completely rewritten dref code -- is it worth looking at? can you provide a link ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity
On 8/21/2014 4:13 PM, Michael Niedermayer wrote: can you provide a link ? Provided on IRC. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
