Re: [FFmpeg-devel] [PATCH] new audio filter and misc improvements
On Thu, Aug 10, 2023 at 06:49:50PM +0200, Paul B Mahol wrote: > On Thu, Aug 10, 2023 at 5:13 PM Michael Niedermayer > wrote: > > > On Thu, Aug 10, 2023 at 12:10:49PM +0200, Paul B Mahol wrote: > > > On Thu, Aug 10, 2023 at 11:48 AM Michael Niedermayer < > > mich...@niedermayer.cc> > > > wrote: > > > > > > > On Wed, Aug 09, 2023 at 11:36:16PM +0200, Paul B Mahol wrote: > > > > > Patches attached. > > > > > > > > > af_adeclick.c |7 --- > > > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > b19bd0c3f05d5ebce92f7500dab61bd85d9b3661 > > > > 0003-avfilter-af_adeclick-do-not-output-pointless-message.patch > > > > > From 2d8c330f543397642fa1afe0a01a67155008d4e1 Mon Sep 17 00:00:00 > > 2001 > > > > > From: Paul B Mahol > > > > > Date: Wed, 9 Aug 2023 21:53:04 +0200 > > > > > Subject: [PATCH 3/3] avfilter/af_adeclick: do not output pointless > > > > message > > > > > > > > > > Signed-off-by: Paul B Mahol > > > > > --- > > > > > libavfilter/af_adeclick.c | 7 --- > > > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > [...] > > > > > > > > > af_adeclick.c | 136 > > > > -- > > > > > 1 file changed, 67 insertions(+), 69 deletions(-) > > > > > cfc7bc440f2f408f8570501f3afb2de235860221 > > > > 0002-avfilter-af_adeclick-refactor-and-cleanup.patch > > > > > From 0a6de9b1482ece4402b1c7274501b43e43f5f56a Mon Sep 17 00:00:00 > > 2001 > > > > > From: Paul B Mahol > > > > > Date: Wed, 9 Aug 2023 21:49:19 +0200 > > > > > Subject: [PATCH 2/3] avfilter/af_adeclick: refactor and cleanup > > > > > > > > > > Signed-off-by: Paul B Mahol > > > > > --- > > > > > libavfilter/af_adeclick.c | 136 > > +++--- > > > > > 1 file changed, 67 insertions(+), 69 deletions(-) > > > > > > > > [...] > > > > > > > > > doc/filters.texi | 51 + > > > > > libavfilter/Makefile |1 > > > > > libavfilter/af_adeclick.c | 91 > > > > +++--- > > > > > libavfilter/allfilters.c |1 > > > > > 4 files changed, 140 insertions(+), 4 deletions(-) > > > > > 61d03514ba9fa85d1ec308ce37037a0c07ad9a7f > > > > 0001-avfilter-add-adesurge-filter.patch > > > > > From af565f57f733af327edc1e1724e31a3c5f1fe44f Mon Sep 17 00:00:00 > > 2001 > > > > > From: Paul B Mahol > > > > > Date: Wed, 9 Aug 2023 18:21:25 +0200 > > > > > Subject: [PATCH 1/3] avfilter: add adesurge filter > > > > > > > > > > Signed-off-by: Paul B Mahol > > > > > --- > > > > > doc/filters.texi | 51 ++ > > > > > libavfilter/Makefile | 1 + > > > > > libavfilter/af_adeclick.c | 91 > > +-- > > > > > libavfilter/allfilters.c | 1 + > > > > > 4 files changed, 140 insertions(+), 4 deletions(-) > > > > > > > > It seems you forgot adding fate tests, please make sure fate tests are > > > > added > > > > when this or a future variant is applied > > > > > > > > > > Sorry, Sir!, > > > > > > The filter modules are not mention for fate testing, > > > > doc/developer.texi: > > 807 @item > > 808 Consider adding a regression test for your code. All new modules > > 809 should be covered by tests. That includes demuxers, muxers, decoders, > > encoders > > 810 filters, bitstream filters, parsers. If its not possible to do that, > > add > > 811 an explanation why to your patchset, its ok to not test if theres a > > reason. > > > > so yes, filters should be tested too > > > > > > > and for obvious > > > reasons like usage of non-integer math. > > > > A wide range of non integer modules are tested. > > > > Not possible for non-trivial stuff. Its certainly possible to test float based filters like this. Theres a wide range of tests we have, we have tests that run synthetic input -> code to test -> md5/adler we have tests that run synthetic input -> code to test -> compare to reference / check similarity vs Constant > > Please keep ignoring my patches as you did all these years. That was never intentional, in fact i find many of the areas you work in quite interresting so iam probably not that bad a choice to review them. Its just a question of time and if there something more interresting to do elsewhere thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is better than the prosperity of the fool. -- Epicurus signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] new audio filter and misc improvements
On Thu, Aug 10, 2023 at 5:13 PM Michael Niedermayer wrote: > On Thu, Aug 10, 2023 at 12:10:49PM +0200, Paul B Mahol wrote: > > On Thu, Aug 10, 2023 at 11:48 AM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Wed, Aug 09, 2023 at 11:36:16PM +0200, Paul B Mahol wrote: > > > > Patches attached. > > > > > > > af_adeclick.c |7 --- > > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > b19bd0c3f05d5ebce92f7500dab61bd85d9b3661 > > > 0003-avfilter-af_adeclick-do-not-output-pointless-message.patch > > > > From 2d8c330f543397642fa1afe0a01a67155008d4e1 Mon Sep 17 00:00:00 > 2001 > > > > From: Paul B Mahol > > > > Date: Wed, 9 Aug 2023 21:53:04 +0200 > > > > Subject: [PATCH 3/3] avfilter/af_adeclick: do not output pointless > > > message > > > > > > > > Signed-off-by: Paul B Mahol > > > > --- > > > > libavfilter/af_adeclick.c | 7 --- > > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > [...] > > > > > > > af_adeclick.c | 136 > > > -- > > > > 1 file changed, 67 insertions(+), 69 deletions(-) > > > > cfc7bc440f2f408f8570501f3afb2de235860221 > > > 0002-avfilter-af_adeclick-refactor-and-cleanup.patch > > > > From 0a6de9b1482ece4402b1c7274501b43e43f5f56a Mon Sep 17 00:00:00 > 2001 > > > > From: Paul B Mahol > > > > Date: Wed, 9 Aug 2023 21:49:19 +0200 > > > > Subject: [PATCH 2/3] avfilter/af_adeclick: refactor and cleanup > > > > > > > > Signed-off-by: Paul B Mahol > > > > --- > > > > libavfilter/af_adeclick.c | 136 > +++--- > > > > 1 file changed, 67 insertions(+), 69 deletions(-) > > > > > > [...] > > > > > > > doc/filters.texi | 51 + > > > > libavfilter/Makefile |1 > > > > libavfilter/af_adeclick.c | 91 > > > +++--- > > > > libavfilter/allfilters.c |1 > > > > 4 files changed, 140 insertions(+), 4 deletions(-) > > > > 61d03514ba9fa85d1ec308ce37037a0c07ad9a7f > > > 0001-avfilter-add-adesurge-filter.patch > > > > From af565f57f733af327edc1e1724e31a3c5f1fe44f Mon Sep 17 00:00:00 > 2001 > > > > From: Paul B Mahol > > > > Date: Wed, 9 Aug 2023 18:21:25 +0200 > > > > Subject: [PATCH 1/3] avfilter: add adesurge filter > > > > > > > > Signed-off-by: Paul B Mahol > > > > --- > > > > doc/filters.texi | 51 ++ > > > > libavfilter/Makefile | 1 + > > > > libavfilter/af_adeclick.c | 91 > +-- > > > > libavfilter/allfilters.c | 1 + > > > > 4 files changed, 140 insertions(+), 4 deletions(-) > > > > > > It seems you forgot adding fate tests, please make sure fate tests are > > > added > > > when this or a future variant is applied > > > > > > > Sorry, Sir!, > > > > The filter modules are not mention for fate testing, > > doc/developer.texi: > 807 @item > 808 Consider adding a regression test for your code. All new modules > 809 should be covered by tests. That includes demuxers, muxers, decoders, > encoders > 810 filters, bitstream filters, parsers. If its not possible to do that, > add > 811 an explanation why to your patchset, its ok to not test if theres a > reason. > > so yes, filters should be tested too > > > > and for obvious > > reasons like usage of non-integer math. > > A wide range of non integer modules are tested. > Not possible for non-trivial stuff. Please keep ignoring my patches as you did all these years. And your little SDR adventure inside FFmpeg will not make situation any better. > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > If you fake or manipulate statistics in a paper in physics you will never > get a job again. > If you fake or manipulate statistics in a paper in medicin you will get > a job for life at the pharma industry. > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] new audio filter and misc improvements
On Thu, Aug 10, 2023 at 12:10:49PM +0200, Paul B Mahol wrote: > On Thu, Aug 10, 2023 at 11:48 AM Michael Niedermayer > wrote: > > > On Wed, Aug 09, 2023 at 11:36:16PM +0200, Paul B Mahol wrote: > > > Patches attached. > > > > > af_adeclick.c |7 --- > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > b19bd0c3f05d5ebce92f7500dab61bd85d9b3661 > > 0003-avfilter-af_adeclick-do-not-output-pointless-message.patch > > > From 2d8c330f543397642fa1afe0a01a67155008d4e1 Mon Sep 17 00:00:00 2001 > > > From: Paul B Mahol > > > Date: Wed, 9 Aug 2023 21:53:04 +0200 > > > Subject: [PATCH 3/3] avfilter/af_adeclick: do not output pointless > > message > > > > > > Signed-off-by: Paul B Mahol > > > --- > > > libavfilter/af_adeclick.c | 7 --- > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > [...] > > > > > af_adeclick.c | 136 > > -- > > > 1 file changed, 67 insertions(+), 69 deletions(-) > > > cfc7bc440f2f408f8570501f3afb2de235860221 > > 0002-avfilter-af_adeclick-refactor-and-cleanup.patch > > > From 0a6de9b1482ece4402b1c7274501b43e43f5f56a Mon Sep 17 00:00:00 2001 > > > From: Paul B Mahol > > > Date: Wed, 9 Aug 2023 21:49:19 +0200 > > > Subject: [PATCH 2/3] avfilter/af_adeclick: refactor and cleanup > > > > > > Signed-off-by: Paul B Mahol > > > --- > > > libavfilter/af_adeclick.c | 136 +++--- > > > 1 file changed, 67 insertions(+), 69 deletions(-) > > > > [...] > > > > > doc/filters.texi | 51 + > > > libavfilter/Makefile |1 > > > libavfilter/af_adeclick.c | 91 > > +++--- > > > libavfilter/allfilters.c |1 > > > 4 files changed, 140 insertions(+), 4 deletions(-) > > > 61d03514ba9fa85d1ec308ce37037a0c07ad9a7f > > 0001-avfilter-add-adesurge-filter.patch > > > From af565f57f733af327edc1e1724e31a3c5f1fe44f Mon Sep 17 00:00:00 2001 > > > From: Paul B Mahol > > > Date: Wed, 9 Aug 2023 18:21:25 +0200 > > > Subject: [PATCH 1/3] avfilter: add adesurge filter > > > > > > Signed-off-by: Paul B Mahol > > > --- > > > doc/filters.texi | 51 ++ > > > libavfilter/Makefile | 1 + > > > libavfilter/af_adeclick.c | 91 +-- > > > libavfilter/allfilters.c | 1 + > > > 4 files changed, 140 insertions(+), 4 deletions(-) > > > > It seems you forgot adding fate tests, please make sure fate tests are > > added > > when this or a future variant is applied > > > > Sorry, Sir!, > > The filter modules are not mention for fate testing, doc/developer.texi: 807 @item 808 Consider adding a regression test for your code. All new modules 809 should be covered by tests. That includes demuxers, muxers, decoders, encoders 810 filters, bitstream filters, parsers. If its not possible to do that, add 811 an explanation why to your patchset, its ok to not test if theres a reason. so yes, filters should be tested too > and for obvious > reasons like usage of non-integer math. A wide range of non integer modules are tested. thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you fake or manipulate statistics in a paper in physics you will never get a job again. If you fake or manipulate statistics in a paper in medicin you will get a job for life at the pharma industry. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] new audio filter and misc improvements
On Thu, Aug 10, 2023 at 11:48 AM Michael Niedermayer wrote: > On Wed, Aug 09, 2023 at 11:36:16PM +0200, Paul B Mahol wrote: > > Patches attached. > > > af_adeclick.c |7 --- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > b19bd0c3f05d5ebce92f7500dab61bd85d9b3661 > 0003-avfilter-af_adeclick-do-not-output-pointless-message.patch > > From 2d8c330f543397642fa1afe0a01a67155008d4e1 Mon Sep 17 00:00:00 2001 > > From: Paul B Mahol > > Date: Wed, 9 Aug 2023 21:53:04 +0200 > > Subject: [PATCH 3/3] avfilter/af_adeclick: do not output pointless > message > > > > Signed-off-by: Paul B Mahol > > --- > > libavfilter/af_adeclick.c | 7 --- > > 1 file changed, 4 insertions(+), 3 deletions(-) > [...] > > > af_adeclick.c | 136 > -- > > 1 file changed, 67 insertions(+), 69 deletions(-) > > cfc7bc440f2f408f8570501f3afb2de235860221 > 0002-avfilter-af_adeclick-refactor-and-cleanup.patch > > From 0a6de9b1482ece4402b1c7274501b43e43f5f56a Mon Sep 17 00:00:00 2001 > > From: Paul B Mahol > > Date: Wed, 9 Aug 2023 21:49:19 +0200 > > Subject: [PATCH 2/3] avfilter/af_adeclick: refactor and cleanup > > > > Signed-off-by: Paul B Mahol > > --- > > libavfilter/af_adeclick.c | 136 +++--- > > 1 file changed, 67 insertions(+), 69 deletions(-) > > [...] > > > doc/filters.texi | 51 + > > libavfilter/Makefile |1 > > libavfilter/af_adeclick.c | 91 > +++--- > > libavfilter/allfilters.c |1 > > 4 files changed, 140 insertions(+), 4 deletions(-) > > 61d03514ba9fa85d1ec308ce37037a0c07ad9a7f > 0001-avfilter-add-adesurge-filter.patch > > From af565f57f733af327edc1e1724e31a3c5f1fe44f Mon Sep 17 00:00:00 2001 > > From: Paul B Mahol > > Date: Wed, 9 Aug 2023 18:21:25 +0200 > > Subject: [PATCH 1/3] avfilter: add adesurge filter > > > > Signed-off-by: Paul B Mahol > > --- > > doc/filters.texi | 51 ++ > > libavfilter/Makefile | 1 + > > libavfilter/af_adeclick.c | 91 +-- > > libavfilter/allfilters.c | 1 + > > 4 files changed, 140 insertions(+), 4 deletions(-) > > It seems you forgot adding fate tests, please make sure fate tests are > added > when this or a future variant is applied > Sorry, Sir!, The filter modules are not mention for fate testing, and for obvious reasons like usage of non-integer math. > > thanks > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Rewriting code that is poorly written but fully understood is good. > Rewriting code that one doesnt understand is a sign that one is less smart > than the original author, trying to rewrite it will not make it better. > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] new audio filter and misc improvements
On Wed, Aug 09, 2023 at 11:36:16PM +0200, Paul B Mahol wrote: > Patches attached. > af_adeclick.c |7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > b19bd0c3f05d5ebce92f7500dab61bd85d9b3661 > 0003-avfilter-af_adeclick-do-not-output-pointless-message.patch > From 2d8c330f543397642fa1afe0a01a67155008d4e1 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Wed, 9 Aug 2023 21:53:04 +0200 > Subject: [PATCH 3/3] avfilter/af_adeclick: do not output pointless message > > Signed-off-by: Paul B Mahol > --- > libavfilter/af_adeclick.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) [...] > af_adeclick.c | 136 > -- > 1 file changed, 67 insertions(+), 69 deletions(-) > cfc7bc440f2f408f8570501f3afb2de235860221 > 0002-avfilter-af_adeclick-refactor-and-cleanup.patch > From 0a6de9b1482ece4402b1c7274501b43e43f5f56a Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Wed, 9 Aug 2023 21:49:19 +0200 > Subject: [PATCH 2/3] avfilter/af_adeclick: refactor and cleanup > > Signed-off-by: Paul B Mahol > --- > libavfilter/af_adeclick.c | 136 +++--- > 1 file changed, 67 insertions(+), 69 deletions(-) [...] > doc/filters.texi | 51 + > libavfilter/Makefile |1 > libavfilter/af_adeclick.c | 91 > +++--- > libavfilter/allfilters.c |1 > 4 files changed, 140 insertions(+), 4 deletions(-) > 61d03514ba9fa85d1ec308ce37037a0c07ad9a7f > 0001-avfilter-add-adesurge-filter.patch > From af565f57f733af327edc1e1724e31a3c5f1fe44f Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Wed, 9 Aug 2023 18:21:25 +0200 > Subject: [PATCH 1/3] avfilter: add adesurge filter > > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 51 ++ > libavfilter/Makefile | 1 + > libavfilter/af_adeclick.c | 91 +-- > libavfilter/allfilters.c | 1 + > 4 files changed, 140 insertions(+), 4 deletions(-) It seems you forgot adding fate tests, please make sure fate tests are added when this or a future variant is applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that one is less smart than the original author, trying to rewrite it will not make it better. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
