Re: [FFmpeg-devel] [PATCH] swscale: more accurate DITHER_COPY macro for full and limited range

2017-10-23 Thread Michael Niedermayer 
On Fri, Oct 06, 2017 at 05:33:22PM +0200, Mateusz wrote:
> Fixed DITHER_COPY macro (only C code), updated FATE tests.
> 
> PSNR in tests that needed update goes from 50 to 999.99 -- the quality is 
> there.
> 
> Please review.
> 
> Mateusz
> 

>  libswscale/swscale_unscaled.c  |   73 
> +++--
>  tests/ref/vsynth/vsynth1-ffvhuff420p12 |4 -
>  tests/ref/vsynth/vsynth1-vc2-420p10|4 -
>  tests/ref/vsynth/vsynth1-vc2-420p12|4 -
>  tests/ref/vsynth/vsynth2-ffvhuff420p12 |4 -
>  tests/ref/vsynth/vsynth2-vc2-420p10|4 -
>  tests/ref/vsynth/vsynth2-vc2-420p12|4 -
>  tests/ref/vsynth/vsynth3-ffvhuff420p12 |4 -
>  tests/ref/vsynth/vsynth_lena-ffvhuff420p12 |4 -
>  tests/ref/vsynth/vsynth_lena-vc2-420p10|4 -
>  tests/ref/vsynth/vsynth_lena-vc2-420p12|4 -
>  11 files changed, 58 insertions(+), 55 deletions(-)
> 3a5b24e81786299d53ab52b07eabc26dcec2766e  
> 0001-swscale-more-accurate-DITHER_COPY-macro-for-full-and.patch
> From d870ba10aa4b3520fc30215fbbd57565faa13df4 Mon Sep 17 00:00:00 2001
> From: Mateusz 
> Date: Fri, 6 Oct 2017 16:49:54 +0200
> Subject: [PATCH] swscale: more accurate DITHER_COPY macro for full and limited
>  range

applied

thanks


[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] swscale: more accurate DITHER_COPY macro for full and limited range

2017-10-23 Thread Mateusz 
W dniu 2017-10-20 o 20:07, Jan Ekstrom pisze:
> On Fri, Oct 20, 2017 at 10:26 AM, Mateusz  wrote:
>> W dniu 2017-10-06 o 17:33, Mateusz pisze:
>>> Fixed DITHER_COPY macro (only C code), updated FATE tests.
>>>
>>> PSNR in tests that needed update goes from 50 to 999.99 -- the quality is 
>>> there.
>>
>> Ping.
> 
> Hi,
> 
> The updated PSNR values look really good (and the max difference going
> from 1 to 0), but unfortunately I lack the capacity to verify that the
> code is doing the same thing as the original thing.
> 
> Can we please have someone's eyes on this? If a patchwork URL makes it
> simpler, it's https://patchwork.ffmpeg.org/patch/5440/ .
> 
> 
> Jan

There was discussion about this code in thread "swscale_unscaled: fix 
DITHER_COPY macro, use it only for dst_depth == 8". Conclusion was that it 
should be the same code for dst_depth from 8 to 15 bit (in all possible cases).

The worse quality scenario for this DITHER_COPY macro is when dst_depth is 8. 
It is hard to see differences from normal 8 bit to dithered 8 bit (too good 
quality).

I've prepared example movies with new DITHER_COPY macro versus downshift only 
with dst_depth == 5 (impossible in normal code, only for testing).

Movie Sintel in resolution 2K with bit depth 5 (original 5 most significant 
bits):
www.msystem.waw.pl/x265/sintel-org5.mkv

The same movie with bit depth 5, but dithered 5 bit instead of original:
www.msystem.waw.pl/x265/sintel-dit5.mkv

Mateusz

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] swscale: more accurate DITHER_COPY macro for full and limited range

2017-10-20 Thread Jan Ekstrom 
On Fri, Oct 20, 2017 at 10:26 AM, Mateusz  wrote:
> W dniu 2017-10-06 o 17:33, Mateusz pisze:
>> Fixed DITHER_COPY macro (only C code), updated FATE tests.
>>
>> PSNR in tests that needed update goes from 50 to 999.99 -- the quality is 
>> there.
>
> Ping.

Hi,

The updated PSNR values look really good (and the max difference going
from 1 to 0), but unfortunately I lack the capacity to verify that the
code is doing the same thing as the original thing.

Can we please have someone's eyes on this? If a patchwork URL makes it
simpler, it's https://patchwork.ffmpeg.org/patch/5440/ .


Jan
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] swscale: more accurate DITHER_COPY macro for full and limited range

2017-10-20 Thread Mateusz 
W dniu 2017-10-06 o 17:33, Mateusz pisze:
> Fixed DITHER_COPY macro (only C code), updated FATE tests.
> 
> PSNR in tests that needed update goes from 50 to 999.99 -- the quality is 
> there.

Ping.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel