Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack
Hi, On Wed, May 13, 2015 at 6:24 AM, Hendrik Leppkes h.lepp...@gmail.com wrote: On Wed, May 13, 2015 at 12:09 PM, Rainer Hochecker fernetme...@online.de wrote: Carl Eugen Hoyos cehoyos at ag.or.at writes: That sounds impossible since the patch was pushed as http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=f7ed997a Carl Eugen Why exactly is that impossible? It crashes in ff_pack_8ch_float_to_int32_a_sse2 on Windows. Same code, same scenario is fine on other platforms. Kodi's build script suggests that FFmpeg is build with gcc - this crash and fix only ever applied to MSVC/ICL builds. Is the entry point (from msvc code of kodi into ffmpeg/gcc code) marked as realigning? Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack
Rainer Hochecker fernetmenta at online.de writes: Kodi crashes on Windows when doing 8 channel conversion. This seems to be the source of the problem. That sounds impossible since the patch was pushed as http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=f7ed997a Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack
Carl Eugen Hoyos cehoyos at ag.or.at writes: That sounds impossible since the patch was pushed as http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=f7ed997a Carl Eugen Why exactly is that impossible? It crashes in ff_pack_8ch_float_to_int32_a_sse2 on Windows. Same code, same scenario is fine on other platforms. Rainer ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack
Michael Niedermayer michaelni at gmx.at writes: can someone who has ICL/MSVC setup test this please failing that, lets apply the patch [...] Kodi crashes on Windows when doing 8 channel conversion. This seems to be the source of the problem. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack
Hi, On Wed, May 13, 2015 at 7:18 AM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Wed, May 13, 2015 at 6:24 AM, Hendrik Leppkes h.lepp...@gmail.com wrote: On Wed, May 13, 2015 at 12:09 PM, Rainer Hochecker fernetme...@online.de wrote: Carl Eugen Hoyos cehoyos at ag.or.at writes: That sounds impossible since the patch was pushed as http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=f7ed997a Carl Eugen Why exactly is that impossible? It crashes in ff_pack_8ch_float_to_int32_a_sse2 on Windows. Same code, same scenario is fine on other platforms. Kodi's build script suggests that FFmpeg is build with gcc - this crash and fix only ever applied to MSVC/ICL builds. Is the entry point (from msvc code of kodi into ffmpeg/gcc code) marked as realigning? Seems it isn't: $ grep attribute_align_arg ~/Projects/ffmpeg/libswresample/*.c $ Check other libs for usage. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack
Hendrik Leppkes h.leppkes at gmail.com writes: Kodi's build script suggests that FFmpeg is build with gcc - this crash and fix only ever applied to MSVC/ICL builds. It starts crashing with this commit: https://github.com/FFmpeg/FFmpeg/commit/37b35feb64e4e0382cd5e4502dbf0f7ff9aa0 b5f Rainer ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack
On Wed, May 13, 2015 at 12:09 PM, Rainer Hochecker fernetme...@online.de wrote: Carl Eugen Hoyos cehoyos at ag.or.at writes: That sounds impossible since the patch was pushed as http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=f7ed997a Carl Eugen Why exactly is that impossible? It crashes in ff_pack_8ch_float_to_int32_a_sse2 on Windows. Same code, same scenario is fine on other platforms. Kodi's build script suggests that FFmpeg is build with gcc - this crash and fix only ever applied to MSVC/ICL builds. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack
Rainer Hochecker fernetmenta at online.de writes: Kodi's build script suggests that FFmpeg is build with gcc - this crash and fix only ever applied to MSVC/ICL builds. It starts crashing with this commit: https://github.com/FFmpeg/FFmpeg/commit/37b35feb So does adding attribute_align_arg to swr_convert_frame() (and friends?) fix the issue? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack
Carl Eugen Hoyos cehoyos at ag.or.at writes: So does adding attribute_align_arg to swr_convert_frame() (and friends?) fix the issue? Carl Eugen I added it to swr_convert and it does fix the issue here. Rainer ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack
On 11/01/15 10:48 AM, Michael Niedermayer wrote: On Tue, Jan 06, 2015 at 02:04:12AM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- I don't have MSVC or ICL 10.x, so i only tested this with gcc after forcing HAVE_ALIGNED_STACK to 0 in config.asm can someone who has ICL/MSVC setup test this please failing that, lets apply the patch Ping? If nobody can test it then I'll just apply it and wait for FATE to confirm it works or not. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack
On Tue, Jan 06, 2015 at 02:04:12AM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- I don't have MSVC or ICL 10.x, so i only tested this with gcc after forcing HAVE_ALIGNED_STACK to 0 in config.asm can someone who has ICL/MSVC setup test this please failing that, lets apply the patch [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when they are wrong. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
