Re: [FFmpeg-devel] [PATCH 4/4] avfilter/f_metadata: whitespace clean-up

2016-02-14 Thread Paul B Mahol 
All aplied. Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 4/4] avfilter/f_metadata: whitespace clean-up

2016-02-11 Thread Paul B Mahol 
On 2/11/16, Tobias Rapp  wrote:
> Signed-off-by: Tobias Rapp 
> ---
>  libavfilter/f_metadata.c | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
>

Patches LGTM.

Removed tabs from patches, gonna apply it soon.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 4/4] avfilter/f_metadata: whitespace clean-up

2016-02-11 Thread Paul B Mahol 
On 2/11/16, Tobias Rapp  wrote:
> On 11.02.2016 14:12, Paul B Mahol wrote:
>> On 2/11/16, Tobias Rapp  wrote:
>>> Signed-off-by: Tobias Rapp 
>>> ---
>>>   libavfilter/f_metadata.c | 16 
>>>   1 file changed, 8 insertions(+), 8 deletions(-)
>>>
>>
>> Patches LGTM.
>>
>> Removed tabs from patches, gonna apply it soon.
>
> Sorry for the tabs, I forgot to add "set expandtab" in .vimrc on my machine.
>
> I guess after patch #2 the "string" function can be reduced to check for
> full string match only and doesn't need "length" anymore? If you agree
> what about renaming "string" to "same_str"?

OK, will do it.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 4/4] avfilter/f_metadata: whitespace clean-up

2016-02-11 Thread Tobias Rapp 

On 11.02.2016 15:00, Paul B Mahol wrote:

On 2/11/16, Tobias Rapp  wrote:

On 11.02.2016 14:12, Paul B Mahol wrote:

On 2/11/16, Tobias Rapp  wrote:

Signed-off-by: Tobias Rapp 
---
   libavfilter/f_metadata.c | 16 
   1 file changed, 8 insertions(+), 8 deletions(-)



Patches LGTM.

Removed tabs from patches, gonna apply it soon.


Sorry for the tabs, I forgot to add "set expandtab" in .vimrc on my machine.

I guess after patch #2 the "string" function can be reduced to check for
full string match only and doesn't need "length" anymore? If you agree
what about renaming "string" to "same_str"?


OK, will do it.


I didn't intend to assign the patch writing task to you, just wanted to 
know your opinion.


___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 4/4] avfilter/f_metadata: whitespace clean-up

2016-02-11 Thread Paul B Mahol 
On 2/11/16, Tobias Rapp  wrote:
> On 11.02.2016 15:00, Paul B Mahol wrote:
>> On 2/11/16, Tobias Rapp  wrote:
>>> On 11.02.2016 14:12, Paul B Mahol wrote:
 On 2/11/16, Tobias Rapp  wrote:
> Signed-off-by: Tobias Rapp 
> ---
>libavfilter/f_metadata.c | 16 
>1 file changed, 8 insertions(+), 8 deletions(-)
>

 Patches LGTM.

 Removed tabs from patches, gonna apply it soon.
>>>
>>> Sorry for the tabs, I forgot to add "set expandtab" in .vimrc on my
>>> machine.
>>>
>>> I guess after patch #2 the "string" function can be reduced to check for
>>> full string match only and doesn't need "length" anymore? If you agree
>>> what about renaming "string" to "same_str"?
>>
>> OK, will do it.
>
> I didn't intend to assign the patch writing task to you, just wanted to
> know your opinion.

If you want to write than feel free to do it.

> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 4/4] avfilter/f_metadata: whitespace clean-up

2016-02-11 Thread Tobias Rapp 

On 11.02.2016 14:12, Paul B Mahol wrote:

On 2/11/16, Tobias Rapp  wrote:

Signed-off-by: Tobias Rapp 
---
  libavfilter/f_metadata.c | 16 
  1 file changed, 8 insertions(+), 8 deletions(-)



Patches LGTM.

Removed tabs from patches, gonna apply it soon.


Sorry for the tabs, I forgot to add "set expandtab" in .vimrc on my machine.

I guess after patch #2 the "string" function can be reduced to check for 
full string match only and doesn't need "length" anymore? If you agree 
what about renaming "string" to "same_str"?


Regards,
Tobias

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel