Re: [FFmpeg-devel] [PATCH 6/6] avformat/mxfdec: add support for recognizing timed text streams
tis 2018-06-05 klockan 20:33 +0200 skrev Marton Balint: > > On Tue, 5 Jun 2018, Tomas Härdin wrote: > > > tor 2018-05-31 klockan 02:05 +0200 skrev Marton Balint: > > > > Signed-off-by: Marton Balint > > > > > > --- > > > libavformat/mxfdec.c | 8 > > > 1 file changed, 8 insertions(+) > > > > > > +type = avcodec_get_type(st->codecpar->codec_id); > > > +if (type == AVMEDIA_TYPE_SUBTITLE) > > > +st->codecpar->codec_type = type; > > > > This feels like something that belongs in more generic parts of lavf. > > Filling codecpar with defaults for some given codec_id that is. > > I assumed some codecs can be audio and video at the same time, and this is > why it's not automatic. wrapped_avframe (like it or not) is such a codec. > In any case, I'd rather not change the way it works here... Huh, didn't know that. Actually, the separation of audio and video is probably one of the greatest crimes in digital multimedia /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 6/6] avformat/mxfdec: add support for recognizing timed text streams
On Tue, 5 Jun 2018, Tomas Härdin wrote: tor 2018-05-31 klockan 02:05 +0200 skrev Marton Balint: > Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 8 1 file changed, 8 insertions(+) +type = avcodec_get_type(st->codecpar->codec_id); +if (type == AVMEDIA_TYPE_SUBTITLE) +st->codecpar->codec_type = type; This feels like something that belongs in more generic parts of lavf. Filling codecpar with defaults for some given codec_id that is. I assumed some codecs can be audio and video at the same time, and this is why it's not automatic. wrapped_avframe (like it or not) is such a codec. In any case, I'd rather not change the way it works here... Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 6/6] avformat/mxfdec: add support for recognizing timed text streams
tor 2018-05-31 klockan 02:05 +0200 skrev Marton Balint: > > Signed-off-by: Marton Balint > --- > libavformat/mxfdec.c | 8 > 1 file changed, 8 insertions(+) > > +type = avcodec_get_type(st->codecpar->codec_id); > +if (type == AVMEDIA_TYPE_SUBTITLE) > +st->codecpar->codec_type = type; This feels like something that belongs in more generic parts of lavf. Filling codecpar with defaults for some given codec_id that is. /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
