Re: [FFmpeg-devel] [PATCH v1] avcodec/h264_parse: decode sps before pps

2019-10-07 Thread Jun Li
On Mon, Oct 7, 2019 at 7:50 PM Fu, Linjie  wrote:

> > -Original Message-
> > From: ffmpeg-devel  On Behalf Of Jun
> > Li
> > Sent: Tuesday, October 8, 2019 05:42
> > To: ffmpeg-devel@ffmpeg.org
> > Subject: [FFmpeg-devel] [PATCH v1] avcodec/h264_parse: decode sps
> > before pps
> >
> > Fix ticket #6422
> > The content put pps before sps, which is not a common case. The change
> > just put decoding sps before pps, just for compability.
> >
> > Signed-off-by: Jun Li 
> > ---
> >  libavcodec/h264_parse.c | 21 +++--
> >  1 file changed, 11 insertions(+), 10 deletions(-)
> >
> > diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c
> > index 352ffea948..26aaa751ad 100644
> > --- a/libavcodec/h264_parse.c
> > +++ b/libavcodec/h264_parse.c
> > @@ -373,35 +373,36 @@ static int decode_extradata_ps(const uint8_t *data,
> > int size, H264ParamSets *ps,
> >  goto fail;
> >  }
> >
> > -for (i = 0; i < pkt.nb_nals; i++) {
> > +/* decode sps before pps, just in case some bitstream put pps
> before sps.
> > */
> > +for(i = 0; i < pkt.nb_nals; i++) {
>
> Nit: Missing space here.


Thanks, will fix in next iteration.


>
>
- linjie
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1] avcodec/h264_parse: decode sps before pps

2019-10-07 Thread Fu, Linjie
> -Original Message-
> From: ffmpeg-devel  On Behalf Of Jun
> Li
> Sent: Tuesday, October 8, 2019 05:42
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v1] avcodec/h264_parse: decode sps
> before pps
> 
> Fix ticket #6422
> The content put pps before sps, which is not a common case. The change
> just put decoding sps before pps, just for compability.
> 
> Signed-off-by: Jun Li 
> ---
>  libavcodec/h264_parse.c | 21 +++--
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 
> diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c
> index 352ffea948..26aaa751ad 100644
> --- a/libavcodec/h264_parse.c
> +++ b/libavcodec/h264_parse.c
> @@ -373,35 +373,36 @@ static int decode_extradata_ps(const uint8_t *data,
> int size, H264ParamSets *ps,
>  goto fail;
>  }
> 
> -for (i = 0; i < pkt.nb_nals; i++) {
> +/* decode sps before pps, just in case some bitstream put pps before sps.
> */
> +for(i = 0; i < pkt.nb_nals; i++) {

Nit: Missing space here.

- linjie
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".