Re: [FFmpeg-devel] [PATCH v2 1/4] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet
Limin Wang (12020-04-21): > OK, Got it, I'll merge patch #1,#2,#4 into one patch and update the patch set. You forgot the part about writing the result of your examination of the tests in the commit message. A commit that changes tests reference files should explain what changed. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v2 1/4] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet
On Tue, Apr 21, 2020 at 11:26:14AM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-04-21): > > From: Limin Wang > > > > For better code review, the patch is helping to update the fate tests result > > so the change of ffmpeg.c will be deleted in the last patch. > > > > Signed-off-by: Limin Wang > > You did not need to post it. You only needed to make it, run it, note > carefully the results, and the go back to your work and consign the > results in the relevant commit message. > > I mean, I do not know how you work, but personally I frequently add tons > of av_log() everywhere to track an issue. But they never get to the > mailing list. OK, Got it, I'll merge patch #1,#2,#4 into one patch and update the patch set. > > Regards, > > -- > Nicolas George -- Thanks, Limin Wang ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v2 1/4] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet
lance.lmw...@gmail.com (12020-04-21): > From: Limin Wang > > For better code review, the patch is helping to update the fate tests result > so the change of ffmpeg.c will be deleted in the last patch. > > Signed-off-by: Limin Wang You did not need to post it. You only needed to make it, run it, note carefully the results, and the go back to your work and consign the results in the relevant commit message. I mean, I do not know how you work, but personally I frequently add tons of av_log() everywhere to track an issue. But they never get to the mailing list. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
