Re: [FFmpeg-devel] [PATCH v2 2/2] libavcodec/libaomenc.c: Add command-line options for inter-coding tools

2020-07-24 Thread James Zern
On Thu, Jul 23, 2020 at 3:48 PM James Zern  wrote:
>
> On Wed, Jul 22, 2020 at 4:11 PM Wang Cao  wrote:
> >
> > From: Wang Cao 
> >
> > Signed-off-by: Wang Cao 
> > ---
> >  doc/encoders.texi  | 36 +
> >  libavcodec/libaomenc.c | 60 ++
> >  libavcodec/version.h   |  2 +-
> >  3 files changed, 97 insertions(+), 1 deletion(-)
> >
>
> lgtm. I'll apply this soon if there aren't any comments.

applied, thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 2/2] libavcodec/libaomenc.c: Add command-line options for inter-coding tools

2020-07-23 Thread James Zern
On Wed, Jul 22, 2020 at 4:11 PM Wang Cao  wrote:
>
> From: Wang Cao 
>
> Signed-off-by: Wang Cao 
> ---
>  doc/encoders.texi  | 36 +
>  libavcodec/libaomenc.c | 60 ++
>  libavcodec/version.h   |  2 +-
>  3 files changed, 97 insertions(+), 1 deletion(-)
>

lgtm. I'll apply this soon if there aren't any comments.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 2/2] libavcodec/libaomenc.c: Add command-line options for inter-coding tools

2020-07-17 Thread James Zern
On Tue, Jul 14, 2020 at 7:09 PM Wang Cao  wrote:
>
> From: Wang Cao 
>
> Signed-off-by: Wang Cao 
> ---
>  doc/encoders.texi  | 36 +
>  libavcodec/libaomenc.c | 60 ++
>  libavcodec/version.h   |  2 +-
>  3 files changed, 97 insertions(+), 1 deletion(-)
>
> [...]
>  codecctl_int(avctx, AOME_SET_STATIC_THRESHOLD, ctx->static_thresh);
> @@ -1193,6 +1241,18 @@ static const AVOption options[] = {
>  { "use-intra-dct-only","Use DCT only for INTRA modes",   
>   OFFSET(use_intra_dct_only),AV_OPT_TYPE_BOOL, {.i64 = 
> -1}, -1, 1, VE},
>  { "use-inter-dct-only","Use DCT only for INTER modes",   
>   OFFSET(use_inter_dct_only),AV_OPT_TYPE_BOOL, {.i64 = 
> -1}, -1, 1, VE},
>  { "use-intra-default-tx-only", "Use Default-transform only for INTRA 
> modes",   OFFSET(use_intra_default_tx_only), AV_OPT_TYPE_BOOL, {.i64 
> = -1}, -1, 1, VE},
> +{ "enable-ref-frame-mvs", "Enable temporal mv prediction. 
> Default is true",   OFFSET(enable_ref_frame_mvs), 
> AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE},
> +{ "enable-reduced-reference-set", "Use reduced set of single and 
> compound references. Default is false.", 
> OFFSET(enable_reduced_reference_set), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, 
> VE},
> +{ "enable-obmc",  "Enable obmc. Default is true",
>  OFFSET(enable_obmc),  
> AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE},
> +{ "enable-dual-filter",   "Enable dual filter. Default is true", 
>  OFFSET(enable_dual_filter),   
> AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE},
> +{ "enable-diff-wtd-comp", "Enable difference-weighted compound. 
> Default is true", OFFSET(enable_diff_wtd_comp), 
> AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE},

Same comment here as in the previous patch in this set, I think the
default comment can go since the default is really the library
default.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".