Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-10 Thread Carl Eugen Hoyos 
2018-05-10 22:44 GMT+02:00, Tomas Härdin :

> Could you attach a patch that applies cleanly? I tried to git am it on
> commit 0612e29 but not luck

Because it was applied as a3a6d4da6

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-10 Thread Tomas Härdin 
tor 2018-05-10 klockan 22:44 +0200 skrev Tomas Härdin:
> tis 2018-05-08 klockan 18:32 +0200 skrev Thomas Mundt:
> > 2018-05-07 10:40 GMT+02:00 Tomas Härdin :
> > 
> > > sön 2018-05-06 klockan 21:31 +0200 skrev Thomas Mundt:
> > > > 2018-05-06 13:32 GMT+02:00 Tomas Härdin :
> > > > 
> > > > > fre 2018-05-04 klockan 01:52 +0200 skrev Thomas Mundt:
> > > > > > Hi,
> > > > > > 
> > > > > > this is a better version of the patch.
> > > > > > 10 bit and TFF are mandatory for AVC Intra only. Other
> > > > > > profiles
> > > > > > differ.
> > > > > > 
> > > > > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > > > > > index 3bb7032..81513dc 100644
> > > > > > --- a/libavformat/mxfenc.c
> > > > > > +++ b/libavformat/mxfenc.c
> > > > > > @@ -1947,22 +1947,31 @@ static const struct {
> > > > > >  int frame_size;
> > > > > >  int profile;
> > > > > >  uint8_t interlaced;
> > > > > > +int long_gop;
> > > > > 
> > > > > A comment here explaining the difference between -1, 0 and 1
> > > > > would
> > > > > be
> > > > > nice. The rest looks OK, but I didn't read the relevant specs
> > > > > to be
> > > > > 100% sure
> > > > > 
> > > > > 
> > > > 
> > > > New patch attached.
> > > 
> > > Looks OK
> > 
> > 
> > Thanks,
> > 
> > can you or someone else push it please.
> 
> Could you attach a patch that applies cleanly? I tried to git am it
> on
> commit 0612e29 but not luck

Never mind, I just saw Michael applied this

/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-10 Thread Tomas Härdin 
tis 2018-05-08 klockan 18:32 +0200 skrev Thomas Mundt:
> 2018-05-07 10:40 GMT+02:00 Tomas Härdin :
> 
> > sön 2018-05-06 klockan 21:31 +0200 skrev Thomas Mundt:
> > > 2018-05-06 13:32 GMT+02:00 Tomas Härdin :
> > > 
> > > > fre 2018-05-04 klockan 01:52 +0200 skrev Thomas Mundt:
> > > > > Hi,
> > > > > 
> > > > > this is a better version of the patch.
> > > > > 10 bit and TFF are mandatory for AVC Intra only. Other
> > > > > profiles
> > > > > differ.
> > > > > 
> > > > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > > > > index 3bb7032..81513dc 100644
> > > > > --- a/libavformat/mxfenc.c
> > > > > +++ b/libavformat/mxfenc.c
> > > > > @@ -1947,22 +1947,31 @@ static const struct {
> > > > >  int frame_size;
> > > > >  int profile;
> > > > >  uint8_t interlaced;
> > > > > +int long_gop;
> > > > 
> > > > A comment here explaining the difference between -1, 0 and 1
> > > > would
> > > > be
> > > > nice. The rest looks OK, but I didn't read the relevant specs
> > > > to be
> > > > 100% sure
> > > > 
> > > > 
> > > 
> > > New patch attached.
> > 
> > Looks OK
> 
> 
> Thanks,
> 
> can you or someone else push it please.

Could you attach a patch that applies cleanly? I tried to git am it on
commit 0612e29 but not luck

/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-09 Thread Michael Niedermayer 
On Tue, May 08, 2018 at 06:32:12PM +0200, Thomas Mundt wrote:
> 2018-05-07 10:40 GMT+02:00 Tomas Härdin :
> 
> > sön 2018-05-06 klockan 21:31 +0200 skrev Thomas Mundt:
> > > 2018-05-06 13:32 GMT+02:00 Tomas Härdin :
> > >
> > > > fre 2018-05-04 klockan 01:52 +0200 skrev Thomas Mundt:
> > > > > Hi,
> > > > >
> > > > > this is a better version of the patch.
> > > > > 10 bit and TFF are mandatory for AVC Intra only. Other profiles
> > > > > differ.
> > > > >
> > > > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > > > > index 3bb7032..81513dc 100644
> > > > > --- a/libavformat/mxfenc.c
> > > > > +++ b/libavformat/mxfenc.c
> > > > > @@ -1947,22 +1947,31 @@ static const struct {
> > > > >  int frame_size;
> > > > >  int profile;
> > > > >  uint8_t interlaced;
> > > > > +int long_gop;
> > > >
> > > > A comment here explaining the difference between -1, 0 and 1 would
> > > > be
> > > > nice. The rest looks OK, but I didn't read the relevant specs to be
> > > > 100% sure
> > > > 
> > > >
> > >
> > > New patch attached.
> >
> > Looks OK
> 
> 
> Thanks,
> 
> can you or someone else push it please.

will apply

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-08 Thread Thomas Mundt 
2018-05-07 10:40 GMT+02:00 Tomas Härdin :

> sön 2018-05-06 klockan 21:31 +0200 skrev Thomas Mundt:
> > 2018-05-06 13:32 GMT+02:00 Tomas Härdin :
> >
> > > fre 2018-05-04 klockan 01:52 +0200 skrev Thomas Mundt:
> > > > Hi,
> > > >
> > > > this is a better version of the patch.
> > > > 10 bit and TFF are mandatory for AVC Intra only. Other profiles
> > > > differ.
> > > >
> > > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > > > index 3bb7032..81513dc 100644
> > > > --- a/libavformat/mxfenc.c
> > > > +++ b/libavformat/mxfenc.c
> > > > @@ -1947,22 +1947,31 @@ static const struct {
> > > >  int frame_size;
> > > >  int profile;
> > > >  uint8_t interlaced;
> > > > +int long_gop;
> > >
> > > A comment here explaining the difference between -1, 0 and 1 would
> > > be
> > > nice. The rest looks OK, but I didn't read the relevant specs to be
> > > 100% sure
> > > 
> > >
> >
> > New patch attached.
>
> Looks OK


Thanks,

can you or someone else push it please.

Regards,
Thomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-07 Thread Tomas Härdin 
sön 2018-05-06 klockan 21:31 +0200 skrev Thomas Mundt:
> 2018-05-06 13:32 GMT+02:00 Tomas Härdin :
> 
> > fre 2018-05-04 klockan 01:52 +0200 skrev Thomas Mundt:
> > > Hi,
> > > 
> > > this is a better version of the patch.
> > > 10 bit and TFF are mandatory for AVC Intra only. Other profiles
> > > differ.
> > > 
> > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > > index 3bb7032..81513dc 100644
> > > --- a/libavformat/mxfenc.c
> > > +++ b/libavformat/mxfenc.c
> > > @@ -1947,22 +1947,31 @@ static const struct {
> > >  int frame_size;
> > >  int profile;
> > >  uint8_t interlaced;
> > > +int long_gop;
> > 
> > A comment here explaining the difference between -1, 0 and 1 would
> > be
> > nice. The rest looks OK, but I didn't read the relevant specs to be
> > 100% sure
> > 
> > 
> 
> New patch attached.

Looks OK

/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-06 Thread Thomas Mundt 
2018-05-06 13:32 GMT+02:00 Tomas Härdin :

> fre 2018-05-04 klockan 01:52 +0200 skrev Thomas Mundt:
> > Hi,
> >
> > this is a better version of the patch.
> > 10 bit and TFF are mandatory for AVC Intra only. Other profiles
> > differ.
> >
>
> > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > index 3bb7032..81513dc 100644
> > --- a/libavformat/mxfenc.c
> > +++ b/libavformat/mxfenc.c
> > @@ -1947,22 +1947,31 @@ static const struct {
> >  int frame_size;
> >  int profile;
> >  uint8_t interlaced;
> > +int long_gop;
>
> A comment here explaining the difference between -1, 0 and 1 would be
> nice. The rest looks OK, but I didn't read the relevant specs to be
> 100% sure
> 
>

New patch attached.

Regards,
Thomas


0001-avformat-mxfenc-add-h264-profiles.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel