Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables
On 05-07-2019 10:15 AM, Gyan wrote: On 05-07-2019 07:32 AM, greg Luce wrote: If the joined version is preferred it's been submitted at http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245662.html Pinging. Would it be possible to get one of these two versions applied, if no other changes are required? Will test and apply. Updated version bump and applied as 2bd21b96096320bc12532119a6b0f7a974db6c19 Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables
On 05-07-2019 07:32 AM, greg Luce wrote: If the joined version is preferred it's been submitted at http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245662.html Pinging. Would it be possible to get one of these two versions applied, if no other changes are required? Will test and apply. Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables
> If the joined version is preferred it's been submitted at > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245662.html Pinging. Would it be possible to get one of these two versions applied, if no other changes are required? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables
Hello, Just wondering if there’s anything else I should do to get this in Thanks! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables
> These were two different and independent patches written by two different > persons. I'm totally fine with them going in either way, but just to clarify the 0002 file was written as a companion to update the documentation to go along with 0001, it isn't meant to exist on its own. I can't speak to what the proper method is If the joined version is preferred it's been submitted at http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245662.html ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables
On Fri, Jun 21, 2019 at 02:53:09PM +0200, Nicolas George wrote: > greg Luce (12019-06-21): > > I had them in a single patch before but split them as requested here > > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html > > Is there something I'm missing that allows me to split the patch but > > have the code and doc in the same patch? > > Asking you to split was, I think, a mistake: a new feature and its > documentation belong in the same commit, even if they were written by > different persons. > > Just make sure the commit message states authorship accurately. iam also ok with seperate patches if that is preferred, i did not realize/remember that the docs and code were from 2 different people [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. -- Voltaire signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables
> Am 21.06.2019 um 14:53 schrieb Nicolas George : > > greg Luce (12019-06-21): >> I had them in a single patch before but split them as requested here >> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html >> Is there something I'm missing that allows me to split the patch but >> have the code and doc in the same patch? > > Asking you to split was, I think, a mistake: a new feature and its > documentation belong in the same commit, even if they were written by > different persons. These were two different and independent patches written by two different persons. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables
Thanks will resubmit that way On Fri, 21 Jun 2019 at 08:53, Nicolas George wrote: > > greg Luce (12019-06-21): > > I had them in a single patch before but split them as requested here > > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html > > Is there something I'm missing that allows me to split the patch but > > have the code and doc in the same patch? > > Asking you to split was, I think, a mistake: a new feature and its > documentation belong in the same commit, even if they were written by > different persons. > > Just make sure the commit message states authorship accurately. > > Regards, > > -- > Nicolas George > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables
greg Luce (12019-06-21): > I had them in a single patch before but split them as requested here > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html > Is there something I'm missing that allows me to split the patch but > have the code and doc in the same patch? Asking you to split was, I think, a mistake: a new feature and its documentation belong in the same commit, even if they were written by different persons. Just make sure the commit message states authorship accurately. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables
> code changes should be ok > the doc and code belong in the same patch/commit though I had them in a single patch before but split them as requested here http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html Is there something I'm missing that allows me to split the patch but have the code and doc in the same patch? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables
On Thu, Jun 20, 2019 at 12:06:38PM -0400, greg Luce wrote: > Info at https://trac.ffmpeg.org/ticket/7947 > C code in file 0001, documentation and version tick in file 0002 > Documentation written with help from Gyan and Moritz Barsnick > Documentation patch has info in what I hope is the commit message > vf_drawtext.c |9 + > 1 file changed, 9 insertions(+) > 3b8f4ca7b73192f2cafd1c563ab1b5c064de678b > 0001-vf_drawtext-Add-pkt_pos-pkt_duration-pkt_size-as-var.patch > From b4b119d490d98c713ebb8a2288a2e2e3017e56ea Mon Sep 17 00:00:00 2001 > From: Calvin Walton > Date: Fri, 7 Jun 2019 15:06:36 -0400 > Subject: [PATCH] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables > > --- > libavfilter/vf_drawtext.c | 9 + > 1 file changed, 9 insertions(+) code changes should be ok the doc and code belong in the same patch/commit though thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The smallest minority on earth is the individual. Those who deny individual rights cannot claim to be defenders of minorities. - Ayn Rand signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
