Re: [FFmpeg-devel] [PATCH v7] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720
On 02-05-2019 16:16, Moritz Barsnick wrote: > On Thu, May 02, 2019 at 10:33:41 +0530, shi...@iitk.ac.in wrote: > > A minor nitpick (which the person pushing will/should notice): > >> #define LIBAVFORMAT_VERSION_MAJOR 58 >> -#define LIBAVFORMAT_VERSION_MINOR 27 >> +#define LIBAVFORMAT_VERSION_MINOR 28 >> #define LIBAVFORMAT_VERSION_MICRO 103 > > When bumping MINOR, you need to reset MICRO to 100. Would reset it to 100. Sending another patch with the documentation too. Thank you Shivam Goyal ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v7] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720
On Thu, May 02, 2019 at 10:33:41 +0530, shi...@iitk.ac.in wrote: A minor nitpick (which the person pushing will/should notice): > #define LIBAVFORMAT_VERSION_MAJOR 58 > -#define LIBAVFORMAT_VERSION_MINOR 27 > +#define LIBAVFORMAT_VERSION_MINOR 28 > #define LIBAVFORMAT_VERSION_MICRO 103 When bumping MINOR, you need to reset MICRO to 100. Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v7] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720
On 2019-05-02 11:22, Gyan wrote: > On 02-05-2019 10:33 AM, shi...@iitk.ac.in wrote: > >> lavf/flv: Add XV (Xunlei Video) Support. >> The patch fixes ticket #3720. >> It would just skip the first packet, which stores the decrypted data and >> moves on the next packet. >> Also, Thank you Moritz Barsnick for commenting this on >> the ticket. It really helped me. >> >> I would also add the documentation for this once the patch is applied. > Better to submit the doc patch now so it can be reviewed. > > Gyan Ok, I am writing it. Thank You Shivam Goyal ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v7] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720
On 02-05-2019 10:33 AM, shi...@iitk.ac.in wrote: lavf/flv: Add XV (Xunlei Video) Support. The patch fixes ticket #3720. It would just skip the first packet, which stores the decrypted data and moves on the next packet. Also, Thank you Moritz Barsnick for commenting this on the ticket. It really helped me. I would also add the documentation for this once the patch is applied. Better to submit the doc patch now so it can be reviewed. Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
