Re: [FFmpeg-devel] Comments about patch
On Wed, Dec 23, 2015 at 11:54:28AM +0100, Mats Peterson wrote: > Clement, can you please repeat what you said. I don't know where the hell > your post went. > http://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/185664.html -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Comments about patch
On 12/23/2015 11:55 AM, Clément Bœsch wrote: On Wed, Dec 23, 2015 at 11:54:28AM +0100, Mats Peterson wrote: Clement, can you please repeat what you said. I don't know where the hell your post went. http://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/185664.html ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel OK. Regarding being the sole author, well I'm the one who has made the patch. I don't understand what you mean. Regarding using ff_alloc_extradata(), it's not done at every place in that file, that's why I thought it would be OK to use the "normal" av_malloc(). I don't know what you mean by "a << 24" is undefined if a msb is set. I'm doing exactly as it was done in mov.c before. "Usually you have 0 for success", well in this case it's not about success, I use "1" for having a palette, "0" for not having one. Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Comments about patch
On Wed, Dec 23, 2015 at 12:04:15PM +0100, Mats Peterson wrote: [...] > OK. Regarding being the sole author, well I'm the one who has made the > patch. I don't understand what you mean. > It was a real question; I remember Martin being mentioned in the ticket, and Carl Eugen working on a patch. Maybe some other people were involved, so I was just making sure credits were properly attributed if necessary. [...] -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Comments about patch
On Wed, Dec 23, 2015 at 12:04:15PM +0100, Mats Peterson wrote: [...] > I don't know what you mean by "a << 24" is undefined if a msb is set. I'm > doing exactly as it was done in mov.c before. my bad, didn't see a was unsigned, you can ignore. [...] -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Comments about patch
On 12/23/2015 12:09 PM, Clément Bœsch wrote: On Wed, Dec 23, 2015 at 12:04:15PM +0100, Mats Peterson wrote: [...] OK. Regarding being the sole author, well I'm the one who has made the patch. I don't understand what you mean. It was a real question; I remember Martin being mentioned in the ticket, and Carl Eugen working on a patch. Maybe some other people were involved, so I was just making sure credits were properly attributed if necessary. [...] ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Yes, I know they have been involved in the initial attempts, but the majority of changes after that are made by me. I'm not trying to grab the honor whatsoever. Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Comments about patch
On 12/23/2015 12:13 PM, Clément Bœsch wrote: On Wed, Dec 23, 2015 at 12:04:15PM +0100, Mats Peterson wrote: [...] I don't know what you mean by "a << 24" is undefined if a msb is set. I'm doing exactly as it was done in mov.c before. my bad, didn't see a was unsigned, you can ignore. [...] ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel I guess so ;) I'm changing the other stuff you were complaining at here though. Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
