Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On May 9, 2016, at 7:55 AM, Amancio Hasty <aha...@gmail.com> wrote:
> 
> Hi,
> 
> So what is the next step?
> 
> If you want testers I suggest posting to ccrisan’s motionpie mailing list.
> Cheers
> Amancio
> 
> 
>> On Mar 31, 2016, at 7:27 PM, Amancio Hasty <aha...@gmail.com> wrote:
>> 
>> I am not a lawyer…
>> 
>> 
>> I updated the patch.  vc264.c now has a the copyright notice embedded in 
>> a volatile global so if a binary is compiled against vc264.o , the copyright 
>> notice
>> can be displayed by:
>> strings ffmpeg | grep -i copyright
>> 
>> LICENSE.md has been updated to include Broadcom’s copyright notice.
>> 
>> A distribution of a  binary that includes vc264.o should include LICENSE.md 
>> and if 
>> that is missing,  the copyright notice can be displayed via the shell
>> command ‘strings’ .
>> 
>> Amancio
>> 
>>> On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:
>>> 
>>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>>> 
>>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>>> From: Amancio Hasty <aha...@gmail.com>
>>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>>>> the Raspberry Pi
>>>> 
>>>> ---
>>>> configure  |  12 ++
>>>> libavcodec/Makefile|   1 +
>>>> libavcodec/allcodecs.c |   2 +
>>>> libavcodec/vc264.c | 387 
>>>> +
>>>> 4 files changed, 402 insertions(+)
>>>> create mode 100644 libavcodec/vc264.c
>>>> 
>>> [...]
>>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>>> index 2a25d66..3c7bd9b 100644
>>>> --- a/libavcodec/allcodecs.c
>>>> +++ b/libavcodec/allcodecs.c
>>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>>   initialized = 1;
>>>> 
>>> 
>>> Nit: Whitespace on the line above should be removed.
>>> 
>>> [...]
>>>> --- /dev/null
>>>> +++ b/libavcodec/vc264.c
>>>> @@ -0,0 +1,387 @@
>>>> +/*  H.264 hardware assist video encoding code taken from
>>>> + * raspberry's os :
>>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>>> + */
>>>> +
>>>> +/*
>>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>>> +Copyright (c) 2012, Kalle Vahlman <zuh@iki>
>>>> +Tuomas Kulve <tuo...@kulve.fi>
>>>> +All rights reserved.
>>>> +
>>>> +Redistribution and use in source and binary forms, with or without
>>>> +modification, are permitted provided that the following conditions are 
>>>> met:
>>>> +* Redistributions of source code must retain the above copyright
>>>> +  notice, this list of conditions and the following disclaimer.
>>>> +  * Redistributions in binary form must reproduce the above copyright
>>>> +  notice, this list of conditions and the following disclaimer in the
>>>> +  documentation and/or other materials provided with the distribution.
>>>> +  * Neither the name of the copyright holder nor the
>>>> +  names of its contributors may be used to endorse or promote products
>>>> +  derived from this software without specific prior written 
>>>> permission.
>>>> +
>>>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>>>> IS" AND
>>>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>>>> IMPLIED
>>>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>>>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>>>> LIABLE FOR ANY
>>>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>>>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
>>>> SERVICES;
>>>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED 
>>>> AND
>>>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>>>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>>>> THIS
>>>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIB

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Jun 22, 2016, at 10:20 AM, Aman Gupta <ffm...@tmm1.net> wrote:
> 
> This patch should fix the assertion failure you see:
> https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4
>  
> <https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4>
> 
> Aman
> On Sat, Jun 18, 2016 at 8:43 AM Amancio Hasty <aha...@gmail.com 
> <mailto:aha...@gmail.com>> wrote:
> 
>> 
>>> On Jun 16, 2016, at 11:16 AM, Aman Gupta <ffm...@tmm1.net> wrote:
>>> 
>>> The patchset that was merged into libav is now available in ffmpeg as
>> well:
>>> https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/omx.c
>>> 
>>> You can compile ffmpeg from the master branch
>>> with --enable-omx --enable-omx-rpi
>>> 
>>> Aman
>>> 
>>> On Thu, Jun 16, 2016 at 2:16 AM, Amancio Hasty <aha...@gmail.com> wrote:
>>> 
>>>> 
>>>>> On May 9, 2016, at 7:55 AM, Amancio Hasty <aha...@gmail.com> wrote:
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> So what is the next step?
>>>>> 
>>>>> If you want testers I suggest posting to ccrisan’s motionpie mailing
>>>> list.
>>>>> Cheers
>>>>> Amancio
>>>>> 
>>>>> 
>>>>>> On Mar 31, 2016, at 7:27 PM, Amancio Hasty <aha...@gmail.com> wrote:
>>>>>> 
>>>>>> I am not a lawyer…
>>>>>> 
>>>>>> 
>>>>>> I updated the patch.  vc264.c now has a the copyright notice embedded
>> in
>>>>>> a volatile global so if a binary is compiled against vc264.o , the
>>>> copyright notice
>>>>>> can be displayed by:
>>>>>> strings ffmpeg | grep -i copyright
>>>>>> 
>>>>>> LICENSE.md has been updated to include Broadcom’s copyright notice.
>>>>>> 
>>>>>> A distribution of a  binary that includes vc264.o should include
>>>> LICENSE.md and if
>>>>>> that is missing,  the copyright notice can be displayed via the shell
>>>>>> command ‘strings’ .
>>>>>> 
>>>>>> Amancio
>>>>>> 
>>>>>>> On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:
>>>>>>> 
>>>>>>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>>>>>>> 
>>>>>>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00
>> 2001
>>>>>>>> From: Amancio Hasty <aha...@gmail.com>
>>>>>>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>>>>>>> Subject: [PATCH] added support for hardware assist H264  video
>>>> encoding for
>>>>>>>> the Raspberry Pi
>>>>>>>> 
>>>>>>>> ---
>>>>>>>> configure  |  12 ++
>>>>>>>> libavcodec/Makefile|   1 +
>>>>>>>> libavcodec/allcodecs.c |   2 +
>>>>>>>> libavcodec/vc264.c | 387
>>>> +
>>>>>>>> 4 files changed, 402 insertions(+)
>>>>>>>> create mode 100644 libavcodec/vc264.c
>>>>>>>> 
>>>>>>> [...]
>>>>>>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>>>>>>> index 2a25d66..3c7bd9b 100644
>>>>>>>> --- a/libavcodec/allcodecs.c
>>>>>>>> +++ b/libavcodec/allcodecs.c
>>>>>>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>>>>>> initialized = 1;
>>>>>>>> 
>>>>>>> 
>>>>>>> Nit: Whitespace on the line above should be removed.
>>>>>>> 
>>>>>>> [...]
>>>>>>>> --- /dev/null
>>>>>>>> +++ b/libavcodec/vc264.c
>>>>>>>> @@ -0,0 +1,387 @@
>>>>>>>> +/*  H.264 hardware assist video encoding code taken from
>>>>>>>> + * raspberry's os :
>>>>>>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>>>>>>> + */
>>>>>>>> +
>>>>>>>> +/*
>>>>>>>> +Copyright

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Jun 16, 2016, at 11:16 AM, Aman Gupta <ffm...@tmm1.net> wrote:
> 
> The patchset that was merged into libav is now available in ffmpeg as well:
> https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/omx.c
> 
> You can compile ffmpeg from the master branch
> with --enable-omx --enable-omx-rpi
> 
> Aman
> 
> On Thu, Jun 16, 2016 at 2:16 AM, Amancio Hasty <aha...@gmail.com> wrote:
> 
>> 
>>> On May 9, 2016, at 7:55 AM, Amancio Hasty <aha...@gmail.com> wrote:
>>> 
>>> Hi,
>>> 
>>> So what is the next step?
>>> 
>>> If you want testers I suggest posting to ccrisan’s motionpie mailing
>> list.
>>> Cheers
>>> Amancio
>>> 
>>> 
>>>> On Mar 31, 2016, at 7:27 PM, Amancio Hasty <aha...@gmail.com> wrote:
>>>> 
>>>> I am not a lawyer…
>>>> 
>>>> 
>>>> I updated the patch.  vc264.c now has a the copyright notice embedded in
>>>> a volatile global so if a binary is compiled against vc264.o , the
>> copyright notice
>>>> can be displayed by:
>>>> strings ffmpeg | grep -i copyright
>>>> 
>>>> LICENSE.md has been updated to include Broadcom’s copyright notice.
>>>> 
>>>> A distribution of a  binary that includes vc264.o should include
>> LICENSE.md and if
>>>> that is missing,  the copyright notice can be displayed via the shell
>>>> command ‘strings’ .
>>>> 
>>>> Amancio
>>>> 
>>>>> On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:
>>>>> 
>>>>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>>>>> 
>>>>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>>>>> From: Amancio Hasty <aha...@gmail.com>
>>>>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>>>>> Subject: [PATCH] added support for hardware assist H264  video
>> encoding for
>>>>>> the Raspberry Pi
>>>>>> 
>>>>>> ---
>>>>>> configure  |  12 ++
>>>>>> libavcodec/Makefile|   1 +
>>>>>> libavcodec/allcodecs.c |   2 +
>>>>>> libavcodec/vc264.c | 387
>> +
>>>>>> 4 files changed, 402 insertions(+)
>>>>>> create mode 100644 libavcodec/vc264.c
>>>>>> 
>>>>> [...]
>>>>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>>>>> index 2a25d66..3c7bd9b 100644
>>>>>> --- a/libavcodec/allcodecs.c
>>>>>> +++ b/libavcodec/allcodecs.c
>>>>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>>>>  initialized = 1;
>>>>>> 
>>>>> 
>>>>> Nit: Whitespace on the line above should be removed.
>>>>> 
>>>>> [...]
>>>>>> --- /dev/null
>>>>>> +++ b/libavcodec/vc264.c
>>>>>> @@ -0,0 +1,387 @@
>>>>>> +/*  H.264 hardware assist video encoding code taken from
>>>>>> + * raspberry's os :
>>>>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>>>>> + */
>>>>>> +
>>>>>> +/*
>>>>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>>>>> +Copyright (c) 2012, Kalle Vahlman <zuh@iki>
>>>>>> +Tuomas Kulve <tuo...@kulve.fi>
>>>>>> +All rights reserved.
>>>>>> +
>>>>>> +Redistribution and use in source and binary forms, with or without
>>>>>> +modification, are permitted provided that the following conditions
>> are met:
>>>>>> +* Redistributions of source code must retain the above copyright
>>>>>> +  notice, this list of conditions and the following disclaimer.
>>>>>> +  * Redistributions in binary form must reproduce the above
>> copyright
>>>>>> +  notice, this list of conditions and the following disclaimer
>> in the
>>>>>> +  documentation and/or other materials provided with the
>> distribution.
>>>>>> +  * Neither the name of the copyright holder nor the
>>>>>> +  names of its contributors may be used to endorse or promote
>> products
>>>>>> +  de

Re: [FFmpeg-devel] release/3.1

[Amancio Hasty]

This is the commit that introduced the functionality:
f1cd9b03f3fa875eb5e394281b4b688cec611658

Amancio





On June 27, 2016 at 5:35:33 AM, Carl Eugen Hoyos (ceho...@ag.or.at) wrote:

Amancio Hasty  gmail.com> writes:

> You can close ticket #3518 which states that ffmpeg does not
> support RPI’s hardware h264 encoding.

Which commit fixed #3518?

Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] FFmpeg 3.1 name

[Amancio Hasty]

On June 25, 2016 at 12:42:52 PM, Michael Niedermayer (mich...@niedermayer.cc)
wrote:

On Sat, Jun 25, 2016 at 07:21:15PM +0200, Jan Gerber wrote:
> On 06/25/2016 06:50 PM, Michael Niedermayer wrote:
> >> git cherry-pick 1087f0dc172a9adf779e41bf2dc82639fb04ebd4
> >
> > is this or 0c9c4004ed57de210b4d83c7b39bbfb00b86b9af preferred ?
>
> both are ok, would use 0c9c4004ed57de210b4d83c7b39bbfb00b86b9af
> to keep the delta to libav smaller.

ok applied

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


The latest patch appears to work on my RPI3:

./ffmpeg  -f v4l2 -input_format yuv420p -framerate 25 -video_size 640x480
-i /dev/video0  -frames 500 -an   -c:v h264_omx test.mp4

Amancio
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

On June 22, 2016 at 12:12:02 PM, Amancio Hasty (aha...@gmail.com) wrote:


On Jun 22, 2016, at 10:20 AM, Aman Gupta <ffm...@tmm1.net> wrote:

This patch should fix the assertion failure you see:
https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4

Aman
On Sat, Jun 18, 2016 at 8:43 AM Amancio Hasty <aha...@gmail.com> wrote:


On Jun 16, 2016, at 11:16 AM, Aman Gupta <ffm...@tmm1.net> wrote:

The patchset that was merged into libav is now available in ffmpeg as

well:

https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/omx.c

You can compile ffmpeg from the master branch
with --enable-omx --enable-omx-rpi

Aman

On Thu, Jun 16, 2016 at 2:16 AM, Amancio Hasty <aha...@gmail.com> wrote:


On May 9, 2016, at 7:55 AM, Amancio Hasty <aha...@gmail.com> wrote:

Hi,

So what is the next step?

If you want testers I suggest posting to ccrisan’s motionpie mailing

list.

Cheers
Amancio


On Mar 31, 2016, at 7:27 PM, Amancio Hasty <aha...@gmail.com> wrote:

I am not a lawyer…


I updated the patch.  vc264.c now has a the copyright notice embedded

in

a volatile global so if a binary is compiled against vc264.o , the

copyright notice

can be displayed by:
strings ffmpeg | grep -i copyright

LICENSE.md has been updated to include Broadcom’s copyright notice.

A distribution of a  binary that includes vc264.o should include

LICENSE.md and if

that is missing,  the copyright notice can be displayed via the shell
command ‘strings’ .

Amancio


On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:

On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:

From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00

2001

From: Amancio Hasty <aha...@gmail.com>
Date: Mon, 21 Mar 2016 18:56:05 -0700
Subject: [PATCH] added support for hardware assist H264  video

encoding for

the Raspberry Pi

---
configure  |  12 ++
libavcodec/Makefile|   1 +
libavcodec/allcodecs.c |   2 +
libavcodec/vc264.c | 387

+

4 files changed, 402 insertions(+)
create mode 100644 libavcodec/vc264.c

[...]

diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
index 2a25d66..3c7bd9b 100644
--- a/libavcodec/allcodecs.c
+++ b/libavcodec/allcodecs.c
@@ -74,6 +74,7 @@ void avcodec_register_all(void)
initialized = 1;


Nit: Whitespace on the line above should be removed.

[...]

--- /dev/null
+++ b/libavcodec/vc264.c
@@ -0,0 +1,387 @@
+/*  H.264 hardware assist video encoding code taken from
+ * raspberry's os :
+ *   /opt/vc/src/hello_pi/hello_encode/encode.c
+ */
+
+/*
+Copyright (c) 2012, Broadcom Europe Ltd
+Copyright (c) 2012, Kalle Vahlman <zuh@iki>
+Tuomas Kulve <tuo...@kulve.fi>
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions

are met:

+* Redistributions of source code must retain the above copyright
+  notice, this list of conditions and the following disclaimer.
+  * Redistributions in binary form must reproduce the above

copyright

+  notice, this list of conditions and the following disclaimer

in the

+  documentation and/or other materials provided with the

distribution.

+  * Neither the name of the copyright holder nor the
+  names of its contributors may be used to endorse or promote

products

+  derived from this software without specific prior written

permission.

+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS

"AS IS" AND

+ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,

THE IMPLIED

+WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE

ARE

+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS

BE LIABLE FOR ANY

+DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL

DAMAGES

+(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR

SERVICES;

+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER

CAUSED AND

+ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,

OR TORT

+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE

USE OF THIS

+SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.


I wonder if any of the above legalese is compatible. Granted, I see a
similar paragraph in "libavformat/aadec.c".

+ * ffmpeg driver for hardware assist video H.264 encoding using

Broadcom's GPU

+ * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
+ *
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later

version.

+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT A

Re: [FFmpeg-devel] FFmpeg 3.1 name

[Amancio Hasty]

> On Jun 24, 2016, at 7:39 PM, Michael Niedermayer <mich...@niedermayer.cc> 
> wrote:
> 
> On Fri, Jun 24, 2016 at 06:52:01PM -0700, Amancio Hasty wrote:
>> 
>>> On Jun 24, 2016, at 6:31 PM, Michael Niedermayer <mich...@niedermayer.cc> 
>>> wrote:
>>> 
>>> On Thu, Jun 23, 2016 at 11:00:48PM +0200, Michael Niedermayer wrote:
>>>> Hi all
>>>> 
>>>> what shall FFmpeg 3.1 be called ?
>>>> 
>>>> I still have these ideas from past suggestions:
>>>> Von Neumann, Einstein, lorentz, poincaré, desitter, de broglie, Gauss, 
>>>> Galois, Viterbi, Darwin
>>>> 
>>>> Are there other suggestions?
>>>> Is something preferred ?
>>>> 
>>>> In absence of any preferrance ill pick something randomly
>>> 
>>> Laplace (Rostislav, Bodecs)
>>> Carl (Paul)
>>> Lorentz (Bodecs)
>>> fibonacci (Compn)
>>> [list of people from june] (Gregory)
>>> Hypatia (Kyle)
>>> 
>>> Laplace got suggested twice, everything else once
>>> Thus the winner is Laplace
>>> 
>>> i intend to make the release tomorrow (saturday) from what is in git
>>> master unless people want me to wait ?
>>> 
>>> [...]
>>> 
>>> -- 
>>> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>> 
>>> Those who would give up essential Liberty, to purchase a little
>>> temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin
>>> ___
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> Can we till Aman finishes his omx/h264 encoding?
>> 
>> Again lots of people in the RPI commute are waiting for this and
>> it looks like the finishing touch does not required much work…
> 
> we are 1 month behind shedule
> we make releases once about every 3 months
> 
> There is always a feature that will be finished next week or next
> 3 days. If you always wait you never release.
> 
> Also you didnt mention any timeframe for when this will be in git
> master
> 
> do you think its really better if we delay the release and maybe in
> 2 weeks have 5 new regressions that rewuire us to wait another
> month to get them fixed and then theres anoter big feature that comes
> the week after it and so on.
> IMHO better release now, and release soon again.
> 
> [...]
> -- 
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Dictatorship: All citizens are under surveillance, all their steps and
> actions recorded, for the politicians to enforce control.
> Democracy: All politicians are under surveillance, all their steps and
> actions recorded, for the citizens to enforce control.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel 
> <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>
It really depends on your intent and what do you wish to provide with
your release. We will have to wait till Aman tells us what is his next step.

With respect to RPI it has been over 2 years people have been waiting
for hardware assist h264 encoding…

Cheers
Amancio


___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] FFmpeg 3.1 name

[Amancio Hasty]

> On Jun 24, 2016, at 6:31 PM, Michael Niedermayer  
> wrote:
> 
> On Thu, Jun 23, 2016 at 11:00:48PM +0200, Michael Niedermayer wrote:
>> Hi all
>> 
>> what shall FFmpeg 3.1 be called ?
>> 
>> I still have these ideas from past suggestions:
>> Von Neumann, Einstein, lorentz, poincaré, desitter, de broglie, Gauss, 
>> Galois, Viterbi, Darwin
>> 
>> Are there other suggestions?
>> Is something preferred ?
>> 
>> In absence of any preferrance ill pick something randomly
> 
> Laplace (Rostislav, Bodecs)
> Carl (Paul)
> Lorentz (Bodecs)
> fibonacci (Compn)
> [list of people from june] (Gregory)
> Hypatia (Kyle)
> 
> Laplace got suggested twice, everything else once
> Thus the winner is Laplace
> 
> i intend to make the release tomorrow (saturday) from what is in git
> master unless people want me to wait ?
> 
> [...]
> 
> -- 
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Those who would give up essential Liberty, to purchase a little
> temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Can we till Aman finishes his omx/h264 encoding?

Again lots of people in the RPI commute are waiting for this and
it looks like the finishing touch does not required much work…


Amancio

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] FFmpeg 3.1 name

[Amancio Hasty]

> On Jun 25, 2016, at 5:41 AM, Jan Gerber  wrote:
> 
> On 06/25/2016 11:17 AM, Michael Niedermayer wrote:
>>> where is that patch ?
>>> i see
>>> " --enable-omx-rpi enable encoding via OpenMAX IL for Raspberry Pi 
>>> [no]"
>>> in ffmpeg git, what is missing?
>> 
>> looking at tmm1/rebase-omx i only see 2 one line patches that we
>> dont have yet
>> i can certainly merge them before the release if thats all (but i have
>> no RPI so i cannot test)
>> 
>> is that all that is needed ? something else
>> missing that we should wait for ?
> 
> I can confirm that with those 2 commits -v:c h264_omx works on my Raspberry 
> Pi,
> while it fails without them.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel 
> 

Most cool. Can you post the exact command line that you used to 
test h264_omx?

Thanks!


___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] FFmpeg 3.1 name

[Amancio Hasty]

> On Jun 25, 2016, at 6:53 AM, Hendrik Leppkes <h.lepp...@gmail.com> wrote:
> 
> On Sat, Jun 25, 2016 at 3:02 PM, Jan Gerber <j...@v2v.cc> wrote:
>> On 06/25/2016 02:45 PM, Amancio Hasty wrote:
>>> Most cool. Can you post the exact command line that you used to
>>> test h264_omx?
>> 
>> git remote add tmm1 https://github.com/tmm1/FFmpeg
>> git fetch tmmi1
>> git checkout -b omx
>> git cherry-pick 2a1fcc3775a390570679da7f507539a397fc7130
>> git cherry-pick 1087f0dc172a9adf779e41bf2dc82639fb04ebd4
>> 
> 
> The first is only of a cosmetic nature and probably not required, the
> second is also slated to be merged from libav eventually:
> http://git.libav.org/?p=libav.git;a=commit;h=0c9c4004ed57de210b4d83c7b39bbfb00b86b9af
> 
> - Hendrik
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Just cloned  the latest ffmpeg and added Aman’s last patch.

git clone https://git.ffmpeg.org/ffmpeg.git ffmpeg

https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4
 
<https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4>

./configure --enable-mmal --enable-omx-rpi --enable-omx
make -j4


./ffmpeg  -f v4l2 -input_format yuv420p -framerate 25 -video_size 640x480 -i 
/dev/video0 -an   -c:v h264_omx test.mp4
I am getting:
DTS 140462626040094, next:1540 st:0 invalid dropping
PTS 140462626040094, next:1540 invalid dropping st:0
DTS 140462626080073, next:1544 st:0 invalid dropping
PTS 140462626080073, next:1544 invalid dropping st:0
…
The video seems to play okay on my macbook .

As far I am concerned , the warnings from ffmpeg are the last issue.


Amancio




___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

The patch was against:
2016-02-26-raspbian-jessie.img

In my Raspberry Pi  system:
/opt/vc/include/bcm_host.h

in ffmpeg/configure:
 if enabled vc264_encoder &&  [ -n "$target_os_default"="linux" ] ; then
add_cflags ' -I/opt/vc/include/… 
———

Amancio


> On Mar 18, 2016, at 11:50 AM, Lou Logan <l...@lrcd.com> wrote:
> 
> On Fri, 18 Mar 2016 11:13:58 -0700, Amancio Hasty wrote:
> 
>> From be5f142f820e05b411bfdc95719e0ab6388bcbe5 Mon Sep 17 00:00:00 2001
>> From: Amancio Hasty <aha...@gmail.com>
>> Date: Fri, 18 Mar 2016 10:00:14 -0700
>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>> the Raspberry Pi
>> 
>> ---
>> configure  |   4 +
>> libavcodec/Makefile|   1 +
>> libavcodec/allcodecs.c |   1 +
>> libavcodec/vc264.c | 387 
>> +
>> 4 files changed, 393 insertions(+)
>> create mode 100644 libavcodec/vc264.c
> 
> Tabs and trailing whitespaces should be avoided.
> 
> Fails to compile:
> 
> libavcodec/vc264.c:70:22: fatal error: bcm_host.h: No such file or
> directory compilation terminated.
> common.mak:60: recipe for target 'libavcodec/vc264.o' failed
> make: *** [libavcodec/vc264.o] Error 1
> make: *** Waiting for unfinished jobs

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Mar 31, 2016, at 7:27 PM, Amancio Hasty <aha...@gmail.com> wrote:
> 
> I am not a lawyer…
> 
> 
> I updated the patch.  vc264.c now has a the copyright notice embedded in 
> a volatile global so if a binary is compiled against vc264.o , the copyright 
> notice
> can be displayed by:
> strings ffmpeg | grep -i copyright
> 
> LICENSE.md has been updated to include Broadcom’s copyright notice.
> 
> A distribution of a  binary that includes vc264.o should include LICENSE.md 
> and if 
> that is missing,  the copyright notice can be displayed via the shell
> command ‘strings’ .
> 
> Amancio
> 
>> On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:
>> 
>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>> 
>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>> From: Amancio Hasty <aha...@gmail.com>
>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>>> the Raspberry Pi
>>> 
>>> ---
>>> configure  |  12 ++
>>> libavcodec/Makefile|   1 +
>>> libavcodec/allcodecs.c |   2 +
>>> libavcodec/vc264.c | 387 
>>> +
>>> 4 files changed, 402 insertions(+)
>>> create mode 100644 libavcodec/vc264.c
>>> 
>> [...]
>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>> index 2a25d66..3c7bd9b 100644
>>> --- a/libavcodec/allcodecs.c
>>> +++ b/libavcodec/allcodecs.c
>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>initialized = 1;
>>> 
>> 
>> Nit: Whitespace on the line above should be removed.
>> 
>> [...]
>>> --- /dev/null
>>> +++ b/libavcodec/vc264.c
>>> @@ -0,0 +1,387 @@
>>> +/*  H.264 hardware assist video encoding code taken from
>>> + * raspberry's os :
>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>> + */
>>> +
>>> +/*
>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>> +Copyright (c) 2012, Kalle Vahlman <zuh@iki>
>>> +Tuomas Kulve <tuo...@kulve.fi>
>>> +All rights reserved.
>>> +
>>> +Redistribution and use in source and binary forms, with or without
>>> +modification, are permitted provided that the following conditions are met:
>>> +* Redistributions of source code must retain the above copyright
>>> +  notice, this list of conditions and the following disclaimer.
>>> +  * Redistributions in binary form must reproduce the above copyright
>>> +  notice, this list of conditions and the following disclaimer in the
>>> +  documentation and/or other materials provided with the distribution.
>>> +  * Neither the name of the copyright holder nor the
>>> +  names of its contributors may be used to endorse or promote products
>>> +  derived from this software without specific prior written permission.
>>> +
>>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>>> IS" AND
>>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>>> IMPLIED
>>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>>> LIABLE FOR ANY
>>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
>>> SERVICES;
>>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>>> THIS
>>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>> 
>> I wonder if any of the above legalese is compatible. Granted, I see a
>> similar paragraph in "libavformat/aadec.c".
>> 
>>> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
>>> GPU
>>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>>> + *
>>> + *
>>> + * This file is part of FFmpeg.
>>> + *
>>> + * FFmpeg is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU Lesser General Public
>>> + * License as published by the Free Software Foundation; eit

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Mar 31, 2016, at 7:27 PM, Amancio Hasty <aha...@gmail.com> wrote:
> 
> I am not a lawyer…
> 
> 
> I updated the patch.  vc264.c now has a the copyright notice embedded in 
> a volatile global so if a binary is compiled against vc264.o , the copyright 
> notice
> can be displayed by:
> strings ffmpeg | grep -i copyright
> 
> LICENSE.md has been updated to include Broadcom’s copyright notice.
> 
> A distribution of a  binary that includes vc264.o should include LICENSE.md 
> and if 
> that is missing,  the copyright notice can be displayed via the shell
> command ‘strings’ .
> 
> Amancio
> 
>> On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:
>> 
>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>> 
>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>> From: Amancio Hasty <aha...@gmail.com>
>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>>> the Raspberry Pi
>>> 
>>> ---
>>> configure  |  12 ++
>>> libavcodec/Makefile|   1 +
>>> libavcodec/allcodecs.c |   2 +
>>> libavcodec/vc264.c | 387 
>>> +
>>> 4 files changed, 402 insertions(+)
>>> create mode 100644 libavcodec/vc264.c
>>> 
>> [...]
>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>> index 2a25d66..3c7bd9b 100644
>>> --- a/libavcodec/allcodecs.c
>>> +++ b/libavcodec/allcodecs.c
>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>initialized = 1;
>>> 
>> 
>> Nit: Whitespace on the line above should be removed.
>> 
>> [...]
>>> --- /dev/null
>>> +++ b/libavcodec/vc264.c
>>> @@ -0,0 +1,387 @@
>>> +/*  H.264 hardware assist video encoding code taken from
>>> + * raspberry's os :
>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>> + */
>>> +
>>> +/*
>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>> +Copyright (c) 2012, Kalle Vahlman <zuh@iki>
>>> +Tuomas Kulve <tuo...@kulve.fi>
>>> +All rights reserved.
>>> +
>>> +Redistribution and use in source and binary forms, with or without
>>> +modification, are permitted provided that the following conditions are met:
>>> +* Redistributions of source code must retain the above copyright
>>> +  notice, this list of conditions and the following disclaimer.
>>> +  * Redistributions in binary form must reproduce the above copyright
>>> +  notice, this list of conditions and the following disclaimer in the
>>> +  documentation and/or other materials provided with the distribution.
>>> +  * Neither the name of the copyright holder nor the
>>> +  names of its contributors may be used to endorse or promote products
>>> +  derived from this software without specific prior written permission.
>>> +
>>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>>> IS" AND
>>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>>> IMPLIED
>>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>>> LIABLE FOR ANY
>>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
>>> SERVICES;
>>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>>> THIS
>>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>> 
>> I wonder if any of the above legalese is compatible. Granted, I see a
>> similar paragraph in "libavformat/aadec.c".
>> 
>>> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
>>> GPU
>>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>>> + *
>>> + *
>>> + * This file is part of FFmpeg.
>>> + *
>>> + * FFmpeg is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU Lesser General Public
>>> + * License as published by the Free Software Foundation; eit

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Apr 6, 2016, at 1:29 AM, wm4 <nfx...@googlemail.com> wrote:
> 
> On Tue, 5 Apr 2016 16:09:42 -0700
> Amancio Hasty <aha...@gmail.com <mailto:aha...@gmail.com>> wrote:
> 
>>> On Apr 5, 2016, at 3:57 PM, Michael Niedermayer <mich...@niedermayer.cc> 
>>> wrote:
>>> 
>>> On Tue, Apr 05, 2016 at 11:06:48PM +0200, Michael Niedermayer wrote:  
>>>> On Tue, Apr 05, 2016 at 12:00:26PM -0700, Amancio Hasty wrote:  
>>>>> 
>>>>>> On Mar 31, 2016, at 7:27 PM, Amancio Hasty <aha...@gmail.com> wrote:
>>>>>> 
>>>>>> I am not a lawyer…
>>>>>> 
>>>>>> 
>>>>>> I updated the patch.  vc264.c now has a the copyright notice embedded in 
>>>>>> a volatile global so if a binary is compiled against vc264.o , the 
>>>>>> copyright notice
>>>>>> can be displayed by:
>>>>>> strings ffmpeg | grep -i copyright
>>>>>> 
>>>>>> LICENSE.md has been updated to include Broadcom’s copyright notice.
>>>>>> 
>>>>>> A distribution of a  binary that includes vc264.o should include 
>>>>>> LICENSE.md and if 
>>>>>> that is missing,  the copyright notice can be displayed via the shell
>>>>>> command ‘strings’ .
>>>>>> 
>>>>>> Amancio
>>>>>>   
>>>>>>> On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:
>>>>>>> 
>>>>>>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>>>>>>> 
>>>>>>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>>>>>>> From: Amancio Hasty <aha...@gmail.com>
>>>>>>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>>>>>>> Subject: [PATCH] added support for hardware assist H264  video 
>>>>>>>> encoding for
>>>>>>>> the Raspberry Pi
>>>>>>>> 
>>>>>>>> ---
>>>>>>>> configure  |  12 ++
>>>>>>>> libavcodec/Makefile|   1 +
>>>>>>>> libavcodec/allcodecs.c |   2 +
>>>>>>>> libavcodec/vc264.c | 387 
>>>>>>>> +
>>>>>>>> 4 files changed, 402 insertions(+)
>>>>>>>> create mode 100644 libavcodec/vc264.c
>>>>>>>> 
>>>>>>> [...]  
>>>>>>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>>>>>>> index 2a25d66..3c7bd9b 100644
>>>>>>>> --- a/libavcodec/allcodecs.c
>>>>>>>> +++ b/libavcodec/allcodecs.c
>>>>>>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>>>>>>  initialized = 1;
>>>>>>>> 
>>>>>>> 
>>>>>>> Nit: Whitespace on the line above should be removed.
>>>>>>> 
>>>>>>> [...]  
>>>>>>>> --- /dev/null
>>>>>>>> +++ b/libavcodec/vc264.c
>>>>>>>> @@ -0,0 +1,387 @@
>>>>>>>> +/*  H.264 hardware assist video encoding code taken from
>>>>>>>> + * raspberry's os :
>>>>>>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>>>>>>> + */
>>>>>>>> +
>>>>>>>> +/*
>>>>>>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>>>>>>> +Copyright (c) 2012, Kalle Vahlman <zuh@iki>
>>>>>>>> +Tuomas Kulve <tuo...@kulve.fi>
>>>>>>>> +All rights reserved.
>>>>>>>> +
>>>>>>>> +Redistribution and use in source and binary forms, with or without
>>>>>>>> +modification, are permitted provided that the following conditions 
>>>>>>>> are met:
>>>>>>>> +* Redistributions of source code must retain the above copyright
>>>>>>>> +  notice, this list of conditions and the following disclaimer.
>>>>>>>> +  * Redistributions in binary form must reproduce the above 
>>>>>>>> copyright
>>>>>>>> + 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Apr 6, 2016, at 3:42 AM, wm4 <nfx...@googlemail.com> wrote:
> 
> On Wed, 6 Apr 2016 02:56:49 -0700
> Amancio Hasty <aha...@gmail.com> wrote:
> 
>> If you think is better and it works , are there any plans to incorporate 
>> such an older patch?
> 
> I asked the author - he's looking into getting it ready for merge.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel 
> <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>

Curious, any reasonable estimate of when the merge is going to happen?


___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Apr 5, 2016, at 3:57 PM, Michael Niedermayer <mich...@niedermayer.cc> 
> wrote:
> 
> On Tue, Apr 05, 2016 at 11:06:48PM +0200, Michael Niedermayer wrote:
>> On Tue, Apr 05, 2016 at 12:00:26PM -0700, Amancio Hasty wrote:
>>> 
>>>> On Mar 31, 2016, at 7:27 PM, Amancio Hasty <aha...@gmail.com> wrote:
>>>> 
>>>> I am not a lawyer…
>>>> 
>>>> 
>>>> I updated the patch.  vc264.c now has a the copyright notice embedded in 
>>>> a volatile global so if a binary is compiled against vc264.o , the 
>>>> copyright notice
>>>> can be displayed by:
>>>> strings ffmpeg | grep -i copyright
>>>> 
>>>> LICENSE.md has been updated to include Broadcom’s copyright notice.
>>>> 
>>>> A distribution of a  binary that includes vc264.o should include 
>>>> LICENSE.md and if 
>>>> that is missing,  the copyright notice can be displayed via the shell
>>>> command ‘strings’ .
>>>> 
>>>> Amancio
>>>> 
>>>>> On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:
>>>>> 
>>>>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>>>>> 
>>>>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>>>>> From: Amancio Hasty <aha...@gmail.com>
>>>>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>>>>> Subject: [PATCH] added support for hardware assist H264  video encoding 
>>>>>> for
>>>>>> the Raspberry Pi
>>>>>> 
>>>>>> ---
>>>>>> configure  |  12 ++
>>>>>> libavcodec/Makefile|   1 +
>>>>>> libavcodec/allcodecs.c |   2 +
>>>>>> libavcodec/vc264.c | 387 
>>>>>> +
>>>>>> 4 files changed, 402 insertions(+)
>>>>>> create mode 100644 libavcodec/vc264.c
>>>>>> 
>>>>> [...]
>>>>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>>>>> index 2a25d66..3c7bd9b 100644
>>>>>> --- a/libavcodec/allcodecs.c
>>>>>> +++ b/libavcodec/allcodecs.c
>>>>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>>>>   initialized = 1;
>>>>>> 
>>>>> 
>>>>> Nit: Whitespace on the line above should be removed.
>>>>> 
>>>>> [...]
>>>>>> --- /dev/null
>>>>>> +++ b/libavcodec/vc264.c
>>>>>> @@ -0,0 +1,387 @@
>>>>>> +/*  H.264 hardware assist video encoding code taken from
>>>>>> + * raspberry's os :
>>>>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>>>>> + */
>>>>>> +
>>>>>> +/*
>>>>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>>>>> +Copyright (c) 2012, Kalle Vahlman <zuh@iki>
>>>>>> +Tuomas Kulve <tuo...@kulve.fi>
>>>>>> +All rights reserved.
>>>>>> +
>>>>>> +Redistribution and use in source and binary forms, with or without
>>>>>> +modification, are permitted provided that the following conditions are 
>>>>>> met:
>>>>>> +* Redistributions of source code must retain the above copyright
>>>>>> +  notice, this list of conditions and the following disclaimer.
>>>>>> +  * Redistributions in binary form must reproduce the above 
>>>>>> copyright
>>>>>> +  notice, this list of conditions and the following disclaimer in 
>>>>>> the
>>>>>> +  documentation and/or other materials provided with the 
>>>>>> distribution.
>>>>>> +  * Neither the name of the copyright holder nor the
>>>>>> +  names of its contributors may be used to endorse or promote 
>>>>>> products
>>>>>> +  derived from this software without specific prior written 
>>>>>> permission.
>>>>>> +
>>>>>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>>>>>> IS" AND
>>>>>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>>>>>> IMPLIED
>

[FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

0001-added-support-for-hardware-assist-H264-video-encodin.patch
Description: Binary data


Amancio Hasty

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Mar 18, 2016, at 12:20 PM, Lou Logan <l...@lrcd.com> wrote:
> 
> On Fri, 18 Mar 2016 12:12:24 -0700, Amancio Hasty wrote:
> 
>> The patch was against:
>> 2016-02-26-raspbian-jessie.img
>> 
>> In my Raspberry Pi  system:
>> /opt/vc/include/bcm_host.h
>> 
>> in ffmpeg/configure:
>> if enabled vc264_encoder &&  [ -n "$target_os_default"="linux" ] ; then
>>add_cflags ' -I/opt/vc/include/… 
> 
> I should have mentioned that I tested your patch on Linux x86_64 to
> show that it fails on systems without this "bcm_host.h" file.
> 
> Please avoid top-posting on this mailing list.

I tested the patch on Raspberry PI, Mac OS and Ubuntu running under vmware so
it does not cause any compilation errors .

Amancio


0001-added-support-for-hardware-assist-H264-video-encodin.patch
Description: Binary data




___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Mar 23, 2016, at 8:17 AM, Michael Niedermayer <mich...@niedermayer.cc> 
> wrote:
> 
> On Tue, Mar 22, 2016 at 06:40:27PM -0700, Amancio Hasty wrote:
> [...]
> 
>> +static int vc264_init(AVCodecContext *avctx) {
>> +
>> +
>> +
>> +   OMX_ERRORTYPE r;
>> +   int error;
>> +
>> +
>> +
>> +   VC264Context *vc = avctx->priv_data;
>> +
>> +   vc->width = avctx->width;
>> +   vc->height = avctx->height;
>> +   vc->bit_rate = avctx->bit_rate;
>> +#if FF_API_CODED_FRAME
>> +FF_DISABLE_DEPRECATION_WARNINGS
>> +
>> +   avctx->coded_frame = av_frame_alloc();
>> +   avctx->coded_frame->pict_type = AV_PICTURE_TYPE_I;
>> +FF_ENABLE_DEPRECATION_WARNINGS
>> +#endif
>> +
>> +
>> +   memset(>list, 0, sizeof(vc->list));
>> +   bcm_host_init();
>> +   if ((vc->client = ilclient_init()) == NULL) {
>> +  return -3;
>> +   }
>> +   error = OMX_Init();
>> +
>> +   if (error  != OMX_ErrorNone) {
>> +  ilclient_destroy(vc->client);
>> +  av_log(avctx,AV_LOG_ERROR,"in vc264_init OMX_Init failed ");
>> + return -4;
>> +}
>> +
>> +   // create video_encode
>> +   r = ilclient_create_component(vc->client, >video_encode, (char *) 
>> "video_encode",
>> + ILCLIENT_DISABLE_ALL_PORTS |
>> + ILCLIENT_ENABLE_INPUT_BUFFERS |
>> + ILCLIENT_ENABLE_OUTPUT_BUFFERS);
>> +
>> +   if (r != 0) {
>> +av_log(avctx,AV_LOG_ERROR,"ilclient_create_component() for 
>> video_encode failed with %x!",
>> +  r);
> 
>> +  exit(1);
> 
> a library cannot call exit()
> 
> also indention looks rather odd and random
> 
> [...]
> 
> -- 
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> The educated differ from the uneducated as much as the living from the
> dead. -- Aristotle 


Fixed the indentation and style by running :
indent -i4 -kr -nut vc264.c

fixed the error return values and the exit calls.

Amancio



b-0001-added-support-for-hardware-assist-H264-video-encodin.patch
Description: Binary data


___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:
> 
> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
> 
>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>> From: Amancio Hasty <aha...@gmail.com>
>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>> the Raspberry Pi
>> 
>> ---
>> configure  |  12 ++
>> libavcodec/Makefile|   1 +
>> libavcodec/allcodecs.c |   2 +
>> libavcodec/vc264.c | 387 
>> +
>> 4 files changed, 402 insertions(+)
>> create mode 100644 libavcodec/vc264.c
>> 
> [...]
>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>> index 2a25d66..3c7bd9b 100644
>> --- a/libavcodec/allcodecs.c
>> +++ b/libavcodec/allcodecs.c
>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>> initialized = 1;
>> 
> 
> Nit: Whitespace on the line above should be removed.
> 
> [...]
>> --- /dev/null
>> +++ b/libavcodec/vc264.c
>> @@ -0,0 +1,387 @@
>> +/*  H.264 hardware assist video encoding code taken from
>> + * raspberry's os :
>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>> + */
>> +
>> +/*
>> +Copyright (c) 2012, Broadcom Europe Ltd
>> +Copyright (c) 2012, Kalle Vahlman <zuh@iki>
>> +Tuomas Kulve <tuo...@kulve.fi>
>> +All rights reserved.
>> +
>> +Redistribution and use in source and binary forms, with or without
>> +modification, are permitted provided that the following conditions are met:
>> +* Redistributions of source code must retain the above copyright
>> +  notice, this list of conditions and the following disclaimer.
>> +  * Redistributions in binary form must reproduce the above copyright
>> +  notice, this list of conditions and the following disclaimer in the
>> +  documentation and/or other materials provided with the distribution.
>> +  * Neither the name of the copyright holder nor the
>> +  names of its contributors may be used to endorse or promote products
>> +  derived from this software without specific prior written permission.
>> +
>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" 
>> AND
>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>> IMPLIED
>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>> LIABLE FOR ANY
>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>> THIS
>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> 
> I wonder if any of the above legalese is compatible. Granted, I see a
> similar paragraph in "libavformat/aadec.c".
> 
>> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
>> GPU
>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>> + *
>> + *
>> + * This file is part of FFmpeg.
>> + *
>> + * FFmpeg is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU Lesser General Public
>> + * License as published by the Free Software Foundation; either
>> + * version 2.1 of the License, or (at your option) any later version.
>> + *
>> + * FFmpeg is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> + * Lesser General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU Lesser General Public
>> + * License along with FFmpeg; if not, write to the Free Software
>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 
>> USA
>> + *
>> + */
>> +
>> +
>> +/**
>> + * @ file vc264.c
>> + * Broadcom bm2865's Visual Core hardware assist h264 using
>> +   openMax interface to the GPU.
>> +
>> +*/
>> +
>> +#include 
>> +#include 
>> +#include 
>> +#define OMX_SKIP64BIT
>> +#include "bcm_host.h&

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

Is there a pretty formatter for ffmpeg’s coding style and
coding style guideline?

Amancio


> On Mar 23, 2016, at 8:17 AM, Michael Niedermayer <mich...@niedermayer.cc> 
> wrote:
> 
> On Tue, Mar 22, 2016 at 06:40:27PM -0700, Amancio Hasty wrote:
> [...]
> 
>> +static int vc264_init(AVCodecContext *avctx) {
>> +
>> +
>> +
>> +   OMX_ERRORTYPE r;
>> +   int error;
>> +
>> +
>> +
>> +   VC264Context *vc = avctx->priv_data;
>> +
>> +   vc->width = avctx->width;
>> +   vc->height = avctx->height;
>> +   vc->bit_rate = avctx->bit_rate;
>> +#if FF_API_CODED_FRAME
>> +FF_DISABLE_DEPRECATION_WARNINGS
>> +
>> +   avctx->coded_frame = av_frame_alloc();
>> +   avctx->coded_frame->pict_type = AV_PICTURE_TYPE_I;
>> +FF_ENABLE_DEPRECATION_WARNINGS
>> +#endif
>> +
>> +
>> +   memset(>list, 0, sizeof(vc->list));
>> +   bcm_host_init();
>> +   if ((vc->client = ilclient_init()) == NULL) {
>> +  return -3;
>> +   }
>> +   error = OMX_Init();
>> +
>> +   if (error  != OMX_ErrorNone) {
>> +  ilclient_destroy(vc->client);
>> +  av_log(avctx,AV_LOG_ERROR,"in vc264_init OMX_Init failed ");
>> + return -4;
>> +}
>> +
>> +   // create video_encode
>> +   r = ilclient_create_component(vc->client, >video_encode, (char *) 
>> "video_encode",
>> + ILCLIENT_DISABLE_ALL_PORTS |
>> + ILCLIENT_ENABLE_INPUT_BUFFERS |
>> + ILCLIENT_ENABLE_OUTPUT_BUFFERS);
>> +
>> +   if (r != 0) {
>> +av_log(avctx,AV_LOG_ERROR,"ilclient_create_component() for 
>> video_encode failed with %x!",
>> +  r);
> 
>> +  exit(1);
> 
> a library cannot call exit()
> 
> also indention looks rather odd and random
> 
> [...]
> 
> -- 
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> The educated differ from the uneducated as much as the living from the
> dead. -- Aristotle 

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

I wrote this driver a while ago before the mmal decoding was submitted…

Amancio


> On Mar 18, 2016, at 11:57 AM, wm4 <nfx...@googlemail.com> wrote:
> 
> On Fri, 18 Mar 2016 11:13:58 -0700
> Amancio Hasty <aha...@gmail.com> wrote:
> 
>> Amancio Hasty
>> 
> 
> It seems a bit strange that decoding now uses MMAL, and encoding OMX?
> 
> Probably also precludes transcoding without copying.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

I am not a lawyer…


I updated the patch.  vc264.c now has a the copyright notice embedded in 
a volatile global so if a binary is compiled against vc264.o , the copyright 
notice
can be displayed by:
strings ffmpeg | grep -i copyright

LICENSE.md has been updated to include Broadcom’s copyright notice.

A distribution of a  binary that includes vc264.o should include LICENSE.md and 
if 
that is missing,  the copyright notice can be displayed via the shell
command ‘strings’ .

Amancio


c-0001-added-support-for-hardware-assist-H264-video-encodin.patch
Description: Binary data

> On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:
> 
> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
> 
>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>> From: Amancio Hasty <aha...@gmail.com>
>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>> the Raspberry Pi
>> 
>> ---
>> configure  |  12 ++
>> libavcodec/Makefile|   1 +
>> libavcodec/allcodecs.c |   2 +
>> libavcodec/vc264.c | 387 
>> +
>> 4 files changed, 402 insertions(+)
>> create mode 100644 libavcodec/vc264.c
>> 
> [...]
>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>> index 2a25d66..3c7bd9b 100644
>> --- a/libavcodec/allcodecs.c
>> +++ b/libavcodec/allcodecs.c
>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>> initialized = 1;
>> 
> 
> Nit: Whitespace on the line above should be removed.
> 
> [...]
>> --- /dev/null
>> +++ b/libavcodec/vc264.c
>> @@ -0,0 +1,387 @@
>> +/*  H.264 hardware assist video encoding code taken from
>> + * raspberry's os :
>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>> + */
>> +
>> +/*
>> +Copyright (c) 2012, Broadcom Europe Ltd
>> +Copyright (c) 2012, Kalle Vahlman <zuh@iki>
>> +Tuomas Kulve <tuo...@kulve.fi>
>> +All rights reserved.
>> +
>> +Redistribution and use in source and binary forms, with or without
>> +modification, are permitted provided that the following conditions are met:
>> +* Redistributions of source code must retain the above copyright
>> +  notice, this list of conditions and the following disclaimer.
>> +  * Redistributions in binary form must reproduce the above copyright
>> +  notice, this list of conditions and the following disclaimer in the
>> +  documentation and/or other materials provided with the distribution.
>> +  * Neither the name of the copyright holder nor the
>> +  names of its contributors may be used to endorse or promote products
>> +  derived from this software without specific prior written permission.
>> +
>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" 
>> AND
>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>> IMPLIED
>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>> LIABLE FOR ANY
>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>> THIS
>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> 
> I wonder if any of the above legalese is compatible. Granted, I see a
> similar paragraph in "libavformat/aadec.c".
> 
>> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
>> GPU
>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>> + *
>> + *
>> + * This file is part of FFmpeg.
>> + *
>> + * FFmpeg is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU Lesser General Public
>> + * License as published by the Free Software Foundation; either
>> + * version 2.1 of the License, or (at your option) any later version.
>> + *
>> + * FFmpeg is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> + * Lesser General Public License for more details.
>> + *
>> + * You should have received 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Mar 31, 2016, at 7:27 PM, Amancio Hasty <aha...@gmail.com> wrote:
> 
> I am not a lawyer…
> 
> 
> I updated the patch.  vc264.c now has a the copyright notice embedded in 
> a volatile global so if a binary is compiled against vc264.o , the copyright 
> notice
> can be displayed by:
> strings ffmpeg | grep -i copyright
> 
> LICENSE.md has been updated to include Broadcom’s copyright notice.
> 
> A distribution of a  binary that includes vc264.o should include LICENSE.md 
> and if 
> that is missing,  the copyright notice can be displayed via the shell
> command ‘strings’ .
> 
> Amancio
> 
>> On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:
>> 
>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>> 
>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>> From: Amancio Hasty <aha...@gmail.com>
>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>>> the Raspberry Pi
>>> 
>>> ---
>>> configure  |  12 ++
>>> libavcodec/Makefile|   1 +
>>> libavcodec/allcodecs.c |   2 +
>>> libavcodec/vc264.c | 387 
>>> +
>>> 4 files changed, 402 insertions(+)
>>> create mode 100644 libavcodec/vc264.c
>>> 
>> [...]
>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>> index 2a25d66..3c7bd9b 100644
>>> --- a/libavcodec/allcodecs.c
>>> +++ b/libavcodec/allcodecs.c
>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>initialized = 1;
>>> 
>> 
>> Nit: Whitespace on the line above should be removed.
>> 
>> [...]
>>> --- /dev/null
>>> +++ b/libavcodec/vc264.c
>>> @@ -0,0 +1,387 @@
>>> +/*  H.264 hardware assist video encoding code taken from
>>> + * raspberry's os :
>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>> + */
>>> +
>>> +/*
>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>> +Copyright (c) 2012, Kalle Vahlman <zuh@iki>
>>> +Tuomas Kulve <tuo...@kulve.fi>
>>> +All rights reserved.
>>> +
>>> +Redistribution and use in source and binary forms, with or without
>>> +modification, are permitted provided that the following conditions are met:
>>> +* Redistributions of source code must retain the above copyright
>>> +  notice, this list of conditions and the following disclaimer.
>>> +  * Redistributions in binary form must reproduce the above copyright
>>> +  notice, this list of conditions and the following disclaimer in the
>>> +  documentation and/or other materials provided with the distribution.
>>> +  * Neither the name of the copyright holder nor the
>>> +  names of its contributors may be used to endorse or promote products
>>> +  derived from this software without specific prior written permission.
>>> +
>>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>>> IS" AND
>>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>>> IMPLIED
>>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>>> LIABLE FOR ANY
>>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
>>> SERVICES;
>>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>>> THIS
>>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>> 
>> I wonder if any of the above legalese is compatible. Granted, I see a
>> similar paragraph in "libavformat/aadec.c".
>> 
>>> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
>>> GPU
>>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>>> + *
>>> + *
>>> + * This file is part of FFmpeg.
>>> + *
>>> + * FFmpeg is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU Lesser General Public
>>> + * License as published by the Free Software Foundation; eit

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Apr 4, 2016, at 10:41 AM, wm4 <nfx...@googlemail.com> wrote:
> 
> On Mon, 4 Apr 2016 10:08:56 -0700
> Amancio Hasty <aha...@gmail.com <mailto:aha...@gmail.com>> wrote:
> 
>>> On Mar 31, 2016, at 7:27 PM, Amancio Hasty <aha...@gmail.com> wrote:
>>> 
>>> I am not a lawyer…
>>> 
>>> 
>>> I updated the patch.  vc264.c now has a the copyright notice embedded in 
>>> a volatile global so if a binary is compiled against vc264.o , the 
>>> copyright notice
>>> can be displayed by:
>>> strings ffmpeg | grep -i copyright
>>> 
>>> LICENSE.md has been updated to include Broadcom’s copyright notice.
>>> 
>>> A distribution of a  binary that includes vc264.o should include LICENSE.md 
>>> and if 
>>> that is missing,  the copyright notice can be displayed via the shell
>>> command ‘strings’ .
>>> 
>>> Amancio
>>>   
>>>> On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:
>>>> 
>>>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>>>> 
>>>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>>>> From: Amancio Hasty <aha...@gmail.com>
>>>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>>>> Subject: [PATCH] added support for hardware assist H264  video encoding 
>>>>> for
>>>>> the Raspberry Pi
>>>>> 
>>>>> ---
>>>>> configure  |  12 ++
>>>>> libavcodec/Makefile|   1 +
>>>>> libavcodec/allcodecs.c |   2 +
>>>>> libavcodec/vc264.c | 387 
>>>>> +
>>>>> 4 files changed, 402 insertions(+)
>>>>> create mode 100644 libavcodec/vc264.c
>>>>> 
>>>> [...]  
>>>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>>>> index 2a25d66..3c7bd9b 100644
>>>>> --- a/libavcodec/allcodecs.c
>>>>> +++ b/libavcodec/allcodecs.c
>>>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>>>   initialized = 1;
>>>>> 
>>>> 
>>>> Nit: Whitespace on the line above should be removed.
>>>> 
>>>> [...]  
>>>>> --- /dev/null
>>>>> +++ b/libavcodec/vc264.c
>>>>> @@ -0,0 +1,387 @@
>>>>> +/*  H.264 hardware assist video encoding code taken from
>>>>> + * raspberry's os :
>>>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>>>> + */
>>>>> +
>>>>> +/*
>>>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>>>> +Copyright (c) 2012, Kalle Vahlman <zuh@iki>
>>>>> +Tuomas Kulve <tuo...@kulve.fi>
>>>>> +All rights reserved.
>>>>> +
>>>>> +Redistribution and use in source and binary forms, with or without
>>>>> +modification, are permitted provided that the following conditions are 
>>>>> met:
>>>>> +* Redistributions of source code must retain the above copyright
>>>>> +  notice, this list of conditions and the following disclaimer.
>>>>> +  * Redistributions in binary form must reproduce the above copyright
>>>>> +  notice, this list of conditions and the following disclaimer in the
>>>>> +  documentation and/or other materials provided with the 
>>>>> distribution.
>>>>> +  * Neither the name of the copyright holder nor the
>>>>> +  names of its contributors may be used to endorse or promote 
>>>>> products
>>>>> +  derived from this software without specific prior written 
>>>>> permission.
>>>>> +
>>>>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>>>>> IS" AND
>>>>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>>>>> IMPLIED
>>>>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>>>>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>>>>> LIABLE FOR ANY
>>>>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 
>>>>> DAMAGES
>>>>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
>>>>

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

Curious,

Do these patches work with ffmpeg running on RPi?

Thanks,
Amancio

> On Apr 19, 2016, at 12:00 PM, Aman Gupta <ffm...@tmm1.net> wrote:
> 
> On Thu, Apr 7, 2016 at 3:03 AM, Mark Thompson <s...@jkqxz.net 
> <mailto:s...@jkqxz.net>> wrote:
> 
>> On 06/04/16 14:25, Amancio Hasty wrote:
>>> 
>>>> On Apr 6, 2016, at 3:42 AM, wm4 <nfx...@googlemail.com> wrote:
>>>> 
>>>> On Wed, 6 Apr 2016 02:56:49 -0700
>>>> Amancio Hasty <aha...@gmail.com> wrote:
>>>> 
>>>>> If you think is better and it works , are there any plans to
>> incorporate such an older patch?
>>>> 
>>>> I asked the author - he's looking into getting it ready for merge.
>>>> 
>>> 
>>> Curious, any reasonable estimate of when the merge is going to happen?
>>> 
>> 
>> https://lists.libav.org/pipermail/libav-devel/2016-April/076042.html
>> https://lists.libav.org/pipermail/libav-devel/2016-April/076040.html
>> https://lists.libav.org/pipermail/libav-devel/2016-April/076041.html
>> 
>> Please test/review!  (Make sure it works for you and has the features you
>> want,
>> at least.)
>> 
> 
> Looks like these patches were merged into libav already. I've rebased them
> on top of ffmpeg master here:
> https://github.com/FFmpeg/FFmpeg/compare/master...tmm1:rebase-omx.patch 
> <https://github.com/FFmpeg/FFmpeg/compare/master...tmm1:rebase-omx.patch>
> 
> Aman
> 
> 
>> 
>> ___
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel 
>> <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>
>> 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel 
> <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

Hi,

So what is the next step?

If you want testers I suggest posting to ccrisan’s motionpie mailing list.
Cheers
Amancio


> On Mar 31, 2016, at 7:27 PM, Amancio Hasty <aha...@gmail.com> wrote:
> 
> I am not a lawyer…
> 
> 
> I updated the patch.  vc264.c now has a the copyright notice embedded in 
> a volatile global so if a binary is compiled against vc264.o , the copyright 
> notice
> can be displayed by:
> strings ffmpeg | grep -i copyright
> 
> LICENSE.md has been updated to include Broadcom’s copyright notice.
> 
> A distribution of a  binary that includes vc264.o should include LICENSE.md 
> and if 
> that is missing,  the copyright notice can be displayed via the shell
> command ‘strings’ .
> 
> Amancio
> 
>> On Mar 22, 2016, at 12:12 PM, Lou Logan <l...@lrcd.com> wrote:
>> 
>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>> 
>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>> From: Amancio Hasty <aha...@gmail.com>
>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>>> the Raspberry Pi
>>> 
>>> ---
>>> configure  |  12 ++
>>> libavcodec/Makefile|   1 +
>>> libavcodec/allcodecs.c |   2 +
>>> libavcodec/vc264.c | 387 
>>> +
>>> 4 files changed, 402 insertions(+)
>>> create mode 100644 libavcodec/vc264.c
>>> 
>> [...]
>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>> index 2a25d66..3c7bd9b 100644
>>> --- a/libavcodec/allcodecs.c
>>> +++ b/libavcodec/allcodecs.c
>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>initialized = 1;
>>> 
>> 
>> Nit: Whitespace on the line above should be removed.
>> 
>> [...]
>>> --- /dev/null
>>> +++ b/libavcodec/vc264.c
>>> @@ -0,0 +1,387 @@
>>> +/*  H.264 hardware assist video encoding code taken from
>>> + * raspberry's os :
>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>> + */
>>> +
>>> +/*
>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>> +Copyright (c) 2012, Kalle Vahlman <zuh@iki>
>>> +Tuomas Kulve <tuo...@kulve.fi>
>>> +All rights reserved.
>>> +
>>> +Redistribution and use in source and binary forms, with or without
>>> +modification, are permitted provided that the following conditions are met:
>>> +* Redistributions of source code must retain the above copyright
>>> +  notice, this list of conditions and the following disclaimer.
>>> +  * Redistributions in binary form must reproduce the above copyright
>>> +  notice, this list of conditions and the following disclaimer in the
>>> +  documentation and/or other materials provided with the distribution.
>>> +  * Neither the name of the copyright holder nor the
>>> +  names of its contributors may be used to endorse or promote products
>>> +  derived from this software without specific prior written permission.
>>> +
>>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>>> IS" AND
>>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>>> IMPLIED
>>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>>> LIABLE FOR ANY
>>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
>>> SERVICES;
>>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>>> THIS
>>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>> 
>> I wonder if any of the above legalese is compatible. Granted, I see a
>> similar paragraph in "libavformat/aadec.c".
>> 
>>> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
>>> GPU
>>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>>> + *
>>> + *
>>> + * This file is part of FFmpeg.
>>> + *
>>> + * FFmpeg is free software; you can redistribute it and/or
>>> + * modify it u

Re: [FFmpeg-devel] release/3.1

[Amancio Hasty]

On June 26, 2016 at 5:49:30 PM, Michael Niedermayer (mich...@niedermayer.cc)
wrote:

On Sun, Jun 26, 2016 at 03:36:33AM +0200, Michael Niedermayer wrote:
> Hi all
>
> ive branched release/3.1 off from master
> i will make the 3.1 release from HEAD of this branch tomorrow
> If there are any last minute changes that should go in, thats your
> very last chance to put them in !

3.1 release made

3.1.1 will be made from release/3.1 in 1-2 weeks probably, please
backport all clean bugfixes which affect 3.1

thx

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Cool.

You can close ticket #3518 which states that ffmpeg does not support RPI’s
hardware h264 encoding.

Amancio
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] release/3.1

[Amancio Hasty]

How is this commit then for ticket #3518:

e330ab0fb7cb140cfde98077e1a953c200282087
Merge: 0e38723 f1cd9b0
Author: Derek Buitenhuis <derek.buitenh...@gmail.com>
Date:   Wed May 11 19:23:15 2016 +0100

Merge commit 'f1cd9b03f3fa875eb5e394281b4b688cec611658'

* commit 'f1cd9b03f3fa875eb5e394281b4b688cec611658':
  omx: Add support for broadcom OMX on raspberry pi
—


Cheers
Amancio




On June 27, 2016 at 9:04:13 AM, Amancio Hasty (aha...@gmail.com) wrote:

This is the commit that introduced the functionality:
f1cd9b03f3fa875eb5e394281b4b688cec611658

Amancio





On June 27, 2016 at 5:35:33 AM, Carl Eugen Hoyos (ceho...@ag.or.at) wrote:

Amancio Hasty  gmail.com> writes:

> You can close ticket #3518 which states that ffmpeg does not
> support RPI’s hardware h264 encoding.

Which commit fixed #3518?

Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel