Re: [FFmpeg-trac] #1351(avcodec:reopened): mpeg2video lowres support

[FFmpeg]

#1351: mpeg2video lowres support
-+-
 Reporter:  jyavenard|Owner:
 Type:  defect   |   Status:  reopened
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  mpeg2video   |   Blocked By:
  regression lowres  |  Reproduced by developer:  1
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by jyavenard):

 Thanks Michael.. I see what went on...
 I was confused with the name of "lowres2" and skipped that commit

 So it was just mpeg2 that didn't get revert properly at first...

 Excellent news..

 I can tell you for sure now that MythTV will sync with ffmpeg from now on.

-- 
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://avcodec.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #1351(avcodec:reopened): mpeg2video lowres support

[FFmpeg]

#1351: mpeg2video lowres support
-+-
 Reporter:  jyavenard|Owner:
 Type:  defect   |   Status:  reopened
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  mpeg2video   |   Blocked By:
  regression lowres  |  Reproduced by developer:  1
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by cehoyos):

 Replying to [comment:10 michael]:
 > Ive not double checked now but i belive that the 2 commits brought all
 parts back.
 I believe wmv2 is still missing, I don't know if this is more difficult /
 problematic because of IntraX8 / J-frames.

-- 
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://avcodec.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #1351(avcodec:reopened): mpeg2video lowres support

[FFmpeg]

#1351: mpeg2video lowres support
-+-
 Reporter:  jyavenard|Owner:
 Type:  defect   |   Status:  reopened
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  mpeg2video   |   Blocked By:
  regression lowres  |  Reproduced by developer:  1
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by michael):

 Note, the lowres removial was reverted in 2 commits, first was
 70d54392f5015b9c6594fcae558f59f952501e3b.
 Ive not double checked now but i belive that the 2 commits brought all
 parts back.

-- 
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://avcodec.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #1351(avcodec:reopened): mpeg2video lowres support

[FFmpeg]

#1351: mpeg2video lowres support
-+-
 Reporter:  jyavenard|Owner:
 Type:  defect   |   Status:  reopened
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  mpeg2video   |   Blocked By:
  regression lowres  |  Reproduced by developer:  1
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by cehoyos):

 Replying to [comment:8 jyavenard]:
 > yes, mpeg2video lowres support was re-enabled. But what about lowres
 support for all the other codecs that were removed in that same commit.
 If you add a failing command line, it would be easier to understand which
 codecs you are talking about, I could then close this ticket (that you
 opened about mpeg2video) and open a new one.

 You are right that tickets against libavcodec can be opened, but long time
 experience tells us that tickets that are reproducible with ffmpeg are
 much faster fixed.

-- 
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://avcodec.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #1351(avcodec:reopened): mpeg2video lowres support

[FFmpeg]

#1351: mpeg2video lowres support
-+-
 Reporter:  jyavenard|Owner:
 Type:  defect   |   Status:  reopened
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  mpeg2video   |   Blocked By:
  regression lowres  |  Reproduced by developer:  1
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by jyavenard):

 Command line of what? this is a libavcodec issue and about features
 dropped from it.

 yes, mpeg2video lowres support was re-enabled. But what about lowres
 support for all the other codecs that were removed in that same commit.
 Those were not reverted, i have listed above all the codecs that suddenly
 saw their lowres support dropped.

-- 
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://avcodec.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #1351(avcodec:reopened): mpeg2video lowres support

[FFmpeg]

#1351: mpeg2video lowres support
-+-
 Reporter:  jyavenard|Owner:
 Type:  defect   |   Status:  reopened
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  mpeg2video   |   Blocked By:
  regression lowres  |  Reproduced by developer:  1
 Blocking:   |
Analyzed by developer:  0|
-+-

Comment (by cehoyos):

 Replying to [comment:6 jyavenard]:
 > However, are you sure the revert is complete?
 No.

 You reported that mpeg2video lowres support is missing (I originally read
 only the body of the ticket, where it only says "lowres was removed", I
 did not understand the problem because lowres did exist at least for mpeg4
 and dvvideo at the time you reported the problem).
 Since yesterday, mpeg2video lowres works fine here.

 If you believe there still is an issue, please provide a failing command
 line together with complete, uncut output (you should have done this
 originally).

-- 
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://avcodec.org/mailman/listinfo/ffmpeg-trac

Re: [FFmpeg-trac] #1351(avcodec:reopened): mpeg2video lowres support

[FFmpeg]

#1351: mpeg2video lowres support
-+-
 Reporter:  jyavenard|Owner:
 Type:  defect   |   Status:  reopened
 Priority:  important|Component:  avcodec
  Version:  git-master   |   Resolution:
 Keywords:  mpeg2video   |   Blocked By:
  regression lowres  |  Reproduced by developer:  1
 Blocking:   |
Analyzed by developer:  0|
-+-
Changes (by jyavenard):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Thank you for this...

 However, are you sure the revert is complete?

 The git comment itself is wrong, and the sha mentioned isn't the correct
 one:
 
http://git.videolan.org/?p=ffmpeg.git;a=commit;h=5e50a5724bb00c44a98bd89f57c659a613f26ce2

 The merged commit (from Libav) that removed lowres was
 2bcbd98459915baefc15043d02f4a942ebcd33da
 
http://git.videolan.org/?p=ffmpeg.git;a=commit;h=2bcbd98459915baefc15043d02f4a942ebcd33da

 it modified the files:
 {{{
 avconv.c
 avplay.c
 libavcodec/alpha/dsputil_alpha.c
 libavcodec/arm/dsputil_init_arm.c
 libavcodec/arm/dsputil_init_armv5te.c
 libavcodec/arm/dsputil_init_armv6.c
 libavcodec/arm/dsputil_init_neon.c
 libavcodec/avcodec.h
 libavcodec/dsputil.c
 libavcodec/dsputil.h
 libavcodec/dv.c
 libavcodec/dvdec.c
 libavcodec/error_resilience.c
 libavcodec/flvdec.c
 libavcodec/h261dec.c
 libavcodec/h263dec.c
 libavcodec/intrax8.c
 libavcodec/jrevdct.c
 libavcodec/libopenjpeg.c
 libavcodec/mjpegbdec.c
 libavcodec/mjpegdec.c
 libavcodec/mpeg12.c
 libavcodec/mpeg4videodec.c
 libavcodec/mpegvideo.c
 libavcodec/mpegvideo.h
 libavcodec/msmpeg4.c
 libavcodec/mxpegdec.c
 libavcodec/options_table.h
 libavcodec/ppc/dsputil_ppc.c
 libavcodec/rv10.c
 libavcodec/sp5xdec.c
 libavcodec/utils.c
 libavcodec/wmv2dec.c
 libavcodec/x86/dsputil_mmx.c
 }}}

 Also, a following commits removed DSP code that were used for lowres
 support:
 d7458bc8c62ae1cb2ffc805b989fcddf4029dda6
 
http://git.videolan.org/?p=ffmpeg.git;a=commit;h=d7458bc8c62ae1cb2ffc805b989fcddf4029dda6

 So the reversal made is only partial and only going to have an effect on
 mpeg decoder...

 BTW, I agree, there's no way four extra bit shifts would have caused a
 drop of speed of 3%... Those stats could have only been made up...

-- 
Ticket URL: 
FFmpeg 
FFmpeg issue tracker
___
FFmpeg-trac mailing list
FFmpeg-trac@avcodec.org
http://avcodec.org/mailman/listinfo/ffmpeg-trac