Minor: the package creates all its files via PostInstScript including the 
directory in which they reside. That makes it difficult for sysadmins to 
determine what package owns those files because nothing about them is managed 
by dpkg. It appears that creating the files at that stage makes sense, but that 
the directory-name would be known at InstallScript (it's in %p and based on 
data published by another quite stable package). Having the directory in the 
.deb would at least make *that* level known to dpkg, giving a correct clue to 
the package that handes the files within. Easily fixable, will do so in a day 
or two unless someone complains. 

Major 1: the PostInstScript hardcodes full paths to several executables in 
/usr/X11R6/bin, an x11 prefix that is not the real x11 prefix on any supported 
platform (and hasn't been for many years). It remains as a symlink (when the 
installer doesn't screw up) on currently supported platforms, but who knows 
what might happen in the future. Fink's init.sh is designed to add the correct 
x11 paths to PATH and is always loaded for all dpkg package scripts, so there's 
no need to hardcode at all. That avoids having to update or fork the package 
for different x11 vendors (of which 10.7 is different than 10.8+). Easily 
fixable, will do so in a day or two unless someone complains. 

Major 2: the PostInstScript, running as root, silently seems to alter files in 
all users' homedirs. That's not very nice! And it links them all into a public 
(in %p) location. Not good to expose user's private filenames to each other 
(even if the files themselves are protected by permissions). And it creates all 
those links in a single location, so multiple users' file-links would overwrite 
each other. That means it's broken for all users except the "last" one, since 
presumably those whose were overwritten would not have permission to the 
last-one's files. This all might make sense on a single-user machine, but not 
beyond that. This is all badly broken by design and I don't know a correct 
solution. Is there a way to have the users' data cached in each user's own 
space, or at least in subdirs?

dan

--
Daniel Macks
dma...@netspace.org

------------------------------------------------------------------------------
_______________________________________________
Fink-devel mailing list
Fink-devel@lists.sourceforge.net
List archive:
http://news.gmane.org/gmane.os.apple.fink.devel
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-devel

Reply via email to