Re: [Firebird-devel] I need help with parse.y

2014-11-07 Thread Adriano dos Santos Fernandes 
On 07/11/2014 14:03, Dimitry Sibiryakov wrote:
   Hello, All.

   I've changed parse.y with attached diff, but even after clean full
 rebuild isql shows me this error:

 SQL set transaction no replication;
 Commit current transaction (y/n)?n
 Rolling back work.
 Statement failed, SQLSTATE = 42000
 Dynamic SQL Error
 -SQL error code = -104
 -Token unknown - line 1, column 20
 -replication

   I'm out of ideas what I did wrong.


Was not added it to keywords.cpp?


Adriano


--
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Re: [Firebird-devel] I need help with parse.y

2014-11-07 Thread Leyne, Sean 
Dimitry,

 SQL set transaction no replication;
 Commit current transaction (y/n)?n
 Rolling back work.
 Statement failed, SQLSTATE = 42000
 Dynamic SQL Error
 -SQL error code = -104
 -Token unknown - line 1, column 20
 -replication

Are you proposing to make this change (adding no replication syntax) to the 
Firebird codebase?


Sean


--
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Re: [Firebird-devel] I need help with parse.y

2014-11-07 Thread Dimitry Sibiryakov 
07.11.2014 17:07, Adriano dos Santos Fernandes wrote:
 Was not added it to keywords.cpp?

   Yep, that is the trick. Thanks.

-- 
   WBR, SD.

--
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Re: [Firebird-devel] I need help with parse.y

2014-11-07 Thread Dimitry Sibiryakov 
07.11.2014 17:18, Leyne, Sean wrote:
 Are you proposing to make this change (adding no replication syntax) to the 
 Firebird codebase?

   So far it is a private fork. But, according to the IDPL license, you can 
merge changed 
sources to the main codebase if you wish as soon as they are published.

-- 
   WBR, SD.

--
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Re: [Firebird-devel] I need help with parse.y

2014-11-07 Thread Mark Rotteveel 
On Fri, 07 Nov 2014 17:21:51 +0100, Dimitry Sibiryakov s...@ibphoenix.com
wrote:
 07.11.2014 17:18, Leyne, Sean wrote:
 Are you proposing to make this change (adding no replication syntax)
 to the Firebird codebase?
 
So far it is a private fork. But, according to the IDPL license, you
can merge changed
 sources to the main codebase if you wish as soon as they are published.

Maybe a different syntax for these type of extensions would be better as
it introduces less pollution in the parser and would make it easier to
introduce extensions without changing the parser. Consider something like:

SET TRANSACTION WITH (replication=off, some_other_option=5, etc=true)

These options (and their values) are not keywords(!), but values/names
(comparable to a column name in a SELECT clause). Checking validity of the
names and values is deferred to execute time instead of statement parse
time.

This is similar to what for example SQL Server has with its index options:
http://msdn.microsoft.com/en-us/library/ms188783.aspx. I believe SQL server
has a this WITH-feature in multiple DDL and DML statements.

Mark

--
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel