Re: [Firebird-devel] [firebird] increment build number (773c7bf)
25.03.2016 22:48, Adriano dos Santos Fernandes пишет: > Em 25/03/2016 16:24, Dmitry Yemanov escreveu: >> This gives us a buildno counted in days, not in commits (as now). >> > In practive it's not different. > > Doesn't the script is running per day like was in svn? > > Right, that means the snapshot build has a "perfect" buildno, but the > people who download zip does not. > > With the solution above, we can make snapshot builds to checkout tree or > 00:00 hour of the given date, so it can have a perfect buildno that we > can convert to date as well. One question - if there are no commits for some days (typical for stable branches) will buildno anyway be incremented every day? If yes IMHO this is not good. -- Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] [firebird] increment build number (773c7bf)
On Sat, Mar 26, 2016 at 12:43:11PM +0300, alex wrote: > > 25.03.2016 22:48, Adriano dos Santos Fernandes пишет: > > Em 25/03/2016 16:24, Dmitry Yemanov escreveu: > >> This gives us a buildno counted in days, not in commits (as now). > >> > > In practive it's not different. > > > > Doesn't the script is running per day like was in svn? > > > > Right, that means the snapshot build has a "perfect" buildno, but the > > people who download zip does not. > > > > With the solution above, we can make snapshot builds to checkout tree or > > 00:00 hour of the given date, so it can have a perfect buildno that we > > can convert to date as well. > > One question - if there are no commits for some days (typical for stable > branches) will buildno anyway be incremented every day? If yes IMHO this > is not good. Both Adriano's and my proposal calculate the build number from the (commit) date of the latest commit, not current date. So if there is a commit on Friday and next is on Monday, you get the same build number for the Saturday, Sunday and Monday snapshot (assuming snapshots are taken on midnight or shortly after) but it is raised by 3 once the Monday commit appears. In other words, there is no need to build a new daily snapshot if there are no commits since the last one. Michal Kubecek -- Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] [firebird] increment build number (773c7bf)
Em 26/03/2016 07:05, Michal Kubecek escreveu: > On Sat, Mar 26, 2016 at 12:43:11PM +0300, alex wrote: >> >> 25.03.2016 22:48, Adriano dos Santos Fernandes пишет: >>> Em 25/03/2016 16:24, Dmitry Yemanov escreveu: This gives us a buildno counted in days, not in commits (as now). >>> In practive it's not different. >>> >>> Doesn't the script is running per day like was in svn? >>> >>> Right, that means the snapshot build has a "perfect" buildno, but the >>> people who download zip does not. >>> >>> With the solution above, we can make snapshot builds to checkout tree or >>> 00:00 hour of the given date, so it can have a perfect buildno that we >>> can convert to date as well. >> >> One question - if there are no commits for some days (typical for stable >> branches) will buildno anyway be incremented every day? If yes IMHO this >> is not good. > > Both Adriano's and my proposal calculate the build number from the > (commit) date of the latest commit, not current date. So if there is a > commit on Friday and next is on Monday, you get the same build number > for the Saturday, Sunday and Monday snapshot (assuming snapshots are > taken on midnight or shortly after) but it is raised by 3 once the > Monday commit appears. In other words, there is no need to build a new > daily snapshot if there are no commits since the last one. > Yes. And just to be sure I tested that this last commit date really works per branch. Adriano -- Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] [firebird] increment build number (773c7bf)
25.03.2016 22:48, Adriano dos Santos Fernandes wrote: >> This gives us a buildno counted in days, not in commits (as now). > > In practive it's not different. > > Doesn't the script is running per day like was in svn? > > Right, that means the snapshot build has a "perfect" buildno, but the > people who download zip does not. > > With the solution above, we can make snapshot builds to checkout tree or > 00:00 hour of the given date, so it can have a perfect buildno that we > can convert to date as well. Or we may adopt a combined solution. For our own builds, both official and snapshots, calculate the build number as commit count (as now, but without storing in the repo). For external builds, gather LAST_COMMIT and embed it into the version string *as date*. I.e. something like: Firebird-4.0.0.123-Unstable (official) vs Firebird-4.0.0.0-20160326-Unstable (unofficial) Port maintainers will either use our git-based scripts to get a proper build number or fix the version string themselves with whatever numbering they want. And for any non-official snapshots we will see them as obviously non-official and still be able to determine what code checkout they belong to. Does anyone think it looks better? Dmitry -- Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] [firebird] increment build number (773c7bf)
25.03.2016 12:43, Dimitry Sibiryakov wrote: > 25.03.2016 10:37, Dmitry Yemanov wrote: >> We used exactly the same approach with SVN and nobody complained about >> polluted changelog. > > Because nighty commits weren't in ChangeLog and nobody cared about native SVN > log. Just for the record - but they WERE in fb-checkins and nobody complained. Personally, I checked fb-checkins wy more often than ChangeLog and I suspect others too. Dummy records there wasn't an issue, however. I still suspect that this "problem" gets more attention than it deserves. Dmitry -- Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] [firebird] increment build number (773c7bf)
26.03.2016 17:43, Dmitry Yemanov wrote: > 25.03.2016 12:43, Dimitry Sibiryakov wrote: > >> 25.03.2016 10:37, Dmitry Yemanov wrote: >>> We used exactly the same approach with SVN and nobody complained about >>> polluted changelog. >> >> Because nighty commits weren't in ChangeLog and nobody cared about native >> SVN log. > > Just for the record - but they WERE in fb-checkins and nobody > complained. Personally, I checked fb-checkins wy more often than > ChangeLog and I suspect others too. Dummy records there wasn't an issue, > however. > > I still suspect that this "problem" gets more attention than it deserves. Fully agreed Regards, Vlad -- Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] [firebird] increment build number (773c7bf)
Em 26/03/2016 11:46, Dmitry Yemanov escreveu: > > Or we may adopt a combined solution. For our own builds, both official > and snapshots, calculate the build number as commit count (as now, but > without storing in the repo). For external builds, gather LAST_COMMIT > and embed it into the version string *as date*. I.e. something like: > > Firebird-4.0.0.123-Unstable (official) > vs > Firebird-4.0.0.0-20160326-Unstable (unofficial) > > Port maintainers will either use our git-based scripts to get a proper > build number or fix the version string themselves with whatever > numbering they want. And for any non-official snapshots we will see them > as obviously non-official and still be able to determine what code > checkout they belong to. > > Does anyone think it looks better? > The problem I see is the executable version info which will not be accurate. May be a problem if someone installs a version replacing another one. I like to see the commit hash in the string, even for official releases. Adriano -- Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] [firebird] increment build number (773c7bf)
26.03.2016 19:08, Adriano dos Santos Fernandes wrote: > > The problem I see is the executable version info which will not be accurate. Please elaborate. Our executables will have build number in the executable version info, as they always had. > I like to see the commit hash in the string, even for official releases. As already said, I see no problems with commit hash in snapshot builds. But I don't really like polluting the version string with this info in official releases, it's already long enough. We have all releases tagged, after all. That said, I'm not going to object if others consider it useful. Dmitry -- Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] [firebird] increment build number (773c7bf)
Em 26/03/2016 13:22, Dmitry Yemanov escreveu: > 26.03.2016 19:08, Adriano dos Santos Fernandes wrote: >> >> The problem I see is the executable version info which will not be accurate. > > Please elaborate. Our executables will have build number in the > executable version info, as they always had. > But just because we know we build it in a git tree with git installed. As you said, third party builds or from git-archive will have 0 buildno in the executables. In my opinion, a common approach, even with number gaps, would be better. Adriano -- Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
[Firebird-devel] src_bundle.sh
Hi! Can't we replace this script by git archive command? Adriano -- Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
