Re: [Firebird-net-provider] FbBatchExecution
That breaks the notion of single point for interaction. -- Mgr. Jiří Činčura Independent IT Specialist -- ___ Firebird-net-provider mailing list Firebird-net-provider@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
Re: [Firebird-net-provider] FbBatchExecution
you can also add helper method "Add(FbScript scrip)" to support current ctor. On Tue, Jun 16, 2015 at 7:57 AM, Jiří Činčura wrote: > Thinking more about it. Maybe the ctor should be only with optional > FbConnection and the rest can be done via SqlStatements property. Then it's > not tied to FbScript at all. > > Maybe then the FbStatementCollection can have a simple "helper" method > "Add(FbStatementCollection)" (or something like that). Then it would look > like: > > var batchExecution = new FbBatchExceution(); > batchExecution.Statements.Add(script.Results); //maybe rename Results > > Statements??? > batchExecution.Execute(); > > Looks good to me. > > -- > Mgr. Jiří Činčura > Independent IT Specialist > >> -Original Message- >> From: Jiří Činčura >> Sent: Wednesday, June 10, 2015 3:36 PM >> To: firebird-net-provider@lists.sourceforge.net >> Subject: FbBatchExecution >> >> Hi guys, >> >> Looking at FbBatchExecution's ctor I don't see a reason why it takes >> FbScript. It should rather be FbStatementCollection I think. The >> FbBatchExecution is doing nothing with the FbScript. It just needs >> commands. >> >> What do you think? I would add another overload to ctor and make the one >> with FbScript obsolete. >> >> -- >> Mgr. Jiří Činčura >> Independent IT Specialist > > -- > ___ > Firebird-net-provider mailing list > Firebird-net-provider@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/firebird-net-provider -- ___ Firebird-net-provider mailing list Firebird-net-provider@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
Re: [Firebird-net-provider] FbBatchExecution
Thinking more about it. Maybe the ctor should be only with optional FbConnection and the rest can be done via SqlStatements property. Then it's not tied to FbScript at all. Maybe then the FbStatementCollection can have a simple "helper" method "Add(FbStatementCollection)" (or something like that). Then it would look like: var batchExecution = new FbBatchExceution(); batchExecution.Statements.Add(script.Results); //maybe rename Results > Statements??? batchExecution.Execute(); Looks good to me. -- Mgr. Jiří Činčura Independent IT Specialist > -Original Message- > From: Jiří Činčura > Sent: Wednesday, June 10, 2015 3:36 PM > To: firebird-net-provider@lists.sourceforge.net > Subject: FbBatchExecution > > Hi guys, > > Looking at FbBatchExecution's ctor I don't see a reason why it takes > FbScript. It should rather be FbStatementCollection I think. The > FbBatchExecution is doing nothing with the FbScript. It just needs > commands. > > What do you think? I would add another overload to ctor and make the one > with FbScript obsolete. > > -- > Mgr. Jiří Činčura > Independent IT Specialist -- ___ Firebird-net-provider mailing list Firebird-net-provider@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
Re: [Firebird-net-provider] FbBatchExecution
I don't use this. Though, propose looks good to me. On Wed, Jun 10, 2015 at 6:37 PM, Ivan Arabadzhiev wrote: > I did once suggest it should take raw String, a long time ago (did a lot of > magic to embed text files to run...). Still think it has uses, but I've > mostly moved away from .net now > > 2015-06-10 16:36 GMT+03:00 Jiří Činčura : >> >> Hi guys, >> >> Looking at FbBatchExecution's ctor I don't see a reason why it takes >> FbScript. It should rather be FbStatementCollection I think. The >> FbBatchExecution is doing nothing with the FbScript. It just needs commands. >> >> What do you think? I would add another overload to ctor and make the one >> with FbScript obsolete. >> >> -- >> Mgr. Jiří Činčura >> Independent IT Specialist >> >> >> -- >> ___ >> Firebird-net-provider mailing list >> Firebird-net-provider@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/firebird-net-provider > > > > -- > > ___ > Firebird-net-provider mailing list > Firebird-net-provider@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/firebird-net-provider > -- ___ Firebird-net-provider mailing list Firebird-net-provider@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
Re: [Firebird-net-provider] FbBatchExecution
I did once suggest it should take raw String, a long time ago (did a lot of magic to embed text files to run...). Still think it has uses, but I've mostly moved away from .net now 2015-06-10 16:36 GMT+03:00 Jiří Činčura : > Hi guys, > > Looking at FbBatchExecution's ctor I don't see a reason why it takes > FbScript. It should rather be FbStatementCollection I think. The > FbBatchExecution is doing nothing with the FbScript. It just needs commands. > > What do you think? I would add another overload to ctor and make the one > with FbScript obsolete. > > -- > Mgr. Jiří Činčura > Independent IT Specialist > > > -- > ___ > Firebird-net-provider mailing list > Firebird-net-provider@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/firebird-net-provider > -- ___ Firebird-net-provider mailing list Firebird-net-provider@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
[Firebird-net-provider] FbBatchExecution
Hi guys, Looking at FbBatchExecution's ctor I don't see a reason why it takes FbScript. It should rather be FbStatementCollection I think. The FbBatchExecution is doing nothing with the FbScript. It just needs commands. What do you think? I would add another overload to ctor and make the one with FbScript obsolete. -- Mgr. Jiří Činčura Independent IT Specialist -- ___ Firebird-net-provider mailing list Firebird-net-provider@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
Re: [Firebird-net-provider] FbBatchExecution VS DataTable
Hello: > Is it normal behavior? Yes. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Firebird-net-provider mailing list Firebird-net-provider@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
[Firebird-net-provider] FbBatchExecution VS DataTable
Hi, sorry if i'm missing something I try to run for example 18000 inserts. If i make it with FbBatchExecution, it takes appr. 100 seconds If i add the same 18000 rows to DataTable and then just save it with FbDataAdapter.Update, it takes near 30 seconds. Is it normal behavior? I thought, FbBatchExecution should be faster (or at least equal because, i suppose, that DataAdapter also uses some sort of batch execution for generated sql-statements). The code for Batch is pretty simple FbBatchExecution batch = new FbBatchExecution(FbConnection); batch.SqlStatements.AddRange(ScriptBuilder.GetStatements()); batch.Execute(true); //the delay is really here, not anywhere else Test Table is also simple CREATE TABLE AAA_1 ( ID INTEGER NOT NULL PRIMARY KEY, TEXT VARCHAR(30), DATUM DATE ); My Provider version is 2.1.0.0, Firebird - superserver 2.0 -- View this message in context: http://www.nabble.com/FbBatchExecution-VS-DataTable-tf3354120.html#a9328001 Sent from the firebird-net-provider mailing list archive at Nabble.com. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV___ Firebird-net-provider mailing list Firebird-net-provider@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
Re: [Firebird-net-provider] FbBatchExecution parse error
Hello: > It looks like the string '--' is parsed as the > begin of a comment text > > Any other string ( not containing "--" ) is parsed correcly. Ok, i will try to fix it as soon as possible - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Firebird-net-provider mailing list Firebird-net-provider@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
[Firebird-net-provider] FbBatchExecution parse error
I have an ASP.NET 2.0 application running a script with this istructions: ... SET TERM ^ ; CREATE PROCEDURE TEST RETURNS (VARNAME VARCHAR(20)) AS begin varname='---'; /* ERROR */ suspend; end ^ SET TERM ; ^ ... It looks like the string '--' is parsed as the begin of a comment text Any other string ( not containing "--" ) is parsed correcly. I am using Firebird CS 1.5.4.4910 FirebirdClient 2.0.1 VS2005 Client and Server on same PC O.S. WinXP sp2 -- Giuliano Asioli - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Firebird-net-provider mailing list Firebird-net-provider@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
Re: [Firebird-net-provider] FbBatchExecution
Hello: > Is that normal (I am using it in a faulty way) or do I have to do anything > more to complete my fbe execution? What version of the provider are you using ?? What version of Firebird are you using ?? What version of .NET/mono are you using ?? Can you send to my private email the isql script that is giving problems ?? - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ Firebird-net-provider mailing list Firebird-net-provider@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
[Firebird-net-provider] FbBatchExecution
If I use FbBatchExecution I have problems that indicate that the transactions are not commited correctly? The Execute() method could be called with an argument, autocommit. What is the difference between choosing true or false and what is default when calling Execute() ? If I use Execute(false) do I have to commit in any way after that? If I do fbe.Execute(); aptConn.Close(); FbConnection.ClearAllPools(); I get an exception 'FirebirdSql.Data.Firebird.FbException: cannot disconnect database with open transactions (1 active)' Is that normal (I am using it in a faulty way) or do I have to do anything more to complete my fbe execution? BR Ulf -- View this message in context: http://www.nabble.com/FbBatchExecution-tf2481002.html#a6918427 Sent from the firebird-net-provider mailing list archive at Nabble.com. - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ Firebird-net-provider mailing list Firebird-net-provider@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/firebird-net-provider
[Firebird-net-provider] FbBatchExecution with parameters
Hi, I used to execute multiple SELECT statements with parameters in a single Command with version 1.6.3 and everything worked fine. Then when I upgraded to 1.7 I noticed that this capability had been removed. I assume the correct way to execute multiple statements is to split it up and then use FbBatchExecution? But I can't find a way to use that with parameters. I'm using 1.7.1. Thanks for any input, /Hakan