Re: [Fish-users] fish_prompt.fish not getting called

[Robert Carpenter]

Hey Mark,

I've seen this too, and I spent some time digging around in the source today 
and I don't think there is a way around it: 
https://github.com/fish-shell/fish-shell/blob/cb352317bdd421d140771de62c23ee3c32138502/src/screen.cpp#L956-L961

Someone can correct me if I'm wrong here, but I believe the goal here is for 
fish to present something usable in all situations and when the prompt is too 
long, usability starts to decrease rapidly. 

Robert

> On Sep 30, 2017, at 13:59, Mark Volkmann  wrote:
> 
> Perhaps my function is getting called, but fish becomes convinced that my 
> prompt won't fit and so it just outputs "> ". I'm trying to manage that by 
> outputting a multi-line prompt where each line I output does fit, but I 
> suspect fish thinks I'm trying to output everything on a single line. Is 
> there another approach I can take to creating a multi-line prompt?
> 
> On Sat, Sep 30, 2017 at 2:33 PM, Mark Volkmann  
> wrote:
> I have defined a custom fish prompt that works great most of the time. I have 
> verified that it works when $COLUMNS is >= 57 or $COLUMNS is between 20 and 
> 47. However, my fish_prompt function doesn't even get called if $COLUMNS is 
> 52. Any idea what could cause that?
> 
> My code is at 
> https://github.com/mvolkmann/MyUnixEnv/blob/master/.config/fish/functions/fish_prompt.fish.
> 
> -- 
> R. Mark Volkmann
> Object Computing, Inc.
> 
> 
> 
> -- 
> R. Mark Volkmann
> Object Computing, Inc.
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! 
> http://sdm.link/slashdot___
> Fish-users mailing list
> Fish-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/fish-users


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Fish-users mailing list
Fish-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fish-users

Re: [Fish-users] fish_prompt.fish not getting called

[Mark Volkmann]

Maybe the issue is that left_prompt_layout.max_line_width isn't computed
correctly for multi-line prompts.

On Sat, Sep 30, 2017 at 3:53 PM, Robert Carpenter 
wrote:

> Hey Mark,
>
> I've seen this too, and I spent some time digging around in the source
> today and I don't think there is a way around it:
> https://github.com/fish-shell/fish-shell/blob/
> cb352317bdd421d140771de62c23ee3c32138502/src/screen.cpp#L956-L961
>
> Someone can correct me if I'm wrong here, but I believe the goal here is
> for fish to present something usable in all situations and when the prompt
> is too long, usability starts to decrease rapidly.
>
> Robert
>
> > On Sep 30, 2017, at 13:59, Mark Volkmann 
> wrote:
> >
> > Perhaps my function is getting called, but fish becomes convinced that
> my prompt won't fit and so it just outputs "> ". I'm trying to manage that
> by outputting a multi-line prompt where each line I output does fit, but I
> suspect fish thinks I'm trying to output everything on a single line. Is
> there another approach I can take to creating a multi-line prompt?
> >
> > On Sat, Sep 30, 2017 at 2:33 PM, Mark Volkmann <
> r.mark.volkm...@gmail.com> wrote:
> > I have defined a custom fish prompt that works great most of the time. I
> have verified that it works when $COLUMNS is >= 57 or $COLUMNS is between
> 20 and 47. However, my fish_prompt function doesn't even get called if
> $COLUMNS is 52. Any idea what could cause that?
> >
> > My code is at https://github.com/mvolkmann/
> MyUnixEnv/blob/master/.config/fish/functions/fish_prompt.fish.
> >
> > --
> > R. Mark Volkmann
> > Object Computing, Inc.
> >
> >
> >
> > --
> > R. Mark Volkmann
> > Object Computing, Inc.
> > 
> --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot__
> _
> > Fish-users mailing list
> > Fish-users@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/fish-users
>
>


-- 
R. Mark Volkmann
Object Computing, Inc.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Fish-users mailing list
Fish-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fish-users

Re: [Fish-users] fish_prompt.fish not getting called

[Mark Volkmann]

Perhaps my function is getting called, but fish becomes convinced that my
prompt won't fit and so it just outputs "> ". I'm trying to manage that by
outputting a multi-line prompt where each line I output does fit, but I
suspect fish thinks I'm trying to output everything on a single line. Is
there another approach I can take to creating a multi-line prompt?

On Sat, Sep 30, 2017 at 2:33 PM, Mark Volkmann 
wrote:

> I have defined a custom fish prompt that works great most of the time. I
> have verified that it works when $COLUMNS is >= 57 or $COLUMNS is between
> 20 and 47. However, my fish_prompt function doesn't even get called if
> $COLUMNS is 52. Any idea what could cause that?
>
> My code is at https://github.com/mvolkmann/MyUnixEnv/blob/
> master/.config/fish/functions/fish_prompt.fish.
>
> --
> R. Mark Volkmann
> Object Computing, Inc.
>



-- 
R. Mark Volkmann
Object Computing, Inc.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Fish-users mailing list
Fish-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fish-users

[Fish-users] fish_prompt.fish not getting called

[Mark Volkmann]

I have defined a custom fish prompt that works great most of the time. I
have verified that it works when $COLUMNS is >= 57 or $COLUMNS is between
20 and 47. However, my fish_prompt function doesn't even get called if
$COLUMNS is 52. Any idea what could cause that?

My code is at
https://github.com/mvolkmann/MyUnixEnv/blob/master/.config/fish/functions/fish_prompt.fish
.

-- 
R. Mark Volkmann
Object Computing, Inc.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Fish-users mailing list
Fish-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fish-users