Re: [Flac-dev] Git branch with compiling fixes for win32
On 11/14/2011 18:01, JonY wrote: On 11/10/2011 19:22, JonY wrote: On 11/10/2011 18:39, Erik de Castro Lopo wrote: I'm subscribed to the list (and I set my reply-to to the list). Please do not CC me. JonY wrote: Its probably on one of the sf tracker somewhere, I can't seem to find it anymore. It wasn't anything complicated, so I should be able to redo it quickly. I'm a Linux guy. I do not have easy access to a windows machine and don't have the time or patience to maintain one. For windows stuff I'll be relying on others to provide and test patches. Erik Alright, here's a quick fix, although it is more ugly than I remembered. Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h where available, and falls back to I64 on MSVC and then ll for others, all format warnings suppressed. Tested on MinGW. Sven-Hendrik, or any other mingw guys around, do you mind testing the patch too? Patch based on git master from https://git.xiph.org/mirrors/flac.git. Ifdef changes now consolidated into a single file. Ping, no comments? I noticed some more ifdeferies around that needs consolidating and warnings that need suppressing, that can go into a separate patch. signature.asc Description: OpenPGP digital signature ___ Flac-dev mailing list Flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [Flac-dev] Git branch with compiling fixes for win32
JonY wrote: On 11/14/2011 18:01, JonY wrote: On 11/10/2011 19:22, JonY wrote: On 11/10/2011 18:39, Erik de Castro Lopo wrote: I'm subscribed to the list (and I set my reply-to to the list). Please do not CC me. JonY wrote: Its probably on one of the sf tracker somewhere, I can't seem to find it anymore. It wasn't anything complicated, so I should be able to redo it quickly. I'm a Linux guy. I do not have easy access to a windows machine and don't have the time or patience to maintain one. For windows stuff I'll be relying on others to provide and test patches. Erik Alright, here's a quick fix, although it is more ugly than I remembered. Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h where available, and falls back to I64 on MSVC and then ll for others, all format warnings suppressed. Tested on MinGW. Sven-Hendrik, or any other mingw guys around, do you mind testing the patch too? Patch based on git master from https://git.xiph.org/mirrors/flac.git. Ifdef changes now consolidated into a single file. Ping, no comments? I noticed some more ifdeferies around that needs consolidating and warnings that need suppressing, that can go into a separate patch. Sorry, I got hit by the Gnome3 catastrophe of 2011 and I'm still trying to make my machine usable. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ Flac-dev mailing list Flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [Flac-dev] Git branch with compiling fixes for win32
On 11/16/2011 03:20, Erik de Castro Lopo wrote: JonY wrote: On 11/14/2011 18:01, JonY wrote: On 11/10/2011 19:22, JonY wrote: On 11/10/2011 18:39, Erik de Castro Lopo wrote: I'm subscribed to the list (and I set my reply-to to the list). Please do not CC me. JonY wrote: Its probably on one of the sf tracker somewhere, I can't seem to find it anymore. It wasn't anything complicated, so I should be able to redo it quickly. I'm a Linux guy. I do not have easy access to a windows machine and don't have the time or patience to maintain one. For windows stuff I'll be relying on others to provide and test patches. Erik Alright, here's a quick fix, although it is more ugly than I remembered. Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h where available, and falls back to I64 on MSVC and then ll for others, all format warnings suppressed. Tested on MinGW. Sven-Hendrik, or any other mingw guys around, do you mind testing the patch too? Patch based on git master from https://git.xiph.org/mirrors/flac.git. Ifdef changes now consolidated into a single file. Ping, no comments? I noticed some more ifdeferies around that needs consolidating and warnings that need suppressing, that can go into a separate patch. Sorry, I got hit by the Gnome3 catastrophe of 2011 and I'm still trying to make my machine usable. Erik Wow ok, haven't touched it since the gnone2 days, it was pretty decent back then. I'll come back later then. signature.asc Description: OpenPGP digital signature ___ Flac-dev mailing list Flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [Flac-dev] Git branch with compiling fixes for win32
On 11/09/11 02:58 pm, Erik de Castro Lopo wrote: If anyone else has Flac patches that they would like to see commited to the Xiph Git repo, now would be a good time to speak up. A couple of build system fixes for OS/2. Not very experienced with git so just attaching. Dave From e47dc34e2025cf0b700a8ff9ebbb7fac7e7999f1 Mon Sep 17 00:00:00 2001 From: Dave Yeo dave.r.yeo@gmail.com Date: Tue, 15 Nov 2011 20:37:16 -0800 Subject: [PATCH 1/2] GCC on OS/2 defaults to A.OUT so nasm should also generate A.OUT object files --- configure.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure.in b/configure.in index c6497a0..516edea 100644 --- a/configure.in +++ b/configure.in @@ -93,6 +93,7 @@ case $host in i386-*-openbsd3.[[0-3]]) OBJ_FORMAT=aoutb ;; *-*-cygwin|*mingw*) OBJ_FORMAT=win32 ;; *-*-darwin*) OBJ_FORMAT=macho ;; + *os2*) OBJ_FORMAT=aout ;; *) OBJ_FORMAT=elf ;; esac AC_SUBST(OBJ_FORMAT) -- 1.7.2.3 From 99a10229202ece9fd0be41af387911c694038187 Mon Sep 17 00:00:00 2001 From: Dave Yeo dave.r.yeo@gmail.com Date: Tue, 15 Nov 2011 21:25:47 -0800 Subject: [PATCH 2/2] Libtool fix for OS/2 to create shared libs (DLL) Libtool dies with this error libtool: link: warning: undefined symbols not allowed in i386-pc-os2-emx shared libraries without being passed --no-undefined --- configure.in |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/configure.in b/configure.in index 516edea..efed8dc 100644 --- a/configure.in +++ b/configure.in @@ -100,11 +100,15 @@ AC_SUBST(OBJ_FORMAT) case $host in *-*-cygwin|*mingw*) - # define this variable for enabling strict exports with libtool; for now, it's only supported by Win32 + # define this variable for enabling strict exports with libtool LT_NO_UNDEFINED=-no-undefined # -lwsock32 only needed because of ntohl() usage, can get rid of after that's gone: MINGW_WINSOCK_LIBS=-lwsock32 ;; + *os2*) + # OS/2 also supports this variable and needs it to produce a DLL + LT_NO_UNDEFINED=-no-undefined + ;; *) LT_NO_UNDEFINED= MINGW_WINSOCK_LIBS= -- 1.7.2.3 ___ Flac-dev mailing list Flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
