Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
By that I mean, anywhere that MM:SS:FF is accepted, so is MM:SS (whose meaning is MM:SS:00) , and further, allowing MM:SS to be used regardless of the sample rate. Then the MM:SS:00 special case can be removed; the user will always use MM:SS when the sample rate is not 44100. The tests probably also have to be augmented to cover MM:SS, and possibly the man page and html docs. From: Earl Chew earl_c...@yahoo.com To: Josh Coalson xf...@yahoo.com; flac-dev@xiph.org flac-dev@xiph.org Sent: Wednesday, May 2, 2012 11:13 AM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Josh, Sure. I can try. Would you give me a more detailed description of the requirement ? What exactly does general MM:SS handling mean ? Earl From: Josh Coalson xf...@yahoo.com To: Earl Chew earl_c...@yahoo.com; flac-dev@xiph.org flac-dev@xiph.org Sent: Tuesday, May 1, 2012 8:25:34 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Ah, I don't remember but it might have been a negative test that was supposed to give an error when used with the wrong sample rate. Anyway, could you do another patch that updates to general MM:SS handling? From: Earl Chew earl_c...@yahoo.com To: Josh Coalson xf...@yahoo.com; flac-dev@xiph.org flac-dev@xiph.org Sent: Thursday, April 26, 2012 3:12 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Josh, I see my name is mentioned in passing ;-) I submitted that patch because I thought it preferable to keep the test harness running. Backing this change out would also entail changing metaflac_test.sh accordingly, which at the time, I was hesitant to do. At the time I figured that at some point metaflac_test.sh was passing, so the code should probably allow it to pass. I'm ok either way. Earl From: Josh Coalson xf...@yahoo.com To: flac-dev@xiph.org flac-dev@xiph.org Sent: Wednesday, April 25, 2012 3:23:35 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion I haven't checked git yet but I hope this patch has not gone in. I don't like the special case that this is creating. It would be better to allow MM:SS everywhere but I consider that low priority. From: Earl Chew earl_c...@yahoo.com To: flac-dev@xiph.org flac-dev@xiph.org Sent: Thursday, January 5, 2012 8:27 PM Subject: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows metaflac_test.sh to pass. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32
From: Miroslav Lichvar mlich...@redhat.com Sent: Friday, May 4, 2012 9:09 AM On Fri, May 04, 2012 at 05:53:23PM +0200, Miroslav Lichvar wrote: The most interesting part of the patch is the rewrite of the FLAC__bitreader_read_rice_signed_block function, which in the git repo seems to have only couple lines changed since 1.2.1. Here is that part of the patch rebased against current git. In a quick test it gives a 10% speedup in decoding. Excellent! ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [PATCH] Add missing functions to SeekTable class
From: Cristian Rodríguez crrodrig...@opensuse.org Sent: Sunday, May 6, 2012 8:24 AM El 05/05/12 02:23, Bastiaan Timmer escribió: The attached patch adds the missing FLAC__metadata_object_seektable_*() functions from FLAC's metadata object methods (FLAC/metadata.h) to FLAC++'s SeekTable class. Of the 11 functions in the C API, only 4 are currently in the C++ API, this patch adds the missing 7. If this patch is ok, VorbisComment will be next. A quick look tells me only 5 out of 13 FLAC__metadata_object_vorbiscomment*() functions from FLAC/metadata.h exist in FLAC++'s VorbisComment class. Bas Timmer This patch looks fine to me.. if applied we either need to raise the C++ library SOVERSION and/or add a linker versioning script for *nix systems though. Looks good to me to. Erik, are you keeping up with patches? Lately I've only been able to follow along. The soname is a good point: the flac release numbers are tied to the format and I rely on the sonames to manage binary compatibility. Some maintainers don't like it but I think it's important for users: http://flac.sourceforge.net/faq.html#api__release_versioning ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] [PATCH] Add missing functions to SeekTable class
El 06/05/12 19:18, Josh Coalson escribió: From: Cristian Rodríguezcrrodrig...@opensuse.org Sent: Sunday, May 6, 2012 8:24 AM El 05/05/12 02:23, Bastiaan Timmer escribió: The attached patch adds the missing FLAC__metadata_object_seektable_*() functions from FLAC's metadata object methods (FLAC/metadata.h) to FLAC++'s SeekTable class. Of the 11 functions in the C API, only 4 are currently in the C++ API, this patch adds the missing 7. If this patch is ok, VorbisComment will be next. A quick look tells me only 5 out of 13 FLAC__metadata_object_vorbiscomment*() functions from FLAC/metadata.h exist in FLAC++'s VorbisComment class. Bas Timmer This patch looks fine to me.. if applied we either need to raise the C++ library SOVERSION and/or add a linker versioning script for *nix systems though. Looks good to me to. Erik, are you keeping up with patches? Lately I've only been able to follow along. The soname is a good point: the flac release numbers are tied to the format and I rely on the sonames to manage binary compatibility. Some maintainers don't like it but I think it's important for users: http://flac.sourceforge.net/faq.html#api__release_versioning Yes, The soname change is an annoyance for distributions but if there is no linker version script it is the only possible way to get package managers to do the right thing on updates/upgrades. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
