[flac-dev] PATCH for cpu.c

2013-08-21 Thread lvqcl 
1) Some time ago all project files for MSVC 6 were removed; it makes sense to 
remove the code that is necessary only for MSVC 6 and older compilers.

--- a\src\libFLAC\cpu.c 2013-08-13 13:30:24.0 +0400
+++ b\src\libFLAC\cpu.c 2013-08-16 21:46:42.177485300 +0400
@@ -285,14 +285,7 @@
  # ifdef USE_TRY_CATCH_FLAVOR
_try {
__asm {
-#  if _MSC_VER = 1200
-   /* VC6 assembler doesn't know SSE, have 
to emit bytecode instead */
-   _emit 0x0F
-   _emit 0x57
-   _emit 0xC0
-#  else
xorps xmm0,xmm0
-#  endif
}
}
_except(EXCEPTION_EXECUTE_HANDLER) {
@@ -307,14 +300,7 @@
/*  http://www.codeproject.com/cpp/gccasm.asp */
/*  http://www.hick.org/~mmiller/msvc_inline_asm.html */
__asm {
-#  if _MSC_VER = 1200
-   /* VC6 assembler doesn't know SSE, have to emit 
bytecode instead */
-   _emit 0x0F
-   _emit 0x57
-   _emit 0xC0
-#  else
xorps xmm0,xmm0
-#  endif
inc sse
nop
nop




2) MSVC produces warnings if FLAC__USE_3DNOW is not defined : variable 
FLAC__CPUINFO_IA32_CPUID_EXTENDED_AMD_xxx of static storage duration was 
declared but never referenced



--- a\src\libFLAC\cpu.c 2013-08-16 21:46:42.177485300 +0400
+++ b\src\libFLAC\cpu.c 2013-08-16 22:18:34.549866800 +0400
@@ -96,10 +96,12 @@
  /* these are flags in ECX of CPUID AX=0001 */
  static const unsigned FLAC__CPUINFO_IA32_CPUID_SSE3 = 0x0001;
  static const unsigned FLAC__CPUINFO_IA32_CPUID_SSSE3 = 0x0200;
+#ifdef FLAC__USE_3DNOW
  /* these are flags in EDX of CPUID AX=8001 */
  static const unsigned FLAC__CPUINFO_IA32_CPUID_EXTENDED_AMD_3DNOW = 
0x8000;
  static const unsigned FLAC__CPUINFO_IA32_CPUID_EXTENDED_AMD_EXT3DNOW = 
0x4000;
  static const unsigned FLAC__CPUINFO_IA32_CPUID_EXTENDED_AMD_EXTMMX = 
0x0040;
+#endif


  /*
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Ozkan Sezer 
On 8/21/13, lvqcl lvqcl.m...@gmail.com wrote:
 1) Some time ago all project files for MSVC 6 were removed; it makes sense
 to remove the code that is necessary only for MSVC 6 and older compilers.


One may still compile using command line instead of a project file. Does
it really hurt keeping such code?

--
O.S.
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Erik de Castro Lopo 
Ozkan Sezer wrote:

 On 8/21/13, lvqcl lvqcl.m...@gmail.com wrote:
  1) Some time ago all project files for MSVC 6 were removed; it makes sense
  to remove the code that is necessary only for MSVC 6 and older compilers.
 
 
 One may still compile using command line instead of a project file. Does
 it really hurt keeping such code?

Its crufty old code. I should be removed. It makes no sense to keep
supporting 20 year old compilers (MSVC6 was was released in 1989 and
MSVC7 in 1992 [0]). 

Erik


[0] https://en.wikipedia.org/wiki/Visual_C%2B%2B
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Timothy B. Terriberry 
Erik de Castro Lopo wrote:
 Its crufty old code. I should be removed. It makes no sense to keep
 supporting 20 year old compilers (MSVC6 was was released in 1989 and
 MSVC7 in 1992 [0]).

That's not quite accurate. MSC6 was released in 1989. MSVC was released 
in 1998. So only 15 years old :).

___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Timothy B. Terriberry 
Timothy B. Terriberry wrote:
 That's not quite accurate. MSC6 was released in 1989. MSVC was released
 in 1998. So only 15 years old :).

*MSVC6, I meant.

___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Erik de Castro Lopo 
Timothy B. Terriberry wrote:

 Erik de Castro Lopo wrote:
  Its crufty old code. I should be removed. It makes no sense to keep
  supporting 20 year old compilers (MSVC6 was was released in 1989 and
  MSVC7 in 1992 [0]).
 
 That's not quite accurate. MSC6 was released in 1989. MSVC was released 
 in 1998. So only 15 years old :).

Yes, you are correct. MSVC++6 was replaced by Visual C++ .NET in 2002.

Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Closing sf.net issue tracker

2013-08-21 Thread Ralph Giles 
On 13-08-19 3:54 AM, Erik de Castro Lopo wrote:
 All the winamp2 bugs can be ignored because upstream winamp already
 contains FLAC support and we dropped the plugin from the sources
 some time ago.

Ok, thanks. I'll just close those without forwarding.

 -r
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev