Re: [flac-dev] [PATCH 2/5] SIMD: remove extra space

2017-02-19 Thread Brian Willoughby
I agree with Erik regarding this patch.


On Feb 19, 2017, at 12:17 PM, Erik de Castro Lopo  wrote:
> lvqcl wrote:
>> Most libFLAC code don't have a space between if and a parenthesis,
>> so the patch removes them from lpc_intrin_sseNN.c files.
> 
> I don't really agree with this one. If anything I think we should
> slowly move to making the code insert a space between the `if` and
> the open parenthesis because its easier to read.
> 
> Erik

___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


Re: [flac-dev] [PATCH 2/5] SIMD: remove extra space

2017-02-19 Thread Erik de Castro Lopo
lvqcl wrote:

> Most libFLAC code don't have a space between if and a parenthesis,
> so the patch removes them from lpc_intrin_sseNN.c files.

I don't really agree with this one. If anything I think we should
slowly move to making the code insert a space between the `if` and
the open parenthesis because its easier to read.

Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


[flac-dev] [PATCH 2/5] SIMD: remove extra space

2017-02-18 Thread lvqcl

Most libFLAC code don't have a space between if and a parenthesis,
so the patch removes them from lpc_intrin_sseNN.c files.

02_spaces.patch
Description: Binary data
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev