Re: [flac-dev] Typos in the FLAC codebase
Erik de Castro Lopo wrote: 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test x$cpu_x86_64 = xtrue)' Not sure about this, but other names inside AM_CONDITIONALs begin with FLaC__, not FLAC__. A quote from configure.ac: NOTE that for many of the AM_CONDITIONALs we use the prefix FLaC__ instead of FLAC__ since autoconf triggers off 'AC_' in strings. I this was was a bug in and earlier version of autoconf, but I fixed it anyway, just for the sake of uniformity. IMHO for the sake of uniformity it's better to revert this commit http://git.xiph.org/?p=flac.git;a=commit;h=151739921b74fbf31420358a5fbeb094efa017ed because before it there was only one place of non-uniformity: line 140 in configure.ac, now there are several .c and .h files with all-caps FLAC__*** (FLAC__CPU_IA32, FLAC__HAS_NASM, FLaC__HAS_OGG) and suddenly FLaC__CPU_X86_64. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Typos in the FLAC codebase
lvqcl wrote: 1) src/share/grabbag/snprintf.c, line 42: 'on systems with a norrmal ISO C99' 'norrmal' - 'normal' 2) src/flac/encode.c, line 1661: '(eg, very short files, 1 fames)' 'fames' - frames? samples? bytes? Thanks for those two. Fixed and pushed. 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test x$cpu_x86_64 = xtrue)' Not sure about this, but other names inside AM_CONDITIONALs begin with FLaC__, not FLAC__. A quote from configure.ac: NOTE that for many of the AM_CONDITIONALs we use the prefix FLaC__ instead of FLAC__ since autoconf triggers off 'AC_' in strings. I this was was a bug in and earlier version of autoconf, but I fixed it anyway, just for the sake of uniformity. Cheers, Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Typos in the FLAC codebase
Erik de Castro Lopo wrote: 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test x$cpu_x86_64 = xtrue)' Not sure about this, but other names inside AM_CONDITIONALs begin with FLaC__, not FLAC__. A quote from configure.ac: NOTE that for many of the AM_CONDITIONALs we use the prefix FLaC__ instead of FLAC__ since autoconf triggers off 'AC_' in strings. I this was was a bug in and earlier version of autoconf, but I fixed it anyway, just for the sake of uniformity. But such names (FLaC__NO_ASM, FLaC__CPU_IA32, FLaC__CPU_PPC, FLaC__USE_3DNOW, ...) begin with 'FLaC__' only in configure.ac. In all source files (.c, .h, .cpp) they begin with 'FLAC__' (all caps). ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Typos in the FLAC codebase
Erik de Castro Lopo wrote: But such names (FLaC__NO_ASM, FLaC__CPU_IA32, FLaC__CPU_PPC, FLaC__USE_3DNOW, ...) begin with 'FLaC__' only in configure.ac. In all source files (.c, .h, .cpp) they begin with 'FLAC__' (all caps). Is this possibly the cause of the issue you mentioned in the email titled Bug in FLAC or in GCC or somewhere else?. I don't think so. This bug can be fixed by replacing -O3 by -O2, so preprocessor macros don't matter. Also the problem disappears if I add printf(elems = %u, elems); just before upper = (Int32_t) ceil (elems * (1. - RMS_PERCENTILE)); ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
[flac-dev] Typos in the FLAC codebase
1) src/share/grabbag/snprintf.c, line 42: 'on systems with a norrmal ISO C99' 'norrmal' - 'normal' 2) src/flac/encode.c, line 1661: '(eg, very short files, 1 fames)' 'fames' - frames? samples? bytes? 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test x$cpu_x86_64 = xtrue)' Not sure about this, but other names inside AM_CONDITIONALs begin with FLaC__, not FLAC__. A quote from configure.ac: NOTE that for many of the AM_CONDITIONALs we use the prefix FLaC__ instead of FLAC__ since autoconf triggers off 'AC_' in strings. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
