Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-04 Thread Martijn van Beurden
On 03-03-13 00:22, Erik de Castro Lopo wrote:
 I have personally tested this code on:

  x86-linux
  x86_64-linux
  powerpc-linux

Have you tried static building too? I just tried a bunch of switches for 
../configure and both --enable-static as well as --disable-shared 
--enable-static fails for me on Kubuntu 12.04 64-bit with the following 
error

  [...]
  CC memory.lo
   CC metadata_iterators.lo
 metadata_iterators.c: In function 'set_file_stats_':
 metadata_iterators.c:3298:2: warning: ignoring return value of 
 'chown', declared with attribute warn_unused_result [-Wunused-result]
 metadata_iterators.c:3299:2: warning: ignoring return value of 
 'chown', declared with attribute warn_unused_result [-Wunused-result]
 In file included from /usr/include/stdio.h:934:0,
  from metadata_iterators.c:37:
 metadata_iterators.c: In function 
 'read_metadata_block_data_cb_.constprop.24':
 /usr/include/x86_64-linux-gnu/bits/stdio2.h:274:1: error: inlining 
 failed in call to always_inline 'fread': indirect function call with a 
 yet undetermined callee
 metadata_iterators.c:2140:12: error: called from here
 In file included from /usr/include/stdio.h:934:0,
  from metadata_iterators.c:37:
 [...]

That same 'called from here' is repeated for 2155:13 and 2458:13.

I'm not really into programming, so I don't know whether or not this is 
a problem. :)

___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-04 Thread Erik de Castro Lopo
Martijn van Beurden wrote:

  'chown', declared with attribute warn_unused_result [-Wunused-result]
  metadata_iterators.c:3299:2: warning: ignoring return value of 
  'chown', declared with attribute warn_unused_result [-Wunused-result]
  In file included from /usr/include/stdio.h:934:0,

Thats an Ubuntu special. They have patched their libc headers and compilers
to catch these. However, you should be getting them regardless of whether
you are compiling static or shared.


Regardless, I will fix these for the next pre-release.

Cheers,
Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-04 Thread Martijn van Beurden
On 04-03-13 23:36, Erik de Castro Lopo wrote:
 However, you should be getting them regardless of whether you are 
 compiling static or shared. 

Yes, I get those for shared as well, but the error that follows it 
(error: inlining failed in call to always_inline 'fread' etc.) is only 
when compiling static.

___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-04 Thread Cristian Rodríguez
On 03/04/2013 07:36 PM, Erik de Castro Lopo wrote:
 Martijn van Beurden wrote:

 'chown', declared with attribute warn_unused_result [-Wunused-result]
 metadata_iterators.c:3299:2: warning: ignoring return value of
 'chown', declared with attribute warn_unused_result [-Wunused-result]
 In file included from /usr/include/stdio.h:934:0,

 Thats an Ubuntu special.

Nope, it is standard linux system nowdays.

They have patched their libc headers and compilers
 to catch these.

Nope. they just build with fortify_source by default ;)





___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-03 Thread Ralph Giles
On 13-03-02 3:22 PM, Erik de Castro Lopo wrote:

 http://downloads.xiph.org/releases/flac/beta/

On Mac 10.7.5 Apple clang 4.2, 'make check' fails because BSD and GNU
coreutils have incompatible format options for 'stat'.

If I change test/test_compression.sh to use:

  size=`stat -f %z ${fname}`

The self tests complete without error. Of course that won't work on a
GNU system. Stack overflow suggests 'wc -c' as a portable version:

  size=`wc -c ${fname}`

Which does work on the Mac.

 -r
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


[flac-dev] flac 1.3.0pre1 prelease

2013-03-02 Thread Erik de Castro Lopo
Hi all,

I finally managed to bite the bullet and roll a pre-release. Its
here:

http://downloads.xiph.org/releases/flac/beta/

I have personally tested this code on:

x86-linux
x86_64-linux
powerpc-linux

I have not yet done any work on making sure the changelog is up-to-date.
That will be done between now and the release. What I'm after now is
testing of this source tarball on as many systems as possible.

Cheers,
Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-02 Thread LRN
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 03.03.2013 03:22, Erik de Castro Lopo wrote:
 What I'm after now is testing of this source tarball on as many
 systems as possible.
W32 (mingw.org + MSys) - builds correctly. All tests passed.


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJRMpqQAAoJEOs4Jb6SI2CwdrAIAJKYAH+EqO+zvL34QWfk2fM7
DjI/RumJcz+94uSyiFKx3CnaHD7Os++Hh5BJu+8GXbc3QTef1Mp6Lx/LMdiMEsde
KRWs+9X8qit5p6y2NtqzcPVS/Awsu8EFqfXSeldc96TQkihlmwJ5Ff+s6QWuMSW7
0SwwVrZnoMg1vaotmp7SiJ0Rujg7MlwO5NTWWUfgMURj4TkSMGyG/tir8zXhuvE6
Fk2ee0cIKGUFUHRIxLVn7oCIcRvc0AjgJYmTFoVi0tzzKqsywzi8/wmMMm/2r733
v1olqYS1cUHGkRA111L9GfKYXJ15FDVtnCFy9EI17ACKys9KJK8nT/krmbfXLl8=
=IeCq
-END PGP SIGNATURE-
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-02 Thread Cristian Rodríguez
El 02/03/13 20:22, Erik de Castro Lopo escribió:
 Hi all,

 I finally managed to bite the bullet and roll a pre-release. Its
 here:

  http://downloads.xiph.org/releases/flac/beta/

 I have personally tested this code on:

  x86-linux
  x86_64-linux
  powerpc-linux



armv7 little endian hard float.
ppc64
ppc
(linux)
all test passes.


___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev