Re: [flac-dev] PATCH for MSVC++ 2005 Express
lvqcl wrote: Recently I downloaded MSVC++2005 Express Edition That was the free (as in free beer) version, right? and it turns out that it wasn't possible to compile all files without several changes: Is there not a later free (as in free beer) version? If there is, it makes little sense to keep maintaining project files for the old free version. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] Closing sf.net issue tracker
Ralph Giles wrote: As part of the ongoing move of FLAC's project hosting from sourceforge.net to xiph.org, we're planning to remove the issue tracker there. Erik doesn't check it, so issues filed there are just rotting, and that's a poor experience. We don't have a decent alternative at xiph.org at the moment. We've variously discussed setting up a bugzilla instance or using github. In the meantime, Erik said he would like to track and triage issues just though the mailing list. I pursuit of that goal, I'll go through the open issues in the sf.net tracker and post them here, then close them as they're addressed by Erik. I hope that way we can take down the tracker without missing any reports. There are quite a few, so list traffic will be higher than normal for a bit. Thanks Ralph. All the winamp2 bugs can be ignored because upstream winamp already contains FLAC support and we dropped the plugin from the sources some time ago. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
Re: [flac-dev] PATCH for MSVC++ 2005 Express
Erik de Castro Lopo mle...@mega-nerd.com wrote: Is there not a later free (as in free beer) version? There are also 2008, 2010 and 2012 versions. VS2012 Express requires Win7 to run (though it can create programs compatible with WinXP). VS2010 Express works on WinXP. It is possible to compile x86-64 programs with it, but it requires Platform SDK (also free). VS2005 and 2008 Express editions cannot create 64-bit apps. If there is, it makes little sense to keep maintaining project files for the old free version. VS2005 and VS2008 use *.sln and *.vcproj files to store project settings, while 2010 and 2012 use *.sln, *.vcxproj (note x: vc_x_proj) and *.vcxproj.filters files. And it's not possible to easily downgrade project files from VS2010 format to VS2008 format. I think that moving from VS2005 to VS2010 or 2012 is a good isea, but... for example, Winamp team still uses Visual Studio 2008 to build Winamp and all necessary libraries including libFLAC.dll. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
[flac-dev] PATCH for bitmath.h, part 2
I noticed another problem, now with _BitScanReverse64: --- a\src\libFLAC\include\private\bitmath.h 2013-08-16 23:02:38.869769500 +0400 +++ b\src\libFLAC\include\private\bitmath.h 2013-08-19 18:46:37.424494400 +0400 @@ -136,9 +136,9 @@ return sizeof(FLAC__uint64) * CHAR_BIT - 1 - __builtin_clzll(v); /* Sorry, only supported in win64/Itanium.. */ #elif (defined(_MSC_VER) (_MSC_VER = 1400)) (defined(_M_IA64) || defined(_WIN64)) -FLAC__uint64 idx; +unsigned long idx; _BitScanReverse64(idx, v); -return idx ^ 63U; +return (unsigned)idx ^ 63U; #else /* Brain-damaged compilers will use the fastest possible way that is, de Bruijn sequences (http://supertech.csail.mit.edu/papers/debruijn.pdf) ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
[flac-dev] sf bug 258 - don't calloc pointers
Bug suggests using literal assignment to initialize pointers in structures instead of calloc, to avoid pointer-representation assumptions. https://sourceforge.net/p/flac/bugs/258/ Pointers should not be initialised by the function calloc if they are a member of a bigger data structure. Would you like to deal with an internal representation that is not all-bits-0? http://c-faq.com/null/varieties.html I recommend to assign a 0 to data elements like buffer in the functions FLAC__bitreader_new and FLAC__bitwriter_new separately. http://flac.cvs.sourceforge.net/flac/flac/src/libFLAC/bitreader.c?revision=1.6view=markup http://flac.cvs.sourceforge.net/flac/flac/src/libFLAC/bitwriter.c?revision=1.8view=markup Are assignments for the data element words in the functions FLAC__bitreader_init and FLAC__bitwriter_init unnecassary in this context? ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
