[flashrom] Re: meson build failure on 32bit [linux]

2023-01-16 Thread Anastasia Klimchuk
Branden, I made a patch with that:
https://review.coreboot.org/c/flashrom/+/72038
If you could have a look and say whether this is what you have tested?
If you have an account in Gerrit you can approve the patch, if not you
can just reply here.

Would you like to be added as Tested-By tag? That would mean your real
name and email, if you agree on that.

Thank you!

-- 
Anastasia.
___
flashrom mailing list -- flashrom@flashrom.org
To unsubscribe send an email to flashrom-le...@flashrom.org


[flashrom] Re: meson build failure on 32bit [linux]

2023-01-14 Thread Anastasia Klimchuk
Very good news, thank you for the update!

Would you agree to send a patch to Gerrit? Have you used Gerrit before?
I think you are the best person to send a patch, because you have the
environment, and you did the actual testing.

As a plan B I could send a patch and add you as Tested-By , and a code
reviewer. But the first option would be ideal, if this is possible?

-- 
Anastasia.
___
flashrom mailing list -- flashrom@flashrom.org
To unsubscribe send an email to flashrom-le...@flashrom.org


[flashrom] Re: meson build failure on 32bit [linux]

2023-01-14 Thread Branden Waldner
I applied the patch and it built successfully without any further
warnings/errors. I also flashed a new build of coreboot with this
build without any issue (not that I expected any).


Branden Waldner
___
flashrom mailing list -- flashrom@flashrom.org
To unsubscribe send an email to flashrom-le...@flashrom.org


[flashrom] Re: meson build failure on 32bit [linux]

2023-01-14 Thread Anastasia Klimchuk
Hello Branden,

First of all, thanks heaps for testing v1.3.0-rc1 and posting on the list!

I looked at the logs, it seems you have this issue which was
discovered some time earlier: https://ticket.coreboot.org/issues/407
The issue has been reported on the #flashrom irc channel, and
potential solution has been suggested by reporter (see the description
in the ticket).
I currently don't have a 32-bit Linux environment, so I haven't done
anything yet :\ But looks like you have an environment, would you be
able to test the fix ? That would be so helpful!
Maybe you will be able to send a patch? :) I am looking at the
proposed solution in the ticket, and it very likely will work.

The root cause of the issue is: warnings in unit tests when building
for 32-bit Linux. And since we enabled the mode "treat warnings as
errors", this fails the build.
As a workaround, you can disable Werror by running in your builddir:

meson configure -Dwerror=false

This option is sticky: if you run it once the mode will stay until you
enable werror again.

Another option is to build without unit tests, although it is less
ideal because unit tests are useful.

Initially we did not mark this bug as release blocking, since it can
be worked around relatively easily. But if you are able to send a
patch we will gladly accept it and cherry-pick into the release
branch!

Let me know what you think? In any case, many thanks for your effort!

-- 
Anastasia.
___
flashrom mailing list -- flashrom@flashrom.org
To unsubscribe send an email to flashrom-le...@flashrom.org