Re: [Flightgear-devel] Code Typo?

[Jim Wilson]

> From: Patrick Quirk
> 
> Hopefully I'm not too out of date with this since I'm looking at 0.9.8 
> code and am not an active CVS watcher.
> 
> In file Main/viewer.cxx, in function MakeVIEW_OFFSET(...), on line ~118 
> where the third matrix is being made, there is the following line:
> 
> tmp = t * axis2[1];
> 
> Since this is making the third matrix from the third angle, shouldn't 
> this line be:
> 
> tmp = t * axis3[1];
> 
> I'd assume this has been fixed on CVS but don't have the time to set it 
> up and look, hopefully someone more involved in the dev process could 
> check on this one real quick.  Also is there an archive of this list or 
> a bug database that allows searching through it?

Hi Patrick,

Good catch.  The "Offset" angles are generated by the mouse and keyboard 
panning functions.  The heading-offset-deg and pitch-offset-deg angles are 
modified when you use the mouse to rotate the view left and right or up and 
down, respecitvely (i.e. when the pilot "looks around").  The roll axis angle 
(matrix 3) is just in there for completeness, but it actually isn't used 
anywhere.

That is why the fix doesn't appear to have any effect.  And it does waste a few 
cycles.  But then so does the whole function most of the time.  We could 
probably just fill with identity values if there are no offsets,  but then 
considering all the multiplications currently done per frame, that would not 
amount to much.

e.g.
1 0 0 0
0 1 0 0
0 0 1 0
0 0 0 1

Best,

Jim



___
Flightgear-devel mailing list
Flightgear-devel@flightgear.org
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
2f585eeea02e2c79d7b1d8c4963bae2d

Re: [Flightgear-devel] Code Typo?

[Patrick Quirk]

Ah, nifty tool that CVS browser, thanks :)  So am I correct in thinking 
that's a typo?  I haven't had time to change it and test it myself, 
thats for tomorrow, though I can't imagine too many bad things could 
happen (its amazing it works with that typo to begin with).



AJ MacLeod (email lists) wrote:


On Wednesday 06 Jul 2005 20:50, Patrick Quirk wrote:
 


In file Main/viewer.cxx, in function MakeVIEW_OFFSET(...), on line ~118
where the third matrix is being made, there is the following line:
tmp = t * axis2[1];
   



It's still in there...  You don't have to do a cvs checkout to view the 
current state of any file, by the way,  there's an interactive browser at


http://cvs.flightgear.org/cgi-bin/viewcvs/viewcvs.cgi/FlightGear/?cvsroot=FlightGear-0.9

Cheers,

AJ

___
Flightgear-devel mailing list
Flightgear-devel@flightgear.org
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
2f585eeea02e2c79d7b1d8c4963bae2d
 

begin:vcard
fn:Patrick Quirk
n:Quirk;Patrick
email;internet:[EMAIL PROTECTED]
tel;cell:919-260-9918
x-mozilla-html:FALSE
version:2.1
end:vcard

___
Flightgear-devel mailing list
Flightgear-devel@flightgear.org
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
2f585eeea02e2c79d7b1d8c4963bae2d

Re: [Flightgear-devel] Code Typo?

[AJ MacLeod (email lists)]

On Wednesday 06 Jul 2005 20:50, Patrick Quirk wrote:
> In file Main/viewer.cxx, in function MakeVIEW_OFFSET(...), on line ~118
> where the third matrix is being made, there is the following line:
> tmp = t * axis2[1];

It's still in there...  You don't have to do a cvs checkout to view the 
current state of any file, by the way,  there's an interactive browser at
 
http://cvs.flightgear.org/cgi-bin/viewcvs/viewcvs.cgi/FlightGear/?cvsroot=FlightGear-0.9

Cheers,

AJ

___
Flightgear-devel mailing list
Flightgear-devel@flightgear.org
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
2f585eeea02e2c79d7b1d8c4963bae2d

Re: [Flightgear-devel] Code Typo?

[Steven Beeckman]

Citeren Patrick Quirk <[EMAIL PROTECTED]>:

> 
> 
> I'd assume this has been fixed on CVS but don't have the time to set
> it 
> up and look, hopefully someone more involved in the dev process could
> 
> check on this one real quick.  Also is there an archive of this list
> or 
> a bug database that allows searching through it?
> 
> 
> 


The archives can be searched at the bottom of this page:
.

Greets,

Steven

___
Flightgear-devel mailing list
Flightgear-devel@flightgear.org
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
2f585eeea02e2c79d7b1d8c4963bae2d

[Flightgear-devel] Code Typo?

[Patrick Quirk]

Hopefully I'm not too out of date with this since I'm looking at 0.9.8 
code and am not an active CVS watcher.


In file Main/viewer.cxx, in function MakeVIEW_OFFSET(...), on line ~118 
where the third matrix is being made, there is the following line:


tmp = t * axis2[1];

Since this is making the third matrix from the third angle, shouldn't 
this line be:


tmp = t * axis3[1];

I'd assume this has been fixed on CVS but don't have the time to set it 
up and look, hopefully someone more involved in the dev process could 
check on this one real quick.  Also is there an archive of this list or 
a bug database that allows searching through it?



begin:vcard
fn:Patrick Quirk
n:Quirk;Patrick
email;internet:[EMAIL PROTECTED]
tel;work:919-962-1715
x-mozilla-html:FALSE
version:2.1
end:vcard

___
Flightgear-devel mailing list
Flightgear-devel@flightgear.org
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
2f585eeea02e2c79d7b1d8c4963bae2d