[Flightgear-devel] Re: FG CVS error report
* Georg Vollnhals -- Tuesday 08 November 2005 21:00:
Melchior FRANZ schrieb:
but for now I think we can live with that.
That is ok, I think it should only be fixed before the new version gets
officially out.
You don't seem to understand: this is a very *minor*, almost cosmetic
glitch, and I'll most likely not fix it for 0.9.9, but rather for
0.9.10/1.0.0.
one more serious problem:
- adjust HUD transparency
does not switch but after you leave the menue ('cancel') the *main*
How is this more serious? This is by *design* and was like that since
ages. It was hard coded and modal. I only changed that now because I felt
like it, and because I always found that dialog ugly. The transparency wasn't
justified and looked like a bug. (But can easily be added again if
necessary. :-)
one less serious problem:
- Browse internal properties does not switch,
Yes, because it's yet another hard-coded dialog, just like the airport
list dialog and the waypoint dialog. I'd like to get all of those
modernized after the 0.9.9 release.
Yes, might be - but we should tell them! It is all a question of
personal taste, but the new style is really nice and my default from
now. Yes, eye-candy somehow - but I also like my house much better after
I have painted it :-)
The funny thing is, though, that nobody came up with an alternative
'theme' yet.
m.
___
Flightgear-devel mailing list
Flightgear-devel@flightgear.org
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Re: FG CVS error report
Melchior FRANZ wrote: The funny thing is, though, that nobody came up with an alternative 'theme' yet. And why should one? The new style is very nice, not too intrusive when flighing at night. And it works now, so what more coule one want? Nine ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
[Flightgear-devel] Re: FG CVS error report
* Georg Vollnhals -- Tuesday 08 November 2005 21:00: [dynamic dialog components lost after them switching] That is ok, I think it should only be fixed before the new version gets officially out. Oh, well. You just can't rely on what I say. I felt like fixing that, too. Will commit later today. m. ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Re: FG CVS error report
Melchior FRANZ schrieb:
one more serious problem:
- adjust HUD transparency
does not switch but after you leave the menue ('cancel') the *main*
How is this more serious? This is by *design* and was like that since
ages.
Melchior, you cut off the very *important* part of the sentence:
- does not switch but after you leave the menue ('cancel') the
*main* menue is frozen (no reaction on clicks)
In my eyes something is serious when you make a legal keypress and
afterwards a big part of the programs functions don't work anymore = the
main menu is frozen = you can only use keycodes not the mouse and the
main-menue entries are not accessible anymore.
Ok, if this is by design then all is ok, I just reported an error
which might be a problem for *other* user.
Not for me anymore as I know about these features.
Regards
Georg
___
Flightgear-devel mailing list
Flightgear-devel@flightgear.org
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
2f585eeea02e2c79d7b1d8c4963bae2d
[Flightgear-devel] Re: FG CVS error report
* Georg Vollnhals -- Wednesday 09 November 2005 17:11:
- does not switch but after you leave the menue ('cancel') the
*main* menue is frozen (no reaction on clicks)
In my eyes something is serious when you make a legal keypress and
afterwards a big part of the programs functions don't work anymore
Yes, but it's the same with all modal dialogs. I didn't say it's a
good idea, but it was designed like that. It's annoying and *seems*
like a bug, so we'll change it. But it's really only legacy gui design,
not a bug. And the pending 0.9.9 release does not mean that we have
to improve everything that we can think of. I didn't criticize that
you reported it -- that was the right thing to do. I just didn't share
your opinion that it had to be fixed for the next release. Someone
has to spend the time after all. And there will be a release after
0.9.9, or two. ;-)
m.
___
Flightgear-devel mailing list
Flightgear-devel@flightgear.org
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Re: FG CVS error report
Melchior FRANZ schrieb: I didn't criticize that you reported it -- that was the right thing to do. I just didn't share your opinion that it had to be fixed for the next release. Someone has to spend the time after all. And there will be a release after 0.9.9, or two. ;-) m. This is ok :-) - other priorities and limited time is an important factor! After all, I am really happy with this new GUI style Cheers Georg ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
[Flightgear-devel] Re: FG CVS error report
* Georg Vollnhals -- Wednesday 09 November 2005 17:39: This is ok :-) - other priorities and limited time is an important factor! After all, I am really happy with this new GUI style And it's even fixed meanwhile, and I'm quite satisfied with the result. (Now it even re-opens the Nasal dialogs.) So your bug report encouraged me to fix the non-bug. ;-) The only thing that would be nice is if dialogs would remember their former position. They don't. And then there are the remaining hard-coded dialogs ... but some points *have* to be remain for 1.0.0/0.9.10, or we will be bored to death. m. ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
[Flightgear-devel] Re: FG CVS error report
* Georg Vollnhals -- Tuesday 08 November 2005 13:01: if I press [Shift - F10] .. cycle through GUI styles *AND* the Basic keys menu is still opened FlightGear freezes. Eeww ... I'll look into that ... I like that new GUI style very much. Is there a parameter to have it as default when starting FlightGear? Yes: --prop:sim/current-gui=1 m. ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
[Flightgear-devel] Re: FG CVS error report
* Georg Vollnhals -- Tuesday 08 November 2005 13:01: if I press [Shift - F10] .. cycle through GUI styles *AND* the Basic keys menu is still opened FlightGear freezes. Can't reproduce that. The dialog closes as it is supposed to. Can you provide a stack backtrace? m. ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Re: FG CVS error report
Can't reproduce that. The dialog closes as it is supposed to. Hi Melchior, just to be sure I updated and recompiled again. Same error as described. Shift+F10 when running FG changes GUI style back and forth without problems, Basic Key Window open + Shift/F10 freezes FG. Tested it several times, all default (KSFO + Cessna) directly after starting FG, CygWin/Windows XP Home. Can you provide a stack backtrace? m. Sorry, I think this is far behind my scope as Windows does not give any stack info back as FG is a Cygwin process. And I have to kill Cygwin with the Windows taskmanager as it freezes too. And my knowledge about Cygwin is very limited :-( May be some other Cygwin user can test whether it is an individual problem (then forget about it) or a general one? Regards Georg ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Re: FG CVS error report
Georg Vollnhals wrote:
Can
you provide a stack backtrace?
m.
Sorry, I think this is far behind my scope as Windows does not give
any stack info back as FG is a Cygwin process. And I have to kill
Cygwin with the Windows taskmanager as it freezes too. And my
knowledge about Cygwin is very limited :-(
May be some other Cygwin user can test whether it is an individual
problem (then forget about it) or a general one?
It's a general problem Georg but it's not visible if the memory is not
reused or marked as free by the debugger.
NewGUI::reinit ()
{
mapstring,FGDialog *::iterator iter;
vectorstring dlg;
// close all open dialogs and remember them ...
for (iter = _active_dialogs.begin(); iter != _active_dialogs.end();
iter++) {
dlg.push_back(iter-first);
closeDialog(iter-first);
}
}
closeDialog will indirectly destroy *iter, so you can not do a iter++
after that.
Harald.
kernel32.dll!7c81eb33()
kernel32.dll!7c81eb33()
FlightGear.exe!_nh_malloc_dbg(unsigned int nSize=0x0001, int
nhFlag=0x0003, int nBlockUse=0x0012ee70, const char *
szFileName=0x00365138, int nLine=0x0003) Ligne 267 + 0x7C
FlightGear.exe!_CxxThrowException(void * pExceptionObject=0x0012ee8c,
const _s__ThrowInfo * pThrowInfo=0x00cdd5b4) + 0x39 C++
FlightGear.exe!std::_Nomemory() Ligne 10 C++
FlightGear.exe!operator new(unsigned int size=0xfeeefef0) Ligne 15
C++
FlightGear.exe!std::_Allocatechar(unsigned int _Count=0xfeeefef0,
char * __formal=0x) Ligne 34 + 0x9 C++
FlightGear.exe!std::allocatorchar::allocate(unsigned int
_Count=0xfeeefef0) Ligne 137 + 0xb C++
FlightGear.exe!std::basic_stringchar,std::char_traitschar,std::allocatorchar
::_Copy(unsigned int _Newsize=0xfeeefeee, unsigned int _Oldlen=0x)
Ligne 1454 + 0xf C++
FlightGear.exe!std::basic_stringchar,std::char_traitschar,std::allocatorchar
::_Grow(unsigned int _Newsize=0xfeeefeee, bool _Trim=false) Ligne 1485
C++
FlightGear.exe!std::basic_stringchar,std::char_traitschar,std::allocatorchar
::assign(const
std::basic_stringchar,std::char_traitschar,std::allocatorchar
_Right={...}, unsigned int _Roff=0x, unsigned int _Count=0x)
Ligne 599 + 0x10 C++
FlightGear.exe!std::basic_stringchar,std::char_traitschar,std::allocatorchar
::basic_stringchar,std::char_traitschar,std::allocatorchar (const
std::basic_stringchar,std::char_traitschar,std::allocatorchar
_Right={...}) Ligne 326 C++
FlightGear.exe!std::vectorstd::basic_stringchar,std::char_traitschar,std::allocatorchar
,std::allocatorstd::basic_stringchar,std::char_traitschar,std::allocatorchar
::_Insert_n(std::vectorstd::basic_stringchar,std::char_traitschar,std::allocatorchar
,std::allocatorstd::basic_stringchar,std::char_traitschar,std::allocatorchar
::iterator _Where={...}, unsigned int _Count=0x0001, const
std::basic_stringchar,std::char_traitschar,std::allocatorchar
_Val={...}) Ligne 810 + 0xc C++
FlightGear.exe!std::vectorstd::basic_stringchar,std::char_traitschar,std::allocatorchar
,std::allocatorstd::basic_stringchar,std::char_traitschar,std::allocatorchar
::insert(std::vectorstd::basic_stringchar,std::char_traitschar,std::allocatorchar
,std::allocatorstd::basic_stringchar,std::char_traitschar,std::allocatorchar
::iterator _Where={...}, const
std::basic_stringchar,std::char_traitschar,std::allocatorchar
_Val={...}) Ligne 623C++
FlightGear.exe!std::vectorstd::basic_stringchar,std::char_traitschar,std::allocatorchar
,std::allocatorstd::basic_stringchar,std::char_traitschar,std::allocatorchar
::push_back(const
std::basic_stringchar,std::char_traitschar,std::allocatorchar
_Val={...}) Ligne 584 C++
FlightGear.exe!NewGUI::reinit() Ligne 60 C++
FlightGear.exe!do_reinit(const SGPropertyNode * arg=0x195c6620) Ligne
223 C++
FlightGear.exe!SGCommandMgr::execute(const
std::basic_stringchar,std::char_traitschar,std::allocatorchar
name={...}, const SGPropertyNode * arg=0x195c6620) Ligne 61 + 0x7C++
FlightGear.exe!f_fgcommand(Context * c=0x10b5d028, naRef me={...}, int
argc=0x0002, naRef * args=0x10b5dc38) Ligne 223 + 0x55 C++
FlightGear.exe!setupFuncall(Context * ctx=0x10b5d028, int
nargs=0x0002, int mcall=0x, int tail=0x0001) Ligne 253 + 0x1a
C
FlightGear.exe!run(Context * ctx=0x10b5d028) Ligne 568 + 0x39 C
FlightGear.exe!naCall(Context * ctx=0x10b5d028, naRef func={...}, int
argc=0x, naRef * args=0x, naRef obj={...}, naRef locals={...})
Ligne 724 + 0x9 C
FlightGear.exe!FGNasalSys::handleCommand(const SGPropertyNode *
arg=0x091eb490) Ligne 492 + 0x33 C++
FlightGear.exe!do_nasal(const SGPropertyNode * arg=0x091eb490) Ligne
182 C++
[Flightgear-devel] Re: FG CVS error report
* Harald JOHNSEN -- Tuesday 08 November 2005 18:25: closeDialog will indirectly destroy *iter, so you can not do a iter++ after that. Whoops. Thanks. Should be fixed now, along with some other problems and omissions. Please try. m. :-) ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Re: FG CVS error report
Melchior FRANZ wrote: * Harald JOHNSEN -- Tuesday 08 November 2005 18:25: closeDialog will indirectly destroy *iter, so you can not do a iter++ after that. Whoops. Thanks. Should be fixed now, along with some other problems and omissions. Please try. m. :-) There is no more crash ;) Just something strange with the Display airport Frequencies dialog. When first called it displays ok with the surrounding airports icao codes inside buttons, then if you change gui theme (shift F10) the dialog is redisplayed with the new theme but without the airports buttons. If called again from the menu, the dialog redisplay itself correctly. Harald. ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
[Flightgear-devel] Re: FG CVS error report
* Harald JOHNSEN -- Tuesday 08 November 2005 20:09: Just something strange with the Display airport Frequencies dialog. When first called it displays ok with the surrounding airports icao codes inside buttons, then if you change gui theme (shift F10) the dialog is redisplayed with the new theme but without the airports buttons. Same with the ATC communication dialog. That's because they are dynamic. ATCdialogs.cxx fill buttons in before displaying. If we let new_gui.cxx close the dialog, reload the gui and re-open, then ATCdialogs.cxx isn't invoked and the dynamic stuff is missing. I'll think about a solution, but for now I think we can live with that. I doubt that many people will find the themes feature at all. :-) m. ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Re: FG CVS error report
Melchior FRANZ schrieb:
..
but for now I think we can live with that.
That is ok, I think it should only be fixed before the new version gets
officially out.
I checked some other menues
one more serious problem:
- adjust HUD transparency
does not switch but after you leave the menue ('cancel') the *main*
menue is frozen (no reaction on clicks)
one less serious problem:
- Browse internal properties does not switch, but some (did not test a
lot) submenues do (what is fine) but are frozen in that status (when you
change back to the normal style).
I doubt that many people will
find the themes feature at all. :-)
m.
_
Yes, might be - but we should tell them! It is all a question of
personal taste, but the new style is really nice and my default from
now. Yes, eye-candy somehow - but I also like my house much better after
I have painted it :-)
Thank you, Melchior and Harald.
Regards
Georg
___
Flightgear-devel mailing list
Flightgear-devel@flightgear.org
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
2f585eeea02e2c79d7b1d8c4963bae2d
